Title: [252823] trunk/Source/WebCore
- Revision
- 252823
- Author
- [email protected]
- Date
- 2019-11-22 19:30:12 -0800 (Fri, 22 Nov 2019)
Log Message
REGRESSION (r252792?): 6 inspector/canvas tests crashing
https://bugs.webkit.org/show_bug.cgi?id=204542
Reviewed by Devin Rousso.
Copy the list of identifiers to a Vector before iterating over it
since m_identifierToInspectorCanvas could be mutated meanwhile.
* inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::recordCanvasAction):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (252822 => 252823)
--- trunk/Source/WebCore/ChangeLog 2019-11-23 02:25:44 UTC (rev 252822)
+++ trunk/Source/WebCore/ChangeLog 2019-11-23 03:30:12 UTC (rev 252823)
@@ -1,3 +1,16 @@
+2019-11-22 Ryosuke Niwa <[email protected]>
+
+ REGRESSION (r252792?): 6 inspector/canvas tests crashing
+ https://bugs.webkit.org/show_bug.cgi?id=204542
+
+ Reviewed by Devin Rousso.
+
+ Copy the list of identifiers to a Vector before iterating over it
+ since m_identifierToInspectorCanvas could be mutated meanwhile.
+
+ * inspector/agents/InspectorCanvasAgent.cpp:
+ (WebCore::InspectorCanvasAgent::recordCanvasAction):
+
2019-11-21 Ryosuke Niwa <[email protected]>
Associate each microtask with a task group and remove ActiveDOMCallbackMicrotask
Modified: trunk/Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp (252822 => 252823)
--- trunk/Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp 2019-11-23 02:25:44 UTC (rev 252822)
+++ trunk/Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp 2019-11-23 03:30:12 UTC (rev 252823)
@@ -457,7 +457,8 @@
auto& canvasAgent = *weakThis;
- for (auto& identifier : canvasAgent.m_recordingCanvasIdentifiers) {
+ auto identifiers = copyToVector(canvasAgent.m_recordingCanvasIdentifiers);
+ for (auto& identifier : identifiers) {
auto inspectorCanvas = canvasAgent.m_identifierToInspectorCanvas.get(identifier);
if (!inspectorCanvas)
continue;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
