Title: [253436] trunk/LayoutTests
Revision
253436
Author
[email protected]
Date
2019-12-12 10:33:29 -0800 (Thu, 12 Dec 2019)

Log Message

window.AudioContext / window.OfflineAudioContext should not be enumerable
https://bugs.webkit.org/show_bug.cgi?id=205163

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

* web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

LayoutTests:

* resources/testharnessreport.js:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (253435 => 253436)


--- trunk/LayoutTests/ChangeLog	2019-12-12 18:27:17 UTC (rev 253435)
+++ trunk/LayoutTests/ChangeLog	2019-12-12 18:33:29 UTC (rev 253436)
@@ -1,3 +1,12 @@
+2019-12-12  Chris Dumez  <[email protected]>
+
+        window.AudioContext / window.OfflineAudioContext should not be enumerable
+        https://bugs.webkit.org/show_bug.cgi?id=205163
+
+        Reviewed by Youenn Fablet.
+
+        * resources/testharnessreport.js:
+
 2019-12-12  Truitt Savell  <[email protected]>
 
         REGRESSION: [Mac wk1] imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html is a flakey failure

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (253435 => 253436)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2019-12-12 18:27:17 UTC (rev 253435)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2019-12-12 18:33:29 UTC (rev 253436)
@@ -1,3 +1,12 @@
+2019-12-12  Chris Dumez  <[email protected]>
+
+        window.AudioContext / window.OfflineAudioContext should not be enumerable
+        https://bugs.webkit.org/show_bug.cgi?id=205163
+
+        Reviewed by Youenn Fablet.
+
+        * web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
+
 2019-12-11  Chris Dumez  <[email protected]>
 
         Trying to set toString / valueOf on a cross-origin Location object should throw a SecurityError

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt (253435 => 253436)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt	2019-12-12 18:27:17 UTC (rev 253435)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt	2019-12-12 18:33:29 UTC (rev 253436)
@@ -7,7 +7,11 @@
 CONSOLE MESSAGE: line 302: Blocked a frame with origin "http://localhost:8800" from accessing a frame with origin "http://127.0.0.1:8800". Protocols, domains, and ports must match.
 CONSOLE MESSAGE: Unable to post message to http://does-not.exist. Recipient has origin http://127.0.0.1:8800.
 
+CONSOLE MESSAGE: Unable to post message to http://does-not.exist. Recipient has origin http://localhost:8800.
 
+CONSOLE MESSAGE: Unable to post message to http://does-not.exist. Recipient has origin http://127.0.0.1:8800.
+
+
 PASS Basic sanity-checking (cross-origin) 
 PASS Basic sanity-checking (same-origin + document.domain) 
 PASS Basic sanity-checking (cross-site) 
@@ -15,12 +19,8 @@
 PASS Only whitelisted properties are accessible cross-origin (same-origin + document.domain) 
 PASS Only whitelisted properties are accessible cross-origin (cross-site) 
 FAIL Only whitelisted properties are usable as cross-origin this objects (cross-origin) promise_test: Unhandled rejection with value: object "SyntaxError: The string did not match the expected pattern."
-FAIL Only whitelisted properties are usable as cross-origin this objects (same-origin + document.domain) assert_throws: Should throw when calling window.AudioContext with cross-origin this object function "function webkitAudioContext() {
-    [native code]
-}" threw object "TypeError: Constructor requires 'new' operator" that is not a DOMException SecurityError: property "code" is equal to undefined, expected 18
-FAIL Only whitelisted properties are usable as cross-origin this objects (cross-site) assert_throws: Should throw when calling window.AudioContext with cross-origin this object function "function webkitAudioContext() {
-    [native code]
-}" threw object "TypeError: Constructor requires 'new' operator" that is not a DOMException SecurityError: property "code" is equal to undefined, expected 18
+FAIL Only whitelisted properties are usable as cross-origin this objects (same-origin + document.domain) promise_test: Unhandled rejection with value: object "SyntaxError: The string did not match the expected pattern."
+FAIL Only whitelisted properties are usable as cross-origin this objects (cross-site) promise_test: Unhandled rejection with value: object "SyntaxError: The string did not match the expected pattern."
 PASS [[GetPrototypeOf]] should return null (cross-origin) 
 PASS [[GetPrototypeOf]] should return null (same-origin + document.domain) 
 PASS [[GetPrototypeOf]] should return null (cross-site) 

Modified: trunk/LayoutTests/resources/testharnessreport.js (253435 => 253436)


--- trunk/LayoutTests/resources/testharnessreport.js	2019-12-12 18:27:17 UTC (rev 253435)
+++ trunk/LayoutTests/resources/testharnessreport.js	2019-12-12 18:33:29 UTC (rev 253436)
@@ -24,8 +24,10 @@
 
     // Make WebAudio map to webkitWebAudio for WPT tests
     if (location.port == 8800 || location.port == 9443) {
-        self.AudioContext = self.webkitAudioContext;
-        self.OfflineAudioContext = self.webkitOfflineAudioContext;
+        if (window.webkitAudioContext && !window.AudioContext)
+            Object.defineProperty(self, "AudioContext", Object.getOwnPropertyDescriptor(self, "webkitAudioContext"));
+        if (window.webkitOfflineAudioContext && !window.OfflineAudioContext)
+            Object.defineProperty(self, "OfflineAudioContext", Object.getOwnPropertyDescriptor(self, "webkitOfflineAudioContext"));
     }
 
     if (testRunner.setStatisticsShouldDowngradeReferrer) 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to