Title: [253437] trunk/Source/WebInspectorUI
- Revision
- 253437
- Author
- [email protected]
- Date
- 2019-12-12 10:33:53 -0800 (Thu, 12 Dec 2019)
Log Message
Web Inspector: Error: Can't make a ContentView for an unknown representedObject of type: CallFrame
https://bugs.webkit.org/show_bug.cgi?id=204823
Reviewed by Devin Rousso.
If no type is stored in the cookie matching by type should fail.
* UserInterface/Views/NavigationSidebarPanel.js:
(WI.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie.treeElementMatchesCookie):
(WI.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (253436 => 253437)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-12-12 18:33:29 UTC (rev 253436)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-12-12 18:33:53 UTC (rev 253437)
@@ -1,3 +1,16 @@
+2019-12-12 Yury Semikhatsky <[email protected]>
+
+ Web Inspector: Error: Can't make a ContentView for an unknown representedObject of type: CallFrame
+ https://bugs.webkit.org/show_bug.cgi?id=204823
+
+ Reviewed by Devin Rousso.
+
+ If no type is stored in the cookie matching by type should fail.
+
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WI.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie.treeElementMatchesCookie):
+ (WI.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
+
2019-12-12 Devin Rousso <[email protected]>
Web Inspector: REGRESSION(r251227): Uncaught Exception: undefined is not an object (evaluating 'target.DOMAgent.setInspectModeEnabled')
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (253436 => 253437)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2019-12-12 18:33:29 UTC (rev 253436)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2019-12-12 18:33:53 UTC (rev 253437)
@@ -705,7 +705,7 @@
return false;
if (matchTypeOnly)
- return true;
+ return !!typeIdentifier;
var candidateObjectCookie = {};
if (representedObject.saveIdentityToCookie)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
