Title: [254427] trunk/Source/WebCore
Revision
254427
Author
[email protected]
Date
2020-01-13 03:54:07 -0800 (Mon, 13 Jan 2020)

Log Message

[LFC][Integration] imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html crashes on iOS
https://bugs.webkit.org/show_bug.cgi?id=206151

Reviewed by Zalan Bujtas.

* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLayoutBox):

LFC doesn't expect line break boxes with float set (other layout systems just ignore it).

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (254426 => 254427)


--- trunk/Source/WebCore/ChangeLog	2020-01-13 10:14:41 UTC (rev 254426)
+++ trunk/Source/WebCore/ChangeLog	2020-01-13 11:54:07 UTC (rev 254427)
@@ -1,5 +1,17 @@
 2020-01-13  Antti Koivisto  <[email protected]>
 
+        [LFC][Integration] imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html crashes on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=206151
+
+        Reviewed by Zalan Bujtas.
+
+        * layout/layouttree/LayoutTreeBuilder.cpp:
+        (WebCore::Layout::TreeBuilder::createLayoutBox):
+
+        LFC doesn't expect line break boxes with float set (other layout systems just ignore it).
+
+2020-01-13  Antti Koivisto  <[email protected]>
+
         [LFC][IFC] fast/text/fast-run-width-vs-slow-run-width.html is failing
         https://bugs.webkit.org/show_bug.cgi?id=206143
 

Modified: trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp (254426 => 254427)


--- trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp	2020-01-13 10:14:41 UTC (rev 254426)
+++ trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp	2020-01-13 11:54:07 UTC (rev 254427)
@@ -195,6 +195,7 @@
 
         if (is<RenderLineBreak>(renderer)) {
             clonedStyle.setDisplay(DisplayType::Inline);
+            clonedStyle.setFloating(Float::No);
             childLayoutBox = makeUnique<Box>(elementAttributes(renderer), WTFMove(clonedStyle));
         } else if (is<RenderTable>(renderer)) {
             // Construct the principal table wrapper box (and not the table box itself).
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to