Title: [254428] trunk
Revision
254428
Author
[email protected]
Date
2020-01-13 04:47:32 -0800 (Mon, 13 Jan 2020)

Log Message

[LFC][Integration] Enable LFC integration
https://bugs.webkit.org/show_bug.cgi?id=206128

Reviewed by Zalan Bujtas.

Source/WebCore:

Enable the new line layout path.

* page/RuntimeEnabledFeatures.h:

Source/WebKit:

* Shared/WebPreferences.yaml:

LayoutTests:

Rebase for some progressions.

* fast/dom/Range/getBoundingClientRect-expected.txt:
* fast/dom/Range/getBoundingClientRect.html:

Update the test for new results. These match the complex line layout results (simple lines produce wrong results).

* platform/ios/fast/text/whitespace/pre-break-word-expected.txt:
* platform/ios/fast/text/word-break-expected.txt:
* platform/mac/fast/text/hyphenate-limit-lines-expected.txt:
* platform/mac/fast/text/whitespace/pre-break-word-expected.txt:
* platform/mac/fast/text/word-break-expected.txt:

Line breaking and white-space progressions.

* platform/ios/TestExpectations:

A subtest of editing/text-iterator/findString.html fails on iOS. This needs futher analysis.

* platform/win/TestExpectations:

fast/dom/Range/getBoundingClientRect.html now fails on windows because LFC is not enabled there.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (254427 => 254428)


--- trunk/LayoutTests/ChangeLog	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/ChangeLog	2020-01-13 12:47:32 UTC (rev 254428)
@@ -1,5 +1,35 @@
 2020-01-13  Antti Koivisto  <[email protected]>
 
+        [LFC][Integration] Enable LFC integration
+        https://bugs.webkit.org/show_bug.cgi?id=206128
+
+        Reviewed by Zalan Bujtas.
+
+        Rebase for some progressions.
+
+        * fast/dom/Range/getBoundingClientRect-expected.txt:
+        * fast/dom/Range/getBoundingClientRect.html:
+
+        Update the test for new results. These match the complex line layout results (simple lines produce wrong results).
+
+        * platform/ios/fast/text/whitespace/pre-break-word-expected.txt:
+        * platform/ios/fast/text/word-break-expected.txt:
+        * platform/mac/fast/text/hyphenate-limit-lines-expected.txt:
+        * platform/mac/fast/text/whitespace/pre-break-word-expected.txt:
+        * platform/mac/fast/text/word-break-expected.txt:
+
+        Line breaking and white-space progressions.
+
+        * platform/ios/TestExpectations:
+
+        A subtest of editing/text-iterator/findString.html fails on iOS. This needs futher analysis.
+
+        * platform/win/TestExpectations:
+
+        fast/dom/Range/getBoundingClientRect.html now fails on windows because LFC is not enabled there.
+
+2020-01-13  Antti Koivisto  <[email protected]>
+
         [LFC][Integration] Ensure that simple line layout tests stays don't turn into LFC tests
         https://bugs.webkit.org/show_bug.cgi?id=206153
 

Modified: trunk/LayoutTests/TestExpectations (254427 => 254428)


--- trunk/LayoutTests/TestExpectations	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/TestExpectations	2020-01-13 12:47:32 UTC (rev 254428)
@@ -3222,3 +3222,5 @@
 # To aid transition to ANGLE backend for WebGL, skip all of WebGL 2 tests for now. 
 # Re-enable as each chunk of tests are verified with ANGLE backend.
 webgl/2.0.0 [ Skip ]
+
+webkit.org/b/206168 [ Debug ] fast/dom/insert-span-into-long-text-bug-28245.html [ Skip ]

Modified: trunk/LayoutTests/fast/dom/Range/getBoundingClientRect-expected.txt (254427 => 254428)


--- trunk/LayoutTests/fast/dom/Range/getBoundingClientRect-expected.txt	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/fast/dom/Range/getBoundingClientRect-expected.txt	2020-01-13 12:47:32 UTC (rev 254428)
@@ -48,9 +48,9 @@
 
 Test 7
 PASS rect.left.toFixed(3) is "8.000"
-PASS rect.top.toFixed(3) is "2180.000"
+PASS rect.top.toFixed(3) is "2168.000"
 PASS rect.width.toFixed(3) is "192.000"
-PASS rect.height.toFixed(3) is "96.000"
+PASS rect.height.toFixed(3) is "108.000"
 PASS rect.right is rect.left + rect.width
 PASS rect.bottom is rect.top + rect.height
 

Modified: trunk/LayoutTests/fast/dom/Range/getBoundingClientRect.html (254427 => 254428)


--- trunk/LayoutTests/fast/dom/Range/getBoundingClientRect.html	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/fast/dom/Range/getBoundingClientRect.html	2020-01-13 12:47:32 UTC (rev 254428)
@@ -115,7 +115,7 @@
         /*4*/  { left: 0, top: 0, width: 0, height: 0 },
         /*5*/  { left: -14.574, top: 1761.947, width: 504.009, height: 535.849 },
         /*6*/  { left: 0, top: 0, width: 0, height: 0 },
-        /*7*/  { left: 8, top: 2180, width: 192, height: 96 },
+        /*7*/  { left: 8, top: 2168, width: 192, height: 108 },
     ];
 
     // Range over entire element.

Modified: trunk/LayoutTests/platform/ios/TestExpectations (254427 => 254428)


--- trunk/LayoutTests/platform/ios/TestExpectations	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-01-13 12:47:32 UTC (rev 254428)
@@ -3462,3 +3462,5 @@
 webkit.org/b/205309 scrollingcoordinator/ios/scroll-position-after-reattach.html [ ImageOnlyFailure ]
 
 webkit.org/b/200043 fast/text/international/system-language/navigator-language [ Pass Failure ]
+
+webkit.org/b/206164 editing/text-iterator/findString.html [ Failure ]

Modified: trunk/LayoutTests/platform/ios/fast/text/whitespace/pre-break-word-expected.txt (254427 => 254428)


--- trunk/LayoutTests/platform/ios/fast/text/whitespace/pre-break-word-expected.txt	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/platform/ios/fast/text/whitespace/pre-break-word-expected.txt	2020-01-13 12:47:32 UTC (rev 254428)
@@ -1,14 +1,8 @@
-layer at (0,0) size 800x600
+layer at (0,0) size 920x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600
   RenderBlock {HTML} at (0,0) size 800x600
     RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {DIV} at (0,0) size 154x144 [border: (2px solid #FF0000)]
-        RenderText {#text} at (2,2) size 148x139
-          text run at (2,2) width 148: "Even though this div is"
-          text run at (2,22) width 148: " white-space pre, the te"
-          text run at (2,42) width 145: "xt inside should still w"
-          text run at (2,62) width 148: "rap to multiple lines be"
-          text run at (2,82) width 143: "cause of the word-wra"
-          text run at (2,102) width 144: "p:break-word CSS pro"
-          text run at (2,122) width 36: "perty."
+      RenderBlock {DIV} at (0,0) size 154x24 [border: (2px solid #FF0000)]
+        RenderText {#text} at (2,2) size 911x19
+          text run at (2,2) width 911: "Even though this div is white-space pre, the text inside should still wrap to multiple lines because of the word-wrap:break-word CSS property."

Modified: trunk/LayoutTests/platform/ios/fast/text/word-break-expected.txt (254427 => 254428)


--- trunk/LayoutTests/platform/ios/fast/text/word-break-expected.txt	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/platform/ios/fast/text/word-break-expected.txt	2020-01-13 12:47:32 UTC (rev 254428)
@@ -1,8 +1,8 @@
-layer at (0,0) size 800x1028
+layer at (0,0) size 800x972
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x1028
-  RenderBlock {HTML} at (0,0) size 800x1028
-    RenderBody {BODY} at (8,8) size 784x1012
+layer at (0,0) size 800x972
+  RenderBlock {HTML} at (0,0) size 800x972
+    RenderBody {BODY} at (8,8) size 784x956
       RenderBlock (anonymous) at (0,0) size 784x20
         RenderText {#text} at (0,0) size 700x19
           text run at (0,0) width 700: "This example tests that word-break properly shrinks a cell to one character per line when it is set to break-all."
@@ -17,7 +17,7 @@
                 text run at (6,48) width 8: "r"
                 text run at (6,62) width 8: "o"
                 text run at (6,76) width 8: "w"
-            RenderTableCell {TD} at (20,35) size 762x26 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+            RenderTableCell {TD} at (19,35) size 763x26 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
               RenderText {#text} at (6,6) size 164x14
                 text run at (6,6) width 164: "This cell should grow"
       RenderBlock (anonymous) at (0,118) size 784x40
@@ -27,6 +27,7 @@
       RenderBlock {PRE} at (0,171) size 110x24 [border: (5px solid #000000)]
         RenderText {#text} at (5,5) size 437x14
           text run at (5,5) width 437: "Thislongwordshouldnotgetbrokenbutshouldstickoutofthepre."
+          text run at (441,5) width 1: " "
       RenderBlock (anonymous) at (0,208) size 784x80
         RenderBR {BR} at (0,0) size 0x19
         RenderText {#text} at (0,20) size 774x59
@@ -45,19 +46,16 @@
                 text run at (6,48) width 8: "r"
                 text run at (6,62) width 8: "o"
                 text run at (6,76) width 8: "w"
-            RenderTableCell {TD} at (20,35) size 762x26 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+            RenderTableCell {TD} at (19,35) size 763x26 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
               RenderText {#text} at (6,6) size 164x14
                 text run at (6,6) width 164: "This cell should grow"
       RenderBlock (anonymous) at (0,386) size 784x20
         RenderBR {BR} at (0,0) size 0x19
-      RenderBlock {PRE} at (0,419) size 110x80 [border: (5px solid #000000)]
-        RenderText {#text} at (5,5) size 94x70
-          text run at (5,5) width 94: "Thislongword"
-          text run at (5,19) width 94: "shouldnotget"
-          text run at (5,33) width 94: "brokenbutsho"
-          text run at (5,47) width 94: "uldstickouto"
-          text run at (5,61) width 63: "fthepre."
-      RenderBlock (anonymous) at (0,512) size 784x80
+      RenderBlock {PRE} at (0,419) size 110x24 [border: (5px solid #000000)]
+        RenderText {#text} at (5,5) size 437x14
+          text run at (5,5) width 437: "Thislongwordshouldnotgetbrokenbutshouldstickoutofthepre."
+          text run at (441,5) width 1: " "
+      RenderBlock (anonymous) at (0,456) size 784x80
         RenderBR {BR} at (0,0) size 0x19
         RenderText {#text} at (0,20) size 776x59
           text run at (0,20) width 641: "This test makes sure floating and positioned elements do the right thing with word-break: break-all. "
@@ -65,7 +63,7 @@
           text run at (0,40) width 305: "should be less than the containing block width. "
           text run at (304,40) width 472: "The breaking should be \"dumb\" and just occur when the end of the line is"
           text run at (0,60) width 21: "hit."
-      RenderBlock {DIV} at (0,592) size 304x46 [border: (2px solid #000000)]
+      RenderBlock {DIV} at (0,536) size 304x46 [border: (2px solid #000000)]
         RenderBlock (floating) {DIV} at (2,2) size 300x42
           RenderText {#text} at (0,0) size 297x42
             text run at (0,0) width 297: "Eventhoughthishasareallylongword itsho"
@@ -72,9 +70,9 @@
             text run at (0,14) width 297: "uldnotstick out oftheenclosing300pxblo"
             text run at (0,28) width 24: "ck."
         RenderBR {BR} at (302,2) size 0x14
-      RenderBlock (anonymous) at (0,638) size 784x20
+      RenderBlock (anonymous) at (0,582) size 784x20
         RenderBR {BR} at (0,0) size 0x19
-      RenderBlock (anonymous) at (0,762) size 784x80
+      RenderBlock (anonymous) at (0,706) size 784x80
         RenderBR {BR} at (0,0) size 0x19
         RenderText {#text} at (0,20) size 783x59
           text run at (0,20) width 658: "This test makes sure floating and positioned elements do the right thing with word-break: break-word. "
@@ -82,7 +80,7 @@
           text run at (0,40) width 345: "width should be less than the containing block width. "
           text run at (344,40) width 439: "The breaking should be \"smart\" and be like word-wrap: break-word,"
           text run at (0,60) width 540: "with words preferring to wrap first before allowing break opportunities within them."
-      RenderBlock {DIV} at (0,842) size 304x46 [border: (2px solid #000000)]
+      RenderBlock {DIV} at (0,786) size 304x46 [border: (2px solid #000000)]
         RenderBlock (floating) {DIV} at (2,2) size 300x42
           RenderText {#text} at (0,0) size 250x42
             text run at (0,0) width 250: "Eventhoughthishasareallylongword"
@@ -89,19 +87,19 @@
             text run at (0,14) width 157: "itshouldnotstick out"
             text run at (0,28) width 196: "oftheenclosing300pxblock."
         RenderBR {BR} at (302,2) size 0x14
-      RenderBlock (anonymous) at (0,888) size 784x20
+      RenderBlock (anonymous) at (0,832) size 784x20
         RenderBR {BR} at (0,0) size 0x19
-layer at (8,666) size 304x104
-  RenderBlock (relative positioned) {DIV} at (0,658) size 304x104 [border: (2px solid #000000)]
-layer at (10,668) size 300x42
+layer at (8,610) size 304x104
+  RenderBlock (relative positioned) {DIV} at (0,602) size 304x104 [border: (2px solid #000000)]
+layer at (10,612) size 300x42
   RenderBlock (positioned) {DIV} at (2,2) size 300x42
     RenderText {#text} at (0,0) size 297x42
       text run at (0,0) width 297: "Eventhoughthishasareallylongword itsho"
       text run at (0,14) width 297: "uldnotstick out oftheenclosing300pxblo"
       text run at (0,28) width 24: "ck."
-layer at (8,916) size 304x104
-  RenderBlock (relative positioned) {DIV} at (0,908) size 304x104 [border: (2px solid #000000)]
-layer at (10,918) size 300x42
+layer at (8,860) size 304x104
+  RenderBlock (relative positioned) {DIV} at (0,852) size 304x104 [border: (2px solid #000000)]
+layer at (10,862) size 300x42
   RenderBlock (positioned) {DIV} at (2,2) size 300x42
     RenderText {#text} at (0,0) size 250x42
       text run at (0,0) width 250: "Eventhoughthishasareallylongword"

Modified: trunk/LayoutTests/platform/mac/fast/text/hyphenate-limit-lines-expected.txt (254427 => 254428)


--- trunk/LayoutTests/platform/mac/fast/text/hyphenate-limit-lines-expected.txt	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/platform/mac/fast/text/hyphenate-limit-lines-expected.txt	2020-01-13 12:47:32 UTC (rev 254428)
@@ -58,7 +58,7 @@
           text run at (1,156) width 200: "pleasures and de" + hyphen string "-"
           text run at (1,187) width 200: "sires into neces" + hyphen string "-"
           text run at (1,218) width 200: "sary and"
-          text run at (1,249) width 200: "unnecessary\x{2014}"
+          text run at (1,249) width 154: "unnecessary\x{2014}"
           text run at (1,280) width 200: "these and other"
           text run at (1,311) width 200: "great forms of"
           text run at (1,342) width 200: "thought are all of"
@@ -80,7 +80,7 @@
           text run at (1,187) width 200: "sires into"
           text run at (1,218) width 166: "necessary and "
           text run at (166,218) width 35: "un" + hyphen string "-"
-          text run at (1,249) width 200: "necessary\x{2014}these"
+          text run at (1,249) width 181: "necessary\x{2014}these"
           text run at (1,280) width 200: "and other great"
           text run at (1,311) width 200: "forms of thought"
           text run at (1,342) width 180: "are all of them "
@@ -100,7 +100,7 @@
           text run at (1,156) width 200: "or of pleasures and"
           text run at (1,187) width 200: "desires into"
           text run at (1,218) width 200: "necessary and"
-          text run at (1,249) width 200: "unnecessary\x{2014}"
+          text run at (1,249) width 154: "unnecessary\x{2014}"
           text run at (1,280) width 200: "these and other"
           text run at (1,311) width 200: "great forms of"
           text run at (1,342) width 200: "thought are all of"

Modified: trunk/LayoutTests/platform/mac/fast/text/whitespace/pre-break-word-expected.txt (254427 => 254428)


--- trunk/LayoutTests/platform/mac/fast/text/whitespace/pre-break-word-expected.txt	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/platform/mac/fast/text/whitespace/pre-break-word-expected.txt	2020-01-13 12:47:32 UTC (rev 254428)
@@ -1,14 +1,8 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {DIV} at (0,0) size 154x130 [border: (2px solid #FF0000)]
-        RenderText {#text} at (2,2) size 148x126
-          text run at (2,2) width 148: "Even though this div is"
-          text run at (2,20) width 148: " white-space pre, the te"
-          text run at (2,38) width 145: "xt inside should still w"
-          text run at (2,56) width 148: "rap to multiple lines be"
-          text run at (2,74) width 143: "cause of the word-wra"
-          text run at (2,92) width 144: "p:break-word CSS pro"
-          text run at (2,110) width 36: "perty."
+layer at (0,0) size 920x585
+  RenderView at (0,0) size 800x585
+layer at (0,0) size 800x585
+  RenderBlock {HTML} at (0,0) size 800x585
+    RenderBody {BODY} at (8,8) size 784x569
+      RenderBlock {DIV} at (0,0) size 154x22 [border: (2px solid #FF0000)]
+        RenderText {#text} at (2,2) size 911x18
+          text run at (2,2) width 911: "Even though this div is white-space pre, the text inside should still wrap to multiple lines because of the word-wrap:break-word CSS property."

Modified: trunk/LayoutTests/platform/mac/fast/text/word-break-expected.txt (254427 => 254428)


--- trunk/LayoutTests/platform/mac/fast/text/word-break-expected.txt	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/platform/mac/fast/text/word-break-expected.txt	2020-01-13 12:47:32 UTC (rev 254428)
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x1016
+layer at (0,0) size 785x956
   RenderView at (0,0) size 785x600
-layer at (0,0) size 785x1016
-  RenderBlock {HTML} at (0,0) size 785x1016
-    RenderBody {BODY} at (8,8) size 769x1000
+layer at (0,0) size 785x956
+  RenderBlock {HTML} at (0,0) size 785x956
+    RenderBody {BODY} at (8,8) size 769x940
       RenderBlock (anonymous) at (0,0) size 769x18
         RenderText {#text} at (0,0) size 700x18
           text run at (0,0) width 700: "This example tests that word-break properly shrinks a cell to one character per line when it is set to break-all."
@@ -51,15 +51,11 @@
                 text run at (6,7) width 164: "This cell should grow"
       RenderBlock (anonymous) at (0,385) size 769x18
         RenderBR {BR} at (0,0) size 0x18
-      RenderBlock {PRE} at (0,416) size 110x85 [border: (5px solid #000000)]
-        RenderText {#text} at (5,5) size 94x75
-          text run at (5,5) width 94: "Thislongword"
-          text run at (5,20) width 94: "shouldnotget"
-          text run at (5,35) width 94: "brokenbutsho"
-          text run at (5,50) width 94: "uldstickouto"
-          text run at (5,65) width 63: "fthepre."
-          text run at (67,65) width 1: " "
-      RenderBlock (anonymous) at (0,514) size 769x72
+      RenderBlock {PRE} at (0,416) size 110x25 [border: (5px solid #000000)]
+        RenderText {#text} at (5,5) size 437x15
+          text run at (5,5) width 437: "Thislongwordshouldnotgetbrokenbutshouldstickoutofthepre."
+          text run at (441,5) width 1: " "
+      RenderBlock (anonymous) at (0,454) size 769x72
         RenderBR {BR} at (0,0) size 0x18
         RenderText {#text} at (0,18) size 750x54
           text run at (0,18) width 640: "This test makes sure floating and positioned elements do the right thing with word-break: break-all. "
@@ -67,7 +63,7 @@
           text run at (0,36) width 345: "width should be less than the containing block width. "
           text run at (344,36) width 406: "The breaking should be \"dumb\" and just occur when the end of"
           text run at (0,54) width 88: "the line is hit."
-      RenderBlock {DIV} at (0,586) size 304x49 [border: (2px solid #000000)]
+      RenderBlock {DIV} at (0,526) size 304x49 [border: (2px solid #000000)]
         RenderBlock (floating) {DIV} at (2,2) size 300x45
           RenderText {#text} at (0,0) size 297x45
             text run at (0,0) width 297: "Eventhoughthishasareallylongword itsho"
@@ -74,9 +70,9 @@
             text run at (0,15) width 297: "uldnotstick out oftheenclosing300pxblo"
             text run at (0,30) width 24: "ck."
         RenderBR {BR} at (302,2) size 0x15
-      RenderBlock (anonymous) at (0,635) size 769x18
+      RenderBlock (anonymous) at (0,575) size 769x18
         RenderBR {BR} at (0,0) size 0x18
-      RenderBlock (anonymous) at (0,757) size 769x72
+      RenderBlock (anonymous) at (0,697) size 769x72
         RenderBR {BR} at (0,0) size 0x18
         RenderText {#text} at (0,18) size 748x54
           text run at (0,18) width 657: "This test makes sure floating and positioned elements do the right thing with word-break: break-word. "
@@ -84,7 +80,7 @@
           text run at (0,36) width 345: "width should be less than the containing block width. "
           text run at (344,36) width 402: "The breaking should be \"smart\" and be like word-wrap: break-"
           text run at (0,54) width 580: "word, with words preferring to wrap first before allowing break opportunities within them."
-      RenderBlock {DIV} at (0,829) size 304x49 [border: (2px solid #000000)]
+      RenderBlock {DIV} at (0,769) size 304x49 [border: (2px solid #000000)]
         RenderBlock (floating) {DIV} at (2,2) size 300x45
           RenderText {#text} at (0,0) size 250x45
             text run at (0,0) width 250: "Eventhoughthishasareallylongword"
@@ -91,19 +87,19 @@
             text run at (0,15) width 157: "itshouldnotstick out"
             text run at (0,30) width 196: "oftheenclosing300pxblock."
         RenderBR {BR} at (302,2) size 0x15
-      RenderBlock (anonymous) at (0,878) size 769x18
+      RenderBlock (anonymous) at (0,818) size 769x18
         RenderBR {BR} at (0,0) size 0x18
-layer at (8,661) size 304x104
-  RenderBlock (relative positioned) {DIV} at (0,653) size 304x104 [border: (2px solid #000000)]
-layer at (10,663) size 300x45
+layer at (8,601) size 304x104
+  RenderBlock (relative positioned) {DIV} at (0,593) size 304x104 [border: (2px solid #000000)]
+layer at (10,603) size 300x45
   RenderBlock (positioned) {DIV} at (2,2) size 300x45
     RenderText {#text} at (0,0) size 297x45
       text run at (0,0) width 297: "Eventhoughthishasareallylongword itsho"
       text run at (0,15) width 297: "uldnotstick out oftheenclosing300pxblo"
       text run at (0,30) width 24: "ck."
-layer at (8,904) size 304x104
-  RenderBlock (relative positioned) {DIV} at (0,896) size 304x104 [border: (2px solid #000000)]
-layer at (10,906) size 300x45
+layer at (8,844) size 304x104
+  RenderBlock (relative positioned) {DIV} at (0,836) size 304x104 [border: (2px solid #000000)]
+layer at (10,846) size 300x45
   RenderBlock (positioned) {DIV} at (2,2) size 300x45
     RenderText {#text} at (0,0) size 250x45
       text run at (0,0) width 250: "Eventhoughthishasareallylongword"

Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (254427 => 254428)


--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-13 12:47:32 UTC (rev 254428)
@@ -846,3 +846,9 @@
 webkit.org/b/206071 editing/spelling/grammar.html [ Skip ]
 webkit.org/b/206071 editing/spelling/markers.html [ Skip ]
 webkit.org/b/206071 editing/spelling/retro-correction-spelling-markers.html [ Failure ]
+
+# These simple line layout specific tests disable LFC in test header. This is not supported in DRT.
+webkit.org/b/206167 fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html [ Failure ]
+webkit.org/b/206167 fast/text/simple-line-layout-leading-whitespace-with-soft-hard-linebreak.html [ Failure ]
+webkit.org/b/206167 fast/text/simple-lines-float.html [ Failure ]
+webkit.org/b/206167 fast/text/whitespace/pre-wrap-long-word-simple-lines.html [ Failure ]

Modified: trunk/LayoutTests/platform/win/TestExpectations (254427 => 254428)


--- trunk/LayoutTests/platform/win/TestExpectations	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/LayoutTests/platform/win/TestExpectations	2020-01-13 12:47:32 UTC (rev 254428)
@@ -4519,3 +4519,5 @@
 webkit.org/b/205855 http/wpt/css/css-highlight-api/highlight-text.html [ ImageOnlyFailure ]
 
 webkit.org/b/205856 storage/indexeddb/IDBTransaction-page-cache.html [ Pass Timeout ]
+
+webkit.org/b/206165 fast/dom/Range/getBoundingClientRect.html [ Failure ]

Modified: trunk/Source/WebCore/ChangeLog (254427 => 254428)


--- trunk/Source/WebCore/ChangeLog	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/Source/WebCore/ChangeLog	2020-01-13 12:47:32 UTC (rev 254428)
@@ -1,5 +1,16 @@
 2020-01-13  Antti Koivisto  <[email protected]>
 
+        [LFC][Integration] Enable LFC integration
+        https://bugs.webkit.org/show_bug.cgi?id=206128
+
+        Reviewed by Zalan Bujtas.
+
+        Enable the new line layout path.
+
+        * page/RuntimeEnabledFeatures.h:
+
+2020-01-13  Antti Koivisto  <[email protected]>
+
         [LFC][Integration] imported/blink/fast/shapes/crash-caused-by-dirtying-a-shape-while-computing-it-requires-a-long-filename-to-crash.html crashes on iOS
         https://bugs.webkit.org/show_bug.cgi?id=206151
 

Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (254427 => 254428)


--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2020-01-13 12:47:32 UTC (rev 254428)
@@ -454,7 +454,7 @@
 
 #if ENABLE(LAYOUT_FORMATTING_CONTEXT)
     bool m_layoutFormattingContextEnabled { false };
-    bool m_layoutFormattingContextIntegrationEnabled { false };
+    bool m_layoutFormattingContextIntegrationEnabled { true };
 #endif
 
 #if ENABLE(CSS_PAINTING_API)

Modified: trunk/Source/WebKit/ChangeLog (254427 => 254428)


--- trunk/Source/WebKit/ChangeLog	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/Source/WebKit/ChangeLog	2020-01-13 12:47:32 UTC (rev 254428)
@@ -1,3 +1,12 @@
+2020-01-13  Antti Koivisto  <[email protected]>
+
+        [LFC][Integration] Enable LFC integration
+        https://bugs.webkit.org/show_bug.cgi?id=206128
+
+        Reviewed by Zalan Bujtas.
+
+        * Shared/WebPreferences.yaml:
+
 2020-01-13  Carlos Garcia Campos  <[email protected]>
 
         WebDriver: pressed virtual keys not correctly handled in action sequences

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (254427 => 254428)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2020-01-13 11:54:07 UTC (rev 254427)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2020-01-13 12:47:32 UTC (rev 254428)
@@ -1679,7 +1679,7 @@
 
 LayoutFormattingContextIntegrationEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: true
   humanReadableName: "Next-generation line layout integration (LFC)"
   humanReadableDescription: "Enable next-generation line layout integration (LFC)"
   category: internal
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to