Title: [254472] trunk/Source/WebKit
- Revision
- 254472
- Author
- [email protected]
- Date
- 2020-01-13 16:39:43 -0800 (Mon, 13 Jan 2020)
Log Message
_WKResourceLoadStatisticsFirstParty should be forward declared not imported in _WKResourceLoadStatisticsThirdParty
https://bugs.webkit.org/show_bug.cgi?id=206183
<rdar://problem/58535245>
Reviewed by Alex Christensen.
* UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h:
* UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h:
* UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm:
The additional import statement here was unnecessary because
this file imports _WKResourceLoadStatisticsThirdPartyInternal.h
which forward declares the _WKResourceLoadStatisticsFirstParty class.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (254471 => 254472)
--- trunk/Source/WebKit/ChangeLog 2020-01-14 00:28:39 UTC (rev 254471)
+++ trunk/Source/WebKit/ChangeLog 2020-01-14 00:39:43 UTC (rev 254472)
@@ -1,5 +1,20 @@
2020-01-13 Kate Cheney <[email protected]>
+ _WKResourceLoadStatisticsFirstParty should be forward declared not imported in _WKResourceLoadStatisticsThirdParty
+ https://bugs.webkit.org/show_bug.cgi?id=206183
+ <rdar://problem/58535245>
+
+ Reviewed by Alex Christensen.
+
+ * UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h:
+ * UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h:
+ * UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm:
+ The additional import statement here was unnecessary because
+ this file imports _WKResourceLoadStatisticsThirdPartyInternal.h
+ which forward declares the _WKResourceLoadStatisticsFirstParty class.
+
+2020-01-13 Kate Cheney <[email protected]>
+
Unreviewed followup fix to: https://bugs.webkit.org/show_bug.cgi?id=205288.
This flag should be off-by-default.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h (254471 => 254472)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h 2020-01-14 00:28:39 UTC (rev 254471)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h 2020-01-14 00:39:43 UTC (rev 254472)
@@ -23,6 +23,8 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
+#import <WebKit/WKFoundation.h>
+
NS_ASSUME_NONNULL_BEGIN
WK_CLASS_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA))
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h (254471 => 254472)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h 2020-01-14 00:28:39 UTC (rev 254471)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h 2020-01-14 00:39:43 UTC (rev 254472)
@@ -23,10 +23,12 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#import "_WKResourceLoadStatisticsFirstParty.h"
+#import <WebKit/WKFoundation.h>
NS_ASSUME_NONNULL_BEGIN
+@class _WKResourceLoadStatisticsFirstParty;
+
WK_CLASS_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA))
@interface _WKResourceLoadStatisticsThirdParty : NSObject
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm (254471 => 254472)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm 2020-01-14 00:28:39 UTC (rev 254471)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.mm 2020-01-14 00:39:43 UTC (rev 254472)
@@ -27,7 +27,6 @@
#import "_WKResourceLoadStatisticsThirdPartyInternal.h"
#import "APIArray.h"
-#import "_WKResourceLoadStatisticsFirstParty.h"
@implementation _WKResourceLoadStatisticsThirdParty
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
