Title: [254473] trunk/Tools
- Revision
- 254473
- Author
- [email protected]
- Date
- 2020-01-13 17:08:49 -0800 (Mon, 13 Jan 2020)
Log Message
WTR::TestController::decidePolicyForPluginLoad() should output bundle identifier on release assert
<https://webkit.org/b/206105>
Reviewed by Brent Fulgham.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::decidePolicyForPluginLoad): Change
RELEASE_ASSERT_NOT_REACHED() to
RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE() with bundle
identifier.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (254472 => 254473)
--- trunk/Tools/ChangeLog 2020-01-14 00:39:43 UTC (rev 254472)
+++ trunk/Tools/ChangeLog 2020-01-14 01:08:49 UTC (rev 254473)
@@ -1,3 +1,16 @@
+2020-01-13 David Kilzer <[email protected]>
+
+ WTR::TestController::decidePolicyForPluginLoad() should output bundle identifier on release assert
+ <https://webkit.org/b/206105>
+
+ Reviewed by Brent Fulgham.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::decidePolicyForPluginLoad): Change
+ RELEASE_ASSERT_NOT_REACHED() to
+ RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE() with bundle
+ identifier.
+
2020-01-13 Aakash Jain <[email protected]>
[EWS] Add unit tests for factories
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (254472 => 254473)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-01-14 00:39:43 UTC (rev 254472)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-01-14 01:08:49 UTC (rev 254473)
@@ -2308,7 +2308,8 @@
if (WKStringIsEqualToUTF8CString(bundleIdentifier, "com.apple.testnetscapeplugin"))
return currentPluginLoadPolicy;
- RELEASE_ASSERT_NOT_REACHED(); // Please don't use any other plug-ins in tests, as they will not be installed on all machines.
+ // Please don't use any other plug-ins in tests, as they will not be installed on all machines.
+ RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE("Unexpected plugin bundle identifier: %s", toSTD(bundleIdentifier).c_str());
#else
return currentPluginLoadPolicy;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
