Title: [254847] trunk
Revision
254847
Author
[email protected]
Date
2020-01-21 03:15:05 -0800 (Tue, 21 Jan 2020)

Log Message

[GTK][WPE] Enable WebAudio by default
https://bugs.webkit.org/show_bug.cgi?id=205334

Reviewed by Adrian Perez de Castro.

Source/WebKit:

* UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_class_init):

Tools:

Update the unit test.

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (254846 => 254847)


--- trunk/Source/WebKit/ChangeLog	2020-01-21 09:41:03 UTC (rev 254846)
+++ trunk/Source/WebKit/ChangeLog	2020-01-21 11:15:05 UTC (rev 254847)
@@ -1,3 +1,13 @@
+2020-01-21  Carlos Garcia Campos  <[email protected]>
+
+        [GTK][WPE] Enable WebAudio by default
+        https://bugs.webkit.org/show_bug.cgi?id=205334
+
+        Reviewed by Adrian Perez de Castro.
+
+        * UIProcess/API/glib/WebKitSettings.cpp:
+        (webkit_settings_class_init):
+
 2020-01-21  youenn fablet  <[email protected]>
 
         Log the destination of a load when hitting network process

Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (254846 => 254847)


--- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp	2020-01-21 09:41:03 UTC (rev 254846)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp	2020-01-21 11:15:05 UTC (rev 254847)
@@ -1045,19 +1045,19 @@
      *
      *
      * Enable or disable support for WebAudio on pages. WebAudio is an
-     * experimental proposal for allowing web pages to generate Audio
-     * WAVE data from _javascript_. The standard is currently a
-     * work-in-progress by the W3C Audio Working Group.
+     * API for processing and synthesizing audio in web applications
      *
-     * See also https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html
+     * See also https://webaudio.github.io/web-audio-api
      */
-    g_object_class_install_property(gObjectClass,
-                                    PROP_ENABLE_WEBAUDIO,
-                                    g_param_spec_boolean("enable-webaudio",
-                                                         _("Enable WebAudio"),
-                                                         _("Whether WebAudio content should be handled"),
-                                                         FALSE,
-                                                         readWriteConstructParamFlags));
+    g_object_class_install_property(
+        gObjectClass,
+        PROP_ENABLE_WEBAUDIO,
+        g_param_spec_boolean(
+            "enable-webaudio",
+            _("Enable WebAudio"),
+            _("Whether WebAudio content should be handled"),
+            TRUE,
+            readWriteConstructParamFlags));
 
     /**
     * WebKitSettings:enable-webgl:

Modified: trunk/Tools/ChangeLog (254846 => 254847)


--- trunk/Tools/ChangeLog	2020-01-21 09:41:03 UTC (rev 254846)
+++ trunk/Tools/ChangeLog	2020-01-21 11:15:05 UTC (rev 254847)
@@ -1,3 +1,15 @@
+2020-01-21  Carlos Garcia Campos  <[email protected]>
+
+        [GTK][WPE] Enable WebAudio by default
+        https://bugs.webkit.org/show_bug.cgi?id=205334
+
+        Reviewed by Adrian Perez de Castro.
+
+        Update the unit test.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
+        (testWebKitSettings):
+
 2020-01-20  Sam Weinig  <[email protected]>
 
         Platform.h is out of control Part 8: Macros are used inconsistently

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp (254846 => 254847)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp	2020-01-21 09:41:03 UTC (rev 254846)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp	2020-01-21 11:15:05 UTC (rev 254847)
@@ -231,10 +231,10 @@
     webkit_settings_set_print_backgrounds(settings, FALSE);
     g_assert_false(webkit_settings_get_print_backgrounds(settings));
 
-    // WebAudio is disabled by default.
+    // WebAudio is enabled by default.
+    g_assert_true(webkit_settings_get_enable_webaudio(settings));
+    webkit_settings_set_enable_webaudio(settings, FALSE);
     g_assert_false(webkit_settings_get_enable_webaudio(settings));
-    webkit_settings_set_enable_webaudio(settings, TRUE);
-    g_assert_true(webkit_settings_get_enable_webaudio(settings));
 
     // WebGL is disabled by default.
     g_assert_false(webkit_settings_get_enable_webgl(settings));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to