Title: [254848] trunk
Revision
254848
Author
[email protected]
Date
2020-01-21 03:28:10 -0800 (Tue, 21 Jan 2020)

Log Message

[GTK][WPE] Enable WebGL by default
https://bugs.webkit.org/show_bug.cgi?id=205335

Reviewed by Adrian Perez de Castro.

Source/WebKit:

* UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_class_init):

Tools:

Update the unit test.

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (254847 => 254848)


--- trunk/Source/WebKit/ChangeLog	2020-01-21 11:15:05 UTC (rev 254847)
+++ trunk/Source/WebKit/ChangeLog	2020-01-21 11:28:10 UTC (rev 254848)
@@ -1,5 +1,15 @@
 2020-01-21  Carlos Garcia Campos  <[email protected]>
 
+        [GTK][WPE] Enable WebGL by default
+        https://bugs.webkit.org/show_bug.cgi?id=205335
+
+        Reviewed by Adrian Perez de Castro.
+
+        * UIProcess/API/glib/WebKitSettings.cpp:
+        (webkit_settings_class_init):
+
+2020-01-21  Carlos Garcia Campos  <[email protected]>
+
         [GTK][WPE] Enable WebAudio by default
         https://bugs.webkit.org/show_bug.cgi?id=205334
 

Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (254847 => 254848)


--- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp	2020-01-21 11:15:05 UTC (rev 254847)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp	2020-01-21 11:28:10 UTC (rev 254848)
@@ -1062,17 +1062,18 @@
     /**
     * WebKitSettings:enable-webgl:
     *
-    * Enable or disable support for WebGL on pages. WebGL is an experimental
-    * proposal for allowing web pages to use OpenGL ES-like calls directly. The
-    * standard is currently a work-in-progress by the Khronos Group.
+    * Enable or disable support for WebGL on pages. WebGL enables web
+    * content to use an API based on OpenGL ES 2.0.
     */
-    g_object_class_install_property(gObjectClass,
-                                    PROP_ENABLE_WEBGL,
-                                    g_param_spec_boolean("enable-webgl",
-                                                         _("Enable WebGL"),
-                                                         _("Whether WebGL content should be rendered"),
-                                                         FALSE,
-                                                         readWriteConstructParamFlags));
+    g_object_class_install_property(
+        gObjectClass,
+        PROP_ENABLE_WEBGL,
+        g_param_spec_boolean(
+            "enable-webgl",
+            _("Enable WebGL"),
+            _("Whether WebGL content should be rendered"),
+            TRUE,
+            readWriteConstructParamFlags));
 
     /**
      * WebKitSettings:allow-modal-dialogs:

Modified: trunk/Tools/ChangeLog (254847 => 254848)


--- trunk/Tools/ChangeLog	2020-01-21 11:15:05 UTC (rev 254847)
+++ trunk/Tools/ChangeLog	2020-01-21 11:28:10 UTC (rev 254848)
@@ -1,5 +1,17 @@
 2020-01-21  Carlos Garcia Campos  <[email protected]>
 
+        [GTK][WPE] Enable WebGL by default
+        https://bugs.webkit.org/show_bug.cgi?id=205335
+
+        Reviewed by Adrian Perez de Castro.
+
+        Update the unit test.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
+        (testWebKitSettings):
+
+2020-01-21  Carlos Garcia Campos  <[email protected]>
+
         [GTK][WPE] Enable WebAudio by default
         https://bugs.webkit.org/show_bug.cgi?id=205334
 

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp (254847 => 254848)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp	2020-01-21 11:15:05 UTC (rev 254847)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp	2020-01-21 11:28:10 UTC (rev 254848)
@@ -236,10 +236,10 @@
     webkit_settings_set_enable_webaudio(settings, FALSE);
     g_assert_false(webkit_settings_get_enable_webaudio(settings));
 
-    // WebGL is disabled by default.
+    // WebGL is enabled by default.
+    g_assert_true(webkit_settings_get_enable_webgl(settings));
+    webkit_settings_set_enable_webgl(settings, FALSE);
     g_assert_false(webkit_settings_get_enable_webgl(settings));
-    webkit_settings_set_enable_webgl(settings, TRUE);
-    g_assert_true(webkit_settings_get_enable_webgl(settings));
 
     // Allow Modal Dialogs is disabled by default.
     g_assert_false(webkit_settings_get_allow_modal_dialogs(settings));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to