Title: [255307] branches/safari-610.1.1-branch/LayoutTests/imported/w3c
Revision
255307
Author
[email protected]
Date
2020-01-28 13:50:07 -0800 (Tue, 28 Jan 2020)

Log Message

Cherry-pick r255166. rdar://problem/58841339

    [iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html is flaky failing
    https://bugs.webkit.org/show_bug.cgi?id=206683
    <rdar://problem/58841339>

    Reviewed by Eric Carlson.

    * web-platform-tests/webrtc/RTCDTMFSender-helper.js:
    Move from async_test to promise_test to improve repeatability of the tests.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610.1.1-branch/LayoutTests/imported/w3c/ChangeLog (255306 => 255307)


--- branches/safari-610.1.1-branch/LayoutTests/imported/w3c/ChangeLog	2020-01-28 21:50:05 UTC (rev 255306)
+++ branches/safari-610.1.1-branch/LayoutTests/imported/w3c/ChangeLog	2020-01-28 21:50:07 UTC (rev 255307)
@@ -1,3 +1,30 @@
+2020-01-28  Russell Epstein  <[email protected]>
+
+        Cherry-pick r255166. rdar://problem/58841339
+
+    [iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html is flaky failing
+    https://bugs.webkit.org/show_bug.cgi?id=206683
+    <rdar://problem/58841339>
+    
+    Reviewed by Eric Carlson.
+    
+    * web-platform-tests/webrtc/RTCDTMFSender-helper.js:
+    Move from async_test to promise_test to improve repeatability of the tests.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-01-27  youenn fablet  <[email protected]>
+
+            [iOS Release and Mac Release] imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-ontonechange.https.html is flaky failing
+            https://bugs.webkit.org/show_bug.cgi?id=206683
+            <rdar://problem/58841339>
+
+            Reviewed by Eric Carlson.
+
+            * web-platform-tests/webrtc/RTCDTMFSender-helper.js:
+            Move from async_test to promise_test to improve repeatability of the tests.
+
 2020-01-10  Yusuke Suzuki  <[email protected]>
 
         [WebCore] Fix crash in module loader due to change in fragment reservation

Modified: branches/safari-610.1.1-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-helper.js (255306 => 255307)


--- branches/safari-610.1.1-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-helper.js	2020-01-28 21:50:05 UTC (rev 255306)
+++ branches/safari-610.1.1-branch/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDTMFSender-helper.js	2020-01-28 21:50:07 UTC (rev 255307)
@@ -78,7 +78,12 @@
       Test description.
  */
 function test_tone_change_events(testFunc, toneChanges, desc) {
-  async_test(t => {
+  promise_test(t => {
+    let done, fail;
+    const promise = new Promise((resolve, reject) => {
+        done = resolve;
+        fail = reject;
+    });
     const pc = new RTCPeerConnection();
 
     createDtmfSender(pc)
@@ -124,7 +129,7 @@
           // in which case the test should fail.
           t.step_timeout(
             t.step_func(() => {
-              t.done();
+              done();
               pc.close();
               pc.otherPc.close();
             }), expectedDuration + 100);
@@ -137,6 +142,7 @@
     .catch(t.step_func(err => {
       assert_unreached(`Unexpected promise rejection: ${err}`);
     }));
+    return promise;
   }, desc);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to