Title: [255306] branches/safari-610.1.1-branch/LayoutTests
- Revision
- 255306
- Author
- [email protected]
- Date
- 2020-01-28 13:50:05 -0800 (Tue, 28 Jan 2020)
Log Message
Cherry-pick r255153. rdar://problem/58839955
REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206675
<rdar://problem/58839955>
Reviewed by Said Abou-Hallawa.
Rewrite test to stop relying on ordering between requestAnimationFrame() and setTimeout().
* fast/animation/request-animation-frame-expected.txt:
* fast/animation/request-animation-frame.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610.1.1-branch/LayoutTests/ChangeLog (255305 => 255306)
--- branches/safari-610.1.1-branch/LayoutTests/ChangeLog 2020-01-28 21:50:02 UTC (rev 255305)
+++ branches/safari-610.1.1-branch/LayoutTests/ChangeLog 2020-01-28 21:50:05 UTC (rev 255306)
@@ -1,5 +1,36 @@
2020-01-28 Russell Epstein <[email protected]>
+ Cherry-pick r255153. rdar://problem/58839955
+
+ REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing
+ https://bugs.webkit.org/show_bug.cgi?id=206675
+ <rdar://problem/58839955>
+
+ Reviewed by Said Abou-Hallawa.
+
+ Rewrite test to stop relying on ordering between requestAnimationFrame() and setTimeout().
+
+ * fast/animation/request-animation-frame-expected.txt:
+ * fast/animation/request-animation-frame.html:
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-01-27 Chris Dumez <[email protected]>
+
+ REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing
+ https://bugs.webkit.org/show_bug.cgi?id=206675
+ <rdar://problem/58839955>
+
+ Reviewed by Said Abou-Hallawa.
+
+ Rewrite test to stop relying on ordering between requestAnimationFrame() and setTimeout().
+
+ * fast/animation/request-animation-frame-expected.txt:
+ * fast/animation/request-animation-frame.html:
+
+2020-01-28 Russell Epstein <[email protected]>
+
Cherry-pick r255130. rdar://problem/58816827
media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out
Modified: branches/safari-610.1.1-branch/LayoutTests/fast/animation/request-animation-frame-expected.txt (255305 => 255306)
--- branches/safari-610.1.1-branch/LayoutTests/fast/animation/request-animation-frame-expected.txt 2020-01-28 21:50:02 UTC (rev 255305)
+++ branches/safari-610.1.1-branch/LayoutTests/fast/animation/request-animation-frame-expected.txt 2020-01-28 21:50:05 UTC (rev 255306)
@@ -3,7 +3,11 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS callbackInvoked is true
+PASS requestAnimationFrame callback was called
+PASS requestAnimationFrame callback was called
+PASS requestAnimationFrame callback was called
+PASS requestAnimationFrame callback was called
+PASS requestAnimationFrame callback was called
PASS successfullyParsed is true
TEST COMPLETE
Modified: branches/safari-610.1.1-branch/LayoutTests/fast/animation/request-animation-frame.html (255305 => 255306)
--- branches/safari-610.1.1-branch/LayoutTests/fast/animation/request-animation-frame.html 2020-01-28 21:50:02 UTC (rev 255305)
+++ branches/safari-610.1.1-branch/LayoutTests/fast/animation/request-animation-frame.html 2020-01-28 21:50:05 UTC (rev 255306)
@@ -1,35 +1,28 @@
<!DOCTYPE html>
<html>
<head>
-<script src=""
+<script src=""
</head>
<body>
-<span id="e"></span>
-<span id="f"></span>
<script>
description("Tests basic use of requestAnimationFrame");
+jsTestIsAsync = true;
-var e = document.getElementById("e");
-var callbackInvoked = false;
-window.requestAnimationFrame(function() {
- callbackInvoked = true;
-}, e);
-
if (window.testRunner)
testRunner.displayAndTrackRepaints();
-setTimeout(function() {
- shouldBeTrue("callbackInvoked");
-}, 100);
+let callbackCount = 0;
+let rAFCallback = () => {
+ testPassed("requestAnimationFrame callback was called");
+ callbackCount++;
+ if (callbackCount < 5)
+ requestAnimationFrame(rAFCallback);
+ else
+ finishJSTest();
+}
-if (window.testRunner)
- testRunner.waitUntilDone();
+requestAnimationFrame(rAFCallback);
-setTimeout(function() {
- isSuccessfullyParsed();
- if (window.testRunner)
- testRunner.notifyDone();
-}, 200);
</script>
</body>
</html>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
