Title: [103757] trunk/Source/WebCore
Revision
103757
Author
[email protected]
Date
2011-12-27 21:29:03 -0800 (Tue, 27 Dec 2011)

Log Message

Crash in the WebKit accessibility code while attempting to retrieve the title UI element.
https://bugs.webkit.org/show_bug.cgi?id=75279

Patch by Anantanarayanan G Iyengar <[email protected]> on 2011-12-27
Reviewed by Ryosuke Niwa.

Fix a crash in the the WebKit accessibility code which occurs while retrieving
the title UI clement. The fix is to NULL check the RenderObject::node return value.

No test added as there is no reduction.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::titleUIElement):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (103756 => 103757)


--- trunk/Source/WebCore/ChangeLog	2011-12-28 05:13:56 UTC (rev 103756)
+++ trunk/Source/WebCore/ChangeLog	2011-12-28 05:29:03 UTC (rev 103757)
@@ -1,3 +1,18 @@
+2011-12-27  Anantanarayanan G Iyengar  <[email protected]>
+
+        Crash in the WebKit accessibility code while attempting to retrieve the title UI element.
+        https://bugs.webkit.org/show_bug.cgi?id=75279
+
+        Reviewed by Ryosuke Niwa.
+
+        Fix a crash in the the WebKit accessibility code which occurs while retrieving
+        the title UI clement. The fix is to NULL check the RenderObject::node return value.
+
+        No test added as there is no reduction.
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::titleUIElement):
+
 2011-12-27  Dominic Cooney  <[email protected]>
 
         Remove initWebKitAnimationEvent method

Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (103756 => 103757)


--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2011-12-28 05:13:56 UTC (rev 103756)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2011-12-28 05:29:03 UTC (rev 103757)
@@ -1706,6 +1706,8 @@
         return axObjectCache()->getOrCreate(toRenderFieldset(m_renderer)->findLegend());
     
     Node* element = m_renderer->node();
+    if (!element)
+        return 0;
     HTMLLabelElement* label = labelForElement(static_cast<Element*>(element));
     if (label && label->renderer())
         return axObjectCache()->getOrCreate(label->renderer());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to