Title: [256706] trunk/Source/WebCore
- Revision
- 256706
- Author
- [email protected]
- Date
- 2020-02-15 14:20:32 -0800 (Sat, 15 Feb 2020)
Log Message
[GStreamer] Build failure with Clang/libc++ due to missing WallTime→float for std::isnan()
https://bugs.webkit.org/show_bug.cgi?id=207757
Unreviewed build fix.
No new tests needed.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::dataReceived): Add std:: namespace to overloaded
std::isnan() function call to ensure that the overloaded version for WTF::WallTime
is used.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (256705 => 256706)
--- trunk/Source/WebCore/ChangeLog 2020-02-15 22:02:38 UTC (rev 256705)
+++ trunk/Source/WebCore/ChangeLog 2020-02-15 22:20:32 UTC (rev 256706)
@@ -1,5 +1,19 @@
2020-02-15 Adrian Perez de Castro <[email protected]>
+ [GStreamer] Build failure with Clang/libc++ due to missing WallTime→float for std::isnan()
+ https://bugs.webkit.org/show_bug.cgi?id=207757
+
+ Unreviewed build fix.
+
+ No new tests needed.
+
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+ (CachedResourceStreamingClient::dataReceived): Add std:: namespace to overloaded
+ std::isnan() function call to ensure that the overloaded version for WTF::WallTime
+ is used.
+
+2020-02-15 Adrian Perez de Castro <[email protected]>
+
Unreviewed build fix for non-unified builds.
No new tests needed.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (256705 => 256706)
--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2020-02-15 22:02:38 UTC (rev 256705)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2020-02-15 22:20:32 UTC (rev 256706)
@@ -1152,7 +1152,7 @@
// Rough bandwidth calculation. We ignore here the first data package because we would have to reset the counters when we issue the request and
// that first package delivery would include the time of sending out the request and getting the data back. Since we can't distinguish the
// sending time from the receiving time, it is better to ignore it.
- if (!isnan(priv->downloadStartTime)) {
+ if (!std::isnan(priv->downloadStartTime)) {
priv->totalDownloadedBytes += length;
double timeSinceStart = (WallTime::now() - priv->downloadStartTime).seconds();
GST_TRACE_OBJECT(src, "downloaded %" G_GUINT64_FORMAT " bytes in %f seconds =~ %1.0f bytes/second", priv->totalDownloadedBytes, timeSinceStart
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
