Title: [256707] trunk/Source/WebCore
- Revision
- 256707
- Author
- [email protected]
- Date
- 2020-02-16 07:09:50 -0800 (Sun, 16 Feb 2020)
Log Message
[LFC][BFC] Fix horizontal/verticalConstraintsForAncestor in BlockFormattingContext::precomputeVerticalPositionForAncestors
https://bugs.webkit.org/show_bug.cgi?id=207817
<rdar://problem/59489735>
Reviewed by Antti Koivisto.
horizontalConstraintsForAncestor/verticalConstraintsForAncestor should return the constraints (containing block's content box width etc)
of the ancestor.
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForAncestors):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (256706 => 256707)
--- trunk/Source/WebCore/ChangeLog 2020-02-15 22:20:32 UTC (rev 256706)
+++ trunk/Source/WebCore/ChangeLog 2020-02-16 15:09:50 UTC (rev 256707)
@@ -1,3 +1,17 @@
+2020-02-16 Zalan Bujtas <[email protected]>
+
+ [LFC][BFC] Fix horizontal/verticalConstraintsForAncestor in BlockFormattingContext::precomputeVerticalPositionForAncestors
+ https://bugs.webkit.org/show_bug.cgi?id=207817
+ <rdar://problem/59489735>
+
+ Reviewed by Antti Koivisto.
+
+ horizontalConstraintsForAncestor/verticalConstraintsForAncestor should return the constraints (containing block's content box width etc)
+ of the ancestor.
+
+ * layout/blockformatting/BlockFormattingContext.cpp:
+ (WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForAncestors):
+
2020-02-15 Adrian Perez de Castro <[email protected]>
[GStreamer] Build failure with Clang/libc++ due to missing WallTime→float for std::isnan()
Modified: trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp (256706 => 256707)
--- trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp 2020-02-15 22:20:32 UTC (rev 256706)
+++ trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp 2020-02-16 15:09:50 UTC (rev 256707)
@@ -284,11 +284,11 @@
if (hasPrecomputedMarginBefore(*ancestor))
return;
auto horizontalConstraintsForAncestor = [&] {
- auto* containingBlock = layoutBox.containingBlock();
+ auto* containingBlock = ancestor->containingBlock();
return containingBlock == &root() ? horizontalConstraints.root : Geometry::horizontalConstraintsForInFlow(geometryForBox(*containingBlock));
};
auto verticalConstraintsForAncestor = [&] {
- auto* containingBlock = layoutBox.containingBlock();
+ auto* containingBlock = ancestor->containingBlock();
return containingBlock == &root() ? verticalConstraints.root : Geometry::verticalConstraintsForInFlow(geometryForBox(*containingBlock));
};
precomputeVerticalPosition(*ancestor, horizontalConstraintsForAncestor(), verticalConstraintsForAncestor());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
