Title: [257147] trunk/Tools
- Revision
- 257147
- Author
- [email protected]
- Date
- 2020-02-21 10:24:41 -0800 (Fri, 21 Feb 2020)
Log Message
[ews] Add build step to set cq- flag on bugzilla patch
https://bugs.webkit.org/show_bug.cgi?id=208021
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(BugzillaMixin.set_cq_minus_flag_on_patch):
(SetCommitQueueMinusFlagOnPatch):
(SetCommitQueueMinusFlagOnPatch.start):
(SetCommitQueueMinusFlagOnPatch.getResultSummary):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (257146 => 257147)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-02-21 18:23:34 UTC (rev 257146)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-02-21 18:24:41 UTC (rev 257147)
@@ -447,6 +447,19 @@
return FAILURE
return SUCCESS
+ def set_cq_minus_flag_on_patch(self, patch_id):
+ patch_url = '{}rest/bug/attachment/{}'.format(BUG_SERVER_URL, patch_id)
+ flags = [{'name': 'commit-queue', 'status': '-'}]
+ try:
+ response = requests.put(patch_url, json={'flags': flags, 'Bugzilla_api_key': self.get_bugzilla_api_key()})
+ if response.status_code not in [200, 201]:
+ self._addToLog('stdio', 'Unable to set cq- flag on patch {}. Unexpected response code from bugzilla: {}'.format(patch_id, response.status_code))
+ return FAILURE
+ except Exception as e:
+ self._addToLog('stdio', 'Error in setting cq- flag on patch {}'.format(patch_id))
+ return FAILURE
+ return SUCCESS
+
def close_bug(self, bug_id):
bug_url = '{}rest/bug/{}'.format(BUG_SERVER_URL, bug_id)
try:
@@ -570,6 +583,21 @@
return None
+class SetCommitQueueMinusFlagOnPatch(buildstep.BuildStep, BugzillaMixin):
+ name = 'set-cq-minus-flag-on-patch'
+
+ def start(self):
+ patch_id = self.getProperty('patch_id', '')
+ rc = self.set_cq_minus_flag_on_patch(patch_id)
+ self.finished(rc)
+ return None
+
+ def getResultSummary(self):
+ if self.results == SUCCESS:
+ return {u'step': u'Set cq- flag on patch'}
+ return {u'step': u'Failed to set cq- flag on patch'}
+
+
class RemoveFlagsOnPatch(buildstep.BuildStep, BugzillaMixin):
name = 'remove-flags-from-patch'
flunkOnFailure = False
Modified: trunk/Tools/ChangeLog (257146 => 257147)
--- trunk/Tools/ChangeLog 2020-02-21 18:23:34 UTC (rev 257146)
+++ trunk/Tools/ChangeLog 2020-02-21 18:24:41 UTC (rev 257147)
@@ -1,3 +1,16 @@
+2020-02-21 Aakash Jain <[email protected]>
+
+ [ews] Add build step to set cq- flag on bugzilla patch
+ https://bugs.webkit.org/show_bug.cgi?id=208021
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (BugzillaMixin.set_cq_minus_flag_on_patch):
+ (SetCommitQueueMinusFlagOnPatch):
+ (SetCommitQueueMinusFlagOnPatch.start):
+ (SetCommitQueueMinusFlagOnPatch.getResultSummary):
+
2020-02-20 Matt Lewis <[email protected]>
Stub repositories fail to upload some results due to missing head svn revision
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
