Title: [257148] trunk/Source/WebKit
Revision
257148
Author
[email protected]
Date
2020-02-21 10:39:56 -0800 (Fri, 21 Feb 2020)

Log Message

Remove WebPageProxy::machSendRightCallback as it is dead code
https://bugs.webkit.org/show_bug.cgi?id=208057
<rdar://problem/59658805>

Reviewed by Geoffrey Garen.

* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (257147 => 257148)


--- trunk/Source/WebKit/ChangeLog	2020-02-21 18:24:41 UTC (rev 257147)
+++ trunk/Source/WebKit/ChangeLog	2020-02-21 18:39:56 UTC (rev 257148)
@@ -1,5 +1,17 @@
 2020-02-21  Chris Dumez  <[email protected]>
 
+        Remove WebPageProxy::machSendRightCallback as it is dead code
+        https://bugs.webkit.org/show_bug.cgi?id=208057
+        <rdar://problem/59658805>
+
+        Reviewed by Geoffrey Garen.
+
+        * UIProcess/WebPageProxy.cpp:
+        * UIProcess/WebPageProxy.h:
+        * UIProcess/WebPageProxy.messages.in:
+
+2020-02-21  Chris Dumez  <[email protected]>
+
         Remove WebPasteBoardProxy::PasteboardCopy as it is dead code
         https://bugs.webkit.org/show_bug.cgi?id=208058
         <rdar://problem/59658727>

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (257147 => 257148)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-21 18:24:41 UTC (rev 257147)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-21 18:39:56 UTC (rev 257148)
@@ -7021,17 +7021,6 @@
 }
 #endif
 
-#if PLATFORM(COCOA)
-void WebPageProxy::machSendRightCallback(const MachSendRight& sendRight, CallbackID callbackID)
-{
-    auto callback = m_callbacks.take<MachSendRightCallback>(callbackID);
-    if (!callback)
-        return;
-
-    callback->performCallbackWithReturnValue(sendRight);
-}
-#endif
-
 inline API::DiagnosticLoggingClient* WebPageProxy::effectiveDiagnosticLoggingClient(ShouldSample shouldSample)
 {
     // Diagnostic logging is disabled for ephemeral sessions for privacy reasons.

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (257147 => 257148)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.h	2020-02-21 18:24:41 UTC (rev 257147)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h	2020-02-21 18:39:56 UTC (rev 257148)
@@ -403,7 +403,6 @@
 
 #if PLATFORM(COCOA)
 using DrawToPDFCallback = GenericCallback<const IPC::DataReference&>;
-typedef GenericCallback<const WTF::MachSendRight&> MachSendRightCallback;
 typedef GenericCallback<bool, bool, String, double, double, uint64_t> NowPlayingInfoCallback;
 #endif
 
@@ -2019,9 +2018,6 @@
 #if ENABLE(APPLICATION_MANIFEST)
     void applicationManifestCallback(const Optional<WebCore::ApplicationManifest>&, CallbackID);
 #endif
-#if PLATFORM(COCOA)
-    void machSendRightCallback(const WTF::MachSendRight&, CallbackID);
-#endif
     void rectForCharacterRangeCallback(const WebCore::IntRect&, const EditingRange&, CallbackID);
 #if PLATFORM(MAC)
     void attributedStringForCharacterRangeCallback(const AttributedString&, const EditingRange&, CallbackID);

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in (257147 => 257148)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in	2020-02-21 18:24:41 UTC (rev 257147)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in	2020-02-21 18:39:56 UTC (rev 257148)
@@ -204,7 +204,6 @@
 #endif
 #if PLATFORM(COCOA)
     DrawToPDFCallback(IPC::DataReference pdfData, WebKit::CallbackID callbackID)
-    MachSendRightCallback(MachSendRight sendRight, WebKit::CallbackID callbackID)
     NowPlayingInfoCallback(bool active, bool registeredAsNowPlayingApplication, String title, double duration, double elapsedTime, uint64_t uniqueIdentifier, WebKit::CallbackID callbackID)
 #endif
     FindStringCallback(bool found, WebKit::CallbackID callbackID)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to