Title: [257539] trunk/Source/WebKit
- Revision
- 257539
- Author
- [email protected]
- Date
- 2020-02-26 17:18:37 -0800 (Wed, 26 Feb 2020)
Log Message
Remove WebsiteDataStore::setSourceApplicationSecondaryIdentifier
https://bugs.webkit.org/show_bug.cgi?id=206452
Reviewed by Chris Dumez.
Its replacement on WebsiteDataStoreConfiguration was adopted in rdar://problem/58671704
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _sourceApplicationSecondaryIdentifier]):
(-[WKWebsiteDataStore _setSourceApplicationSecondaryIdentifier:]):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setSourceApplicationSecondaryIdentifier): Deleted.
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::sourceApplicationSecondaryIdentifier const):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (257538 => 257539)
--- trunk/Source/WebKit/ChangeLog 2020-02-27 01:15:35 UTC (rev 257538)
+++ trunk/Source/WebKit/ChangeLog 2020-02-27 01:18:37 UTC (rev 257539)
@@ -1,5 +1,22 @@
2020-02-26 Alex Christensen <[email protected]>
+ Remove WebsiteDataStore::setSourceApplicationSecondaryIdentifier
+ https://bugs.webkit.org/show_bug.cgi?id=206452
+
+ Reviewed by Chris Dumez.
+
+ Its replacement on WebsiteDataStoreConfiguration was adopted in rdar://problem/58671704
+
+ * UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
+ (-[WKWebsiteDataStore _sourceApplicationSecondaryIdentifier]):
+ (-[WKWebsiteDataStore _setSourceApplicationSecondaryIdentifier:]):
+ * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+ (WebKit::WebsiteDataStore::setSourceApplicationSecondaryIdentifier): Deleted.
+ * UIProcess/WebsiteData/WebsiteDataStore.h:
+ (WebKit::WebsiteDataStore::sourceApplicationSecondaryIdentifier const):
+
+2020-02-26 Alex Christensen <[email protected]>
+
Remove WebsiteDataStore setters for allowsCellularAccess, proxyConfiguration, and boundInterfaceIdentifier
https://bugs.webkit.org/show_bug.cgi?id=206390
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm (257538 => 257539)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm 2020-02-27 01:15:35 UTC (rev 257538)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm 2020-02-27 01:18:37 UTC (rev 257539)
@@ -354,13 +354,11 @@
- (NSString *)_sourceApplicationSecondaryIdentifier
{
- return _websiteDataStore->sourceApplicationSecondaryIdentifier();
+ return nil;
}
- (void)_setSourceApplicationSecondaryIdentifier:(NSString *)identifier
{
- if (!_websiteDataStore->setSourceApplicationSecondaryIdentifier(identifier))
- [NSException raise:NSGenericException format:@"_setSourceApplicationSecondaryIdentifier cannot be called after networking has begun"];
}
- (void)_setAllowsTLSFallback:(BOOL)allows
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (257538 => 257539)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2020-02-27 01:15:35 UTC (rev 257538)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2020-02-27 01:18:37 UTC (rev 257539)
@@ -2190,14 +2190,6 @@
{
}
-bool WebsiteDataStore::setSourceApplicationSecondaryIdentifier(String&& identifier)
-{
- if (m_networkingHasBegun)
- return false;
- m_resolvedConfiguration->setSourceApplicationSecondaryIdentifier(WTFMove(identifier));
- return true;
-}
-
bool WebsiteDataStore::setSourceApplicationBundleIdentifier(String&& identifier)
{
if (m_networkingHasBegun)
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h (257538 => 257539)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h 2020-02-27 01:15:35 UTC (rev 257538)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h 2020-02-27 01:18:37 UTC (rev 257539)
@@ -228,7 +228,6 @@
bool setSourceApplicationBundleIdentifier(String&&);
const String& sourceApplicationSecondaryIdentifier() const { return m_resolvedConfiguration->sourceApplicationSecondaryIdentifier(); }
- bool setSourceApplicationSecondaryIdentifier(String&&);
void networkingHasBegun() { m_networkingHasBegun = true; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
