Diff
Modified: trunk/Tools/ChangeLog (257539 => 257540)
--- trunk/Tools/ChangeLog 2020-02-27 01:18:37 UTC (rev 257539)
+++ trunk/Tools/ChangeLog 2020-02-27 01:38:09 UTC (rev 257540)
@@ -1,3 +1,16 @@
+2020-02-26 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r257522.
+
+ Caused 16 API test failures on the bots
+
+ Reverted changeset:
+
+ "TestWebKitAPI and WebKitTestRunner should have bundle
+ identifiers"
+ https://bugs.webkit.org/show_bug.cgi?id=208260
+ https://trac.webkit.org/changeset/257522
+
2020-02-26 Alex Christensen <[email protected]>
Add SPI to query WKFrameInfos in a WKWebView
Modified: trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig (257539 => 257540)
--- trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig 2020-02-27 01:18:37 UTC (rev 257539)
+++ trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig 2020-02-27 01:38:09 UTC (rev 257540)
@@ -24,7 +24,6 @@
#include "FeatureDefines.xcconfig"
PRODUCT_NAME = TestWebKitAPI;
-PRODUCT_BUNDLE_IDENTIFIER = com.apple.WebKit.TestWebKitAPI;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
WK_PRIVATE_FRAMEWORKS_DIR = $(WK_PRIVATE_FRAMEWORKS_DIR_$(USE_INTERNAL_SDK));
@@ -77,6 +76,3 @@
CODE_SIGN_IDENTITY_YES = $(WK_ENGINEERING_CODE_SIGN_IDENTITY);
CODE_SIGN_IDENTITY_Production = $(CODE_SIGN_IDENTITY_Production_$(USE_INTERNAL_SDK));
CODE_SIGN_IDENTITY_Production_YES = -;
-
-CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
-INFOPLIST_FILE = $(SRCROOT)/Info.plist;
Deleted: trunk/Tools/TestWebKitAPI/Info.plist (257539 => 257540)
--- trunk/Tools/TestWebKitAPI/Info.plist 2020-02-27 01:18:37 UTC (rev 257539)
+++ trunk/Tools/TestWebKitAPI/Info.plist 2020-02-27 01:38:09 UTC (rev 257540)
@@ -1,10 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
- <key>CFBundleName</key>
- <string>${PRODUCT_NAME}</string>
- <key>CFBundleIdentifier</key>
- <string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
-</dict>
-</plist>
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (257539 => 257540)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2020-02-27 01:18:37 UTC (rev 257539)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2020-02-27 01:38:09 UTC (rev 257540)
@@ -1847,7 +1847,6 @@
46EBD846237231E600223A6E /* RestoreScrollPosition.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = RestoreScrollPosition.mm; sourceTree = "<group>"; };
46FA2FED23846C9A000CCB0C /* HTTPHeaderMap.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = HTTPHeaderMap.cpp; sourceTree = "<group>"; };
46FACF7323E883EE00A9EBC6 /* beforeunload-slow.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "beforeunload-slow.html"; sourceTree = "<group>"; };
- 49AEEF682407276F00C87E4C /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
4A410F4B19AF7BD6002EBAB5 /* UserMedia.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = UserMedia.cpp; sourceTree = "<group>"; };
4A410F4D19AF7BEF002EBAB5 /* getUserMedia.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = getUserMedia.html; sourceTree = "<group>"; };
4A410F4D19AF7BEF002EBAB6 /* ondevicechange.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = ondevicechange.html; sourceTree = "<group>"; };
@@ -2802,7 +2801,6 @@
08FB7794FE84155DC02AAC07 /* TestWebKitAPI */ = {
isa = PBXGroup;
children = (
- 49AEEF682407276F00C87E4C /* Info.plist */,
5C9D922622D7DD7B008E9266 /* Derived Sources */,
5C9D921D22D7DBF7008E9266 /* Sources.txt */,
5C9D921E22D7DBF8008E9266 /* SourcesCocoa.txt */,
Modified: trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig (257539 => 257540)
--- trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig 2020-02-27 01:18:37 UTC (rev 257539)
+++ trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig 2020-02-27 01:38:09 UTC (rev 257540)
@@ -28,7 +28,6 @@
LD_RUNPATH_SEARCH_PATHS = "@loader_path";
PRODUCT_NAME = WebKitTestRunner;
-PRODUCT_BUNDLE_IDENTIFIER = com.apple.WebKit.WebKitTestRunner;
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
OTHER_LDFLAGS[sdk=macosx*] = $(inherited) -lWebKitTestRunner -framework Carbon -framework Cocoa -framework _javascript_Core -framework WebKit;
STRIP_STYLE = debugging;
@@ -47,6 +46,3 @@
CODE_SIGN_IDENTITY_YES = $(WK_ENGINEERING_CODE_SIGN_IDENTITY);
CODE_SIGN_IDENTITY_Production = $(CODE_SIGN_IDENTITY_Production_$(USE_INTERNAL_SDK));
CODE_SIGN_IDENTITY_Production_YES = -;
-
-CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
-INFOPLIST_FILE = $(SRCROOT)/Info.plist;
Deleted: trunk/Tools/WebKitTestRunner/Info.plist (257539 => 257540)
--- trunk/Tools/WebKitTestRunner/Info.plist 2020-02-27 01:18:37 UTC (rev 257539)
+++ trunk/Tools/WebKitTestRunner/Info.plist 2020-02-27 01:38:09 UTC (rev 257540)
@@ -1,10 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
- <key>CFBundleName</key>
- <string>${PRODUCT_NAME}</string>
- <key>CFBundleIdentifier</key>
- <string>${PRODUCT_BUNDLE_IDENTIFIER}</string>
-</dict>
-</plist>
Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj (257539 => 257540)
--- trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2020-02-27 01:18:37 UTC (rev 257539)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2020-02-27 01:38:09 UTC (rev 257540)
@@ -316,7 +316,6 @@
4429FC611627089600F66D8B /* WorkQueueManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WorkQueueManager.h; sourceTree = "<group>"; };
4430AE171F82C4EE0099915A /* GeneratedTouchesDebugWindow.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = GeneratedTouchesDebugWindow.mm; sourceTree = "<group>"; };
4430AE181F82C4EF0099915A /* GeneratedTouchesDebugWindow.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GeneratedTouchesDebugWindow.h; sourceTree = "<group>"; };
- 49AEEF692407278200C87E4C /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
5322FB4113FDA0CD0041ABCC /* CyclicRedundancyCheck.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CyclicRedundancyCheck.cpp; sourceTree = "<group>"; };
5322FB4213FDA0CD0041ABCC /* CyclicRedundancyCheck.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CyclicRedundancyCheck.h; sourceTree = "<group>"; };
5322FB4413FDA0EA0041ABCC /* PixelDumpSupport.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PixelDumpSupport.cpp; sourceTree = "<group>"; };
@@ -463,7 +462,6 @@
08FB7794FE84155DC02AAC07 /* WebKitTestRunner */ = {
isa = PBXGroup;
children = (
- 49AEEF692407278200C87E4C /* Info.plist */,
0F18E71A1D6BC4BC0027E547 /* TestRunnerShared */,
BC952EC511F3C10F003398B4 /* DerivedSources.make */,
2EE52CEA1890A9A80010ED21 /* WebKitTestRunnerApp-Info.plist */,
