Title: [258288] trunk/Source/WebKit
- Revision
- 258288
- Author
- pvol...@apple.com
- Date
- 2020-03-11 15:01:20 -0700 (Wed, 11 Mar 2020)
Log Message
[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945
Reviewed by Tim Horton.
Check that accessibility library is present before attempting to call functions in it.
No new tests, since I am not able to reproduce.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258287 => 258288)
--- trunk/Source/WebKit/ChangeLog 2020-03-11 21:57:33 UTC (rev 258287)
+++ trunk/Source/WebKit/ChangeLog 2020-03-11 22:01:20 UTC (rev 258288)
@@ -2,6 +2,22 @@
[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945
+
+ Reviewed by Tim Horton.
+
+ Check that accessibility library is present before attempting to call functions in it.
+
+ No new tests, since I am not able to reproduce.
+
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::platformInitializeWebProcess):
+ * UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+ (WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
+2020-03-11 Per Arne Vollan <pvol...@apple.com>
+
+ [macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+ https://bugs.webkit.org/show_bug.cgi?id=208945
<rdar://problem/60330751>
Reviewed by Brent Fulgham.
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258287 => 258288)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-03-11 21:57:33 UTC (rev 258287)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-03-11 22:01:20 UTC (rev 258288)
@@ -455,7 +455,7 @@
}
#if ENABLE(CFPREFS_DIRECT_MODE)
- if (_AXSApplicationAccessibilityEnabled()) {
+ if (libAccessibilityLibrary() && _AXSApplicationAccessibilityEnabled()) {
SandboxExtension::Handle preferencesExtensionHandle;
SandboxExtension::createHandleForMachLookup("com.apple.cfprefsd.daemon", WTF::nullopt, preferencesExtensionHandle);
parameters.preferencesExtensionHandle = WTFMove(preferencesExtensionHandle);
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258287 => 258288)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-03-11 21:57:33 UTC (rev 258287)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-03-11 22:01:20 UTC (rev 258288)
@@ -44,6 +44,10 @@
#import <_javascript_Core/RemoteInspectorConstants.h>
#endif
+#if PLATFORM(COCOA)
+SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
+#endif
+
namespace WebKit {
static const Seconds unexpectedActivityDuration = 10_s;
@@ -210,6 +214,8 @@
{
if (m_hasSentMessageToUnblockAccessibilityServer)
return;
+ if (!libAccessibilityLibrary())
+ return;
if (!_AXSApplicationAccessibilityEnabled())
return;
if (!processIdentifier())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
