Title: [258289] trunk/Source/WebKit
- Revision
- 258289
- Author
- [email protected]
- Date
- 2020-03-11 15:18:04 -0700 (Wed, 11 Mar 2020)
Log Message
[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945
Unreviewed temporary compile fix.
* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258288 => 258289)
--- trunk/Source/WebKit/ChangeLog 2020-03-11 22:01:20 UTC (rev 258288)
+++ trunk/Source/WebKit/ChangeLog 2020-03-11 22:18:04 UTC (rev 258289)
@@ -3,6 +3,16 @@
[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945
+ Unreviewed temporary compile fix.
+
+ * UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+ (WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
+2020-03-11 Per Arne Vollan <[email protected]>
+
+ [macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+ https://bugs.webkit.org/show_bug.cgi?id=208945
+
Reviewed by Tim Horton.
Check that accessibility library is present before attempting to call functions in it.
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258288 => 258289)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-03-11 22:01:20 UTC (rev 258288)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-03-11 22:18:04 UTC (rev 258289)
@@ -44,12 +44,12 @@
#import <_javascript_Core/RemoteInspectorConstants.h>
#endif
-#if PLATFORM(COCOA)
+namespace WebKit {
+
+#if PLATFORM(MAC)
SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
#endif
-namespace WebKit {
-
static const Seconds unexpectedActivityDuration = 10_s;
const HashSet<String>& WebProcessProxy::platformPathsWithAssumedReadAccess()
@@ -214,8 +214,10 @@
{
if (m_hasSentMessageToUnblockAccessibilityServer)
return;
- if (!libAccessibilityLibrary())
+#if PLATFORM(MAC)
+ if (!WebKit::libAccessibilityLibrary())
return;
+#endif
if (!_AXSApplicationAccessibilityEnabled())
return;
if (!processIdentifier())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
