Title: [258621] trunk/Source/WebInspectorUI
- Revision
- 258621
- Author
- [email protected]
- Date
- 2020-03-17 20:59:13 -0700 (Tue, 17 Mar 2020)
Log Message
Web Inspector: Sources: hovering the title of an object preview popup for a DOM node doesn't highlight it
https://bugs.webkit.org/show_bug.cgi?id=209159
Reviewed by Timothy Hatcher.
* UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype._showPopoverForObject):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (258620 => 258621)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-03-18 03:32:31 UTC (rev 258620)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-03-18 03:59:13 UTC (rev 258621)
@@ -1,5 +1,15 @@
2020-03-17 Devin Rousso <[email protected]>
+ Web Inspector: Sources: hovering the title of an object preview popup for a DOM node doesn't highlight it
+ https://bugs.webkit.org/show_bug.cgi?id=209159
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WI.SourceCodeTextEditor.prototype._showPopoverForObject):
+
+2020-03-17 Devin Rousso <[email protected]>
+
REGRESSION(r257759): Web Inspector: Settings icon sometimes placed below the tab bar
https://bugs.webkit.org/show_bug.cgi?id=208603
<rdar://problem/60108967>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (258620 => 258621)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2020-03-18 03:32:31 UTC (rev 258620)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2020-03-18 03:59:13 UTC (rev 258621)
@@ -1941,6 +1941,10 @@
if (!domNode.ownerDocument)
return;
+ WI.bindInteractionsForNodeToElement(domNode, titleElement, {
+ ignoreClick: true,
+ });
+
var goToButton = titleElement.appendChild(WI.createGoToArrowButton());
goToButton.addEventListener("click", function() {
WI.domManager.inspectElement(nodeId, {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes