Modified: trunk/Source/WebInspectorUI/ChangeLog (258621 => 258622)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-03-18 03:59:13 UTC (rev 258621)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-03-18 04:14:52 UTC (rev 258622)
@@ -1,5 +1,29 @@
2020-03-17 Devin Rousso <[email protected]>
+ Web Inspector: Network: we should prefer showing "Preserve Log" over "Group Media Requests"
+ https://bugs.webkit.org/show_bug.cgi?id=209199
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/NetworkTableContentView.js:
+ (WI.NetworkTableContentView):
+ Change the `WI.NavigationItem.VisibilityPriority` of the various `WI.NavigationItem`:
+ High:
+ - URL filter
+ - resource type filter
+ - live/HAR view switcher
+ - disable resource caching toggle
+ Normal:
+ - Preserve Log checkbox
+ - clear button
+ Low:
+ - Group Media Requests checkbox
+ - HAR import/export buttons
+ This way, items that have alternate ways of being triggered (e.g. keyboard shortcuts) are
+ hidden first, and vica versa.
+
+2020-03-17 Devin Rousso <[email protected]>
+
Web Inspector: Sources: hovering the title of an object preview popup for a DOM node doesn't highlight it
https://bugs.webkit.org/show_bug.cgi?id=209159
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (258621 => 258622)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2020-03-18 03:59:13 UTC (rev 258621)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2020-03-18 04:14:52 UTC (rev 258622)
@@ -88,10 +88,12 @@
}
this._typeFilterScopeBar = new WI.ScopeBar("network-type-filter-scope-bar", typeFilterScopeBarItems, typeFilterScopeBarItems[0]);
+ this._typeFilterScopeBar.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;
this._typeFilterScopeBar.addEventListener(WI.ScopeBar.Event.SelectionChanged, this._typeFilterScopeBarSelectionChanged, this);
if (WI.MediaInstrument.supported()) {
this._groupMediaRequestsByDOMNodeNavigationItem = new WI.CheckboxNavigationItem("group-media-requests", WI.UIString("Group Media Requests"), WI.settings.groupMediaRequestsByDOMNode.value);
+ this._groupMediaRequestsByDOMNodeNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._groupMediaRequestsByDOMNodeNavigationItem.addEventListener(WI.CheckboxNavigationItem.Event.CheckedDidChange, this._handleGroupMediaRequestsByDOMNodeCheckedDidChange, this);
} else
WI.settings.groupMediaRequestsByDOMNode.value = false;
@@ -101,6 +103,7 @@
this._urlFilterIsActive = false;
this._urlFilterNavigationItem = new WI.FilterBarNavigationItem;
+ this._urlFilterNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;
this._urlFilterNavigationItem.filterBar.addEventListener(WI.FilterBar.Event.FilterDidChange, this._urlFilterDidChange, this);
this._urlFilterNavigationItem.filterBar.placeholder = WI.UIString("Filter Full URL");
@@ -137,10 +140,9 @@
this._collectionsPathNavigationItem.components = [pathComponent];
this._checkboxesNavigationItemGroup = new WI.GroupNavigationItem([this._clearOnLoadNavigationItem, new WI.DividerNavigationItem]);
- this._checkboxesNavigationItemGroup.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._pathComponentsNavigationItemGroup = new WI.GroupNavigationItem([this._collectionsPathNavigationItem, new WI.DividerNavigationItem]);
- this._pathComponentsNavigationItemGroup.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
+ this._pathComponentsNavigationItemGroup.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;
this._pathComponentsNavigationItemGroup.hidden = true;
this._buttonsNavigationItemGroup = new WI.GroupNavigationItem([this._harImportNavigationItem, this._harExportNavigationItem, new WI.DividerNavigationItem]);
@@ -152,8 +154,9 @@
let activatedToolTipForDisableResourceCache = WI.UIString("Use the resource cache when loading resources");
this._disableResourceCacheNavigationItem = new WI.ActivateButtonNavigationItem("disable-resource-cache", toolTipForDisableResourceCache, activatedToolTipForDisableResourceCache, "Images/IgnoreCaches.svg", 16, 16);
this._disableResourceCacheNavigationItem.activated = WI.settings.resourceCachingDisabled.value;
+ this._disableResourceCacheNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.High;
+ this._disableResourceCacheNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._toggleDisableResourceCache, this);
- this._disableResourceCacheNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._toggleDisableResourceCache, this);
WI.settings.resourceCachingDisabled.addEventListener(WI.Setting.Event.Changed, this._resourceCachingDisabledSettingChanged, this);
}
