Title: [258651] trunk
- Revision
- 258651
- Author
- [email protected]
- Date
- 2020-03-18 11:12:38 -0700 (Wed, 18 Mar 2020)
Log Message
frame/iframe scrolling attribute does to recognize value "noscroll" or "off"
https://bugs.webkit.org/show_bug.cgi?id=208570
Patch by Frederic Wang <[email protected]> on 2020-03-18
Reviewed by Rob Buis.
Source/WebCore:
Tests: imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute.html
imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute-values.html
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::scrollingMode const): Treat "noscroll" and "off" the same as "no".
LayoutTests:
* TestExpectations: Remove expectation failures.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (258650 => 258651)
--- trunk/LayoutTests/ChangeLog 2020-03-18 18:09:54 UTC (rev 258650)
+++ trunk/LayoutTests/ChangeLog 2020-03-18 18:12:38 UTC (rev 258651)
@@ -1,3 +1,12 @@
+2020-03-18 Frederic Wang <[email protected]>
+
+ frame/iframe scrolling attribute does to recognize value "noscroll" or "off"
+ https://bugs.webkit.org/show_bug.cgi?id=208570
+
+ Reviewed by Rob Buis.
+
+ * TestExpectations: Remove expectation failures.
+
2020-03-18 Jason Lawrence <[email protected]>
[ Mac ] imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement.html is flaky failing.
Modified: trunk/LayoutTests/TestExpectations (258650 => 258651)
--- trunk/LayoutTests/TestExpectations 2020-03-18 18:09:54 UTC (rev 258650)
+++ trunk/LayoutTests/TestExpectations 2020-03-18 18:12:38 UTC (rev 258651)
@@ -1065,10 +1065,6 @@
imported/w3c/web-platform-tests/IndexedDB/abort-in-initial-upgradeneeded.html [ Pass Failure ]
imported/w3c/web-platform-tests/IndexedDB/clone-before-keypath-eval.html [ Pass Failure ]
-# noscroll and off are not supported
-webkit.org/b/208570 imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute-values.html [ ImageOnlyFailure ]
-webkit.org/b/208570 imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute.html [ ImageOnlyFailure ]
-
# Those WPT tests are flaky when failing.
imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html [ Pass Failure ]
imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (258650 => 258651)
--- trunk/Source/WebCore/ChangeLog 2020-03-18 18:09:54 UTC (rev 258650)
+++ trunk/Source/WebCore/ChangeLog 2020-03-18 18:12:38 UTC (rev 258651)
@@ -1,3 +1,16 @@
+2020-03-18 Frederic Wang <[email protected]>
+
+ frame/iframe scrolling attribute does to recognize value "noscroll" or "off"
+ https://bugs.webkit.org/show_bug.cgi?id=208570
+
+ Reviewed by Rob Buis.
+
+ Tests: imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute.html
+ imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute-values.html
+
+ * html/HTMLFrameElementBase.cpp:
+ (WebCore::HTMLFrameElementBase::scrollingMode const): Treat "noscroll" and "off" the same as "no".
+
2020-03-18 Chris Dumez <[email protected]>
[ Mac wk2 ] http/wpt/beacon/beacon-quota.html is flaky failing
Modified: trunk/Source/WebCore/html/HTMLFrameElementBase.cpp (258650 => 258651)
--- trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2020-03-18 18:09:54 UTC (rev 258650)
+++ trunk/Source/WebCore/html/HTMLFrameElementBase.cpp 2020-03-18 18:12:38 UTC (rev 258651)
@@ -222,7 +222,10 @@
ScrollbarMode HTMLFrameElementBase::scrollingMode() const
{
- return equalLettersIgnoringASCIICase(attributeWithoutSynchronization(scrollingAttr), "no")
+ auto scrollingAttribute = attributeWithoutSynchronization(scrollingAttr);
+ return equalLettersIgnoringASCIICase(scrollingAttribute, "no")
+ || equalLettersIgnoringASCIICase(scrollingAttribute, "noscroll")
+ || equalLettersIgnoringASCIICase(scrollingAttribute, "off")
? ScrollbarAlwaysOff : ScrollbarAuto;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
