Title: [258652] trunk/Tools
- Revision
- 258652
- Author
- [email protected]
- Date
- 2020-03-18 11:15:34 -0700 (Wed, 18 Mar 2020)
Log Message
[ews] commit-queue should comment on bug in case of test failures
https://bugs.webkit.org/show_bug.cgi?id=209226
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
(BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
(SetBuildSummary): Ditto.
* BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (258651 => 258652)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-03-18 18:12:38 UTC (rev 258651)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-03-18 18:15:34 UTC (rev 258652)
@@ -1208,7 +1208,7 @@
else:
self.error_context_buffer.append(line)
- if "rror:" in line and self.errorReceived:
+ if 'rror:' in line and self.errorReceived:
map(self.errorReceived, self.error_context_buffer)
self.error_context_buffer = []
@@ -1826,7 +1826,13 @@
new_failures_string = ', '.join([failure_name for failure_name in new_failures])
message = 'Found {} new test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
self.descriptionDone = message
- self.build.buildFinished([message], FAILURE)
+
+ if self.getProperty('buildername', '').lower() == 'commit-queue':
+ self.setProperty('bugzilla_comment_text', message)
+ self.setProperty('build_finish_summary', message)
+ self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()])
+ else:
+ self.build.buildFinished([message], FAILURE)
return defer.succeed(None)
def report_pre_existing_failures(self, clean_tree_failures, flaky_failures):
@@ -2421,7 +2427,7 @@
class SetBuildSummary(buildstep.BuildStep):
- name = "set-build-summary"
+ name = 'set-build-summary'
descriptionDone = ['Set build summary']
alwaysRun = True
haltOnFailure = False
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (258651 => 258652)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-03-18 18:12:38 UTC (rev 258651)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-03-18 18:15:34 UTC (rev 258652)
@@ -1822,11 +1822,26 @@
def test_flaky_and_consistent_failures_without_clean_tree_failures(self):
self.configureStep()
+ self.setProperty('buildername', 'iOS-13-Simulator-WK2-Tests-EWS')
self.setProperty('first_run_failures', ['test1', 'test2'])
self.setProperty('second_run_failures', ['test1'])
self.expectOutcome(result=FAILURE, state_string='Found 1 new test failure: test1 (failure)')
- return self.runStep()
+ rc = self.runStep()
+ self.assertEqual(self.getProperty('bugzilla_comment_text'), None)
+ self.assertEqual(self.getProperty('build_finish_summary'), None)
+ return rc
+ def test_consistent_failure_without_clean_tree_failures_commit_queue(self):
+ self.configureStep()
+ self.setProperty('buildername', 'Commit-Queue')
+ self.setProperty('first_run_failures', ['test1'])
+ self.setProperty('second_run_failures', ['test1'])
+ self.expectOutcome(result=FAILURE, state_string='Found 1 new test failure: test1 (failure)')
+ rc = self.runStep()
+ self.assertEqual(self.getProperty('bugzilla_comment_text'), 'Found 1 new test failure: test1')
+ self.assertEqual(self.getProperty('build_finish_summary'), 'Found 1 new test failure: test1')
+ return rc
+
def test_flaky_and_inconsistent_failures_without_clean_tree_failures(self):
self.configureStep()
self.setProperty('first_run_failures', ['test1', 'test2'])
Modified: trunk/Tools/ChangeLog (258651 => 258652)
--- trunk/Tools/ChangeLog 2020-03-18 18:12:38 UTC (rev 258651)
+++ trunk/Tools/ChangeLog 2020-03-18 18:15:34 UTC (rev 258652)
@@ -1,3 +1,16 @@
+2020-03-18 Aakash Jain <[email protected]>
+
+ [ews] commit-queue should comment on bug in case of test failures
+ https://bugs.webkit.org/show_bug.cgi?id=209226
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
+ (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
+ (SetBuildSummary): Ditto.
+ * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
+
2020-03-18 Philippe Normand <[email protected]>
REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
