Title: [258696] trunk/Source/WebCore
- Revision
- 258696
- Author
- [email protected]
- Date
- 2020-03-19 07:05:01 -0700 (Thu, 19 Mar 2020)
Log Message
[GTK][WPE] Media controls numeric position value is not automatically updated during playback
https://bugs.webkit.org/show_bug.cgi?id=209051
Reviewed by Philippe Normand.
The time label is not updated because updateTime() thinks the media controls are hidden when not hovered, but
for audio elements the controls are always visible.
* Modules/mediacontrols/mediaControlsAdwaita.js:
(Controller.prototype.controlsAreAlwaysVisible): Return true for audio elements.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (258695 => 258696)
--- trunk/Source/WebCore/ChangeLog 2020-03-19 14:03:50 UTC (rev 258695)
+++ trunk/Source/WebCore/ChangeLog 2020-03-19 14:05:01 UTC (rev 258696)
@@ -1,3 +1,16 @@
+2020-03-19 Carlos Garcia Campos <[email protected]>
+
+ [GTK][WPE] Media controls numeric position value is not automatically updated during playback
+ https://bugs.webkit.org/show_bug.cgi?id=209051
+
+ Reviewed by Philippe Normand.
+
+ The time label is not updated because updateTime() thinks the media controls are hidden when not hovered, but
+ for audio elements the controls are always visible.
+
+ * Modules/mediacontrols/mediaControlsAdwaita.js:
+ (Controller.prototype.controlsAreAlwaysVisible): Return true for audio elements.
+
2020-03-19 Enrique Ocaña González <[email protected]>
[GTK] media/track/track-automatic-subtitles.html is timing out
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js (258695 => 258696)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js 2020-03-19 14:03:50 UTC (rev 258695)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.js 2020-03-19 14:05:01 UTC (rev 258696)
@@ -359,7 +359,7 @@
controlsAreAlwaysVisible: function()
{
- return this.controls.panel.classList.contains(this.ClassNames.noVideo);
+ return this.isAudio() || this.controls.panel.classList.contains(this.ClassNames.noVideo);
},
controlsAreHidden: function()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
