Diff
Modified: trunk/LayoutTests/ChangeLog (258696 => 258697)
--- trunk/LayoutTests/ChangeLog 2020-03-19 14:05:01 UTC (rev 258696)
+++ trunk/LayoutTests/ChangeLog 2020-03-19 14:11:32 UTC (rev 258697)
@@ -1,3 +1,14 @@
+2020-03-19 Antoine Quint <[email protected]>
+
+ onwebkit{animation, transition}XX handlers missing from Document
+ https://bugs.webkit.org/show_bug.cgi?id=206170
+ <rdar://problem/58596373>
+
+ Reviewed by Youenn Fablet.
+
+ * fast/dom/event-handler-attributes-expected.txt:
+ * fast/dom/event-handler-attributes.html:
+
2020-03-19 Enrique Ocaña González <[email protected]>
[GTK] media/track/track-automatic-subtitles.html is timing out
Modified: trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt (258696 => 258697)
--- trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt 2020-03-19 14:05:01 UTC (rev 258696)
+++ trunk/LayoutTests/fast/dom/event-handler-attributes-expected.txt 2020-03-19 14:11:32 UTC (rev 258697)
@@ -166,6 +166,10 @@
PASS testScriptAttribute(document, "transitionend") is "document"
PASS testScriptAttribute(document, "volumechange") is "document"
PASS testScriptAttribute(document, "waiting") is "document"
+PASS testScriptAttribute(document, "webkitanimationend") is "document"
+PASS testScriptAttribute(document, "webkitanimationiteration") is "document"
+PASS testScriptAttribute(document, "webkitanimationstart") is "document"
+PASS testScriptAttribute(document, "webkittransitionend") is "document"
PASS testScriptAttribute(document, "wheel") is "document"
Event names we expect not to be able to set on the document
@@ -184,10 +188,6 @@
PASS testScriptAttribute(document, "popstate") is "none"
PASS testScriptAttribute(document, "storage") is "none"
PASS testScriptAttribute(document, "unload") is "none"
-PASS testScriptAttribute(document, "webkitanimationend") is "none"
-PASS testScriptAttribute(document, "webkitanimationiteration") is "none"
-PASS testScriptAttribute(document, "webkitanimationstart") is "none"
-PASS testScriptAttribute(document, "webkittransitionend") is "none"
Event names we expect to be able to set on an element (tested on the <html> element)
Modified: trunk/LayoutTests/fast/dom/event-handler-attributes.html (258696 => 258697)
--- trunk/LayoutTests/fast/dom/event-handler-attributes.html 2020-03-19 14:05:01 UTC (rev 258696)
+++ trunk/LayoutTests/fast/dom/event-handler-attributes.html 2020-03-19 14:11:32 UTC (rev 258697)
@@ -72,7 +72,11 @@
"volumechange",
"waiting",
"search",
- "wheel"
+ "wheel",
+ "webkitanimationend",
+ "webkitanimationiteration",
+ "webkitanimationstart",
+ "webkittransitionend"
];
const eventsInWindowEventHandlers = [
@@ -105,9 +109,6 @@
"webkittransitionend"
];
-const uniqueWindowEvents = [
-];
-
const uniqueDocumentEvents = [
"selectionchange",
"readystatechange"
@@ -246,7 +247,7 @@
});
}
-const windowEvents = arrayUnion(eventsInGlobalEventHandlers, eventsInWindowEventHandlers, elementAndWindowEvents, uniqueWindowEvents);
+const windowEvents = arrayUnion(eventsInGlobalEventHandlers, eventsInWindowEventHandlers, elementAndWindowEvents);
const documentEvents = arrayUnion(eventsInGlobalEventHandlers, elementAndDocumentEvents, uniqueDocumentEvents);
const elementEvents = arrayUnion(eventsInGlobalEventHandlers, elementAndDocumentEvents, elementAndWindowEvents, elementBodyAndFrameSetEvents, uniqueElementEvents);
Modified: trunk/Source/WebCore/ChangeLog (258696 => 258697)
--- trunk/Source/WebCore/ChangeLog 2020-03-19 14:05:01 UTC (rev 258696)
+++ trunk/Source/WebCore/ChangeLog 2020-03-19 14:11:32 UTC (rev 258697)
@@ -1,3 +1,17 @@
+2020-03-19 Antoine Quint <[email protected]>
+
+ onwebkit{animation, transition}XX handlers missing from Document
+ https://bugs.webkit.org/show_bug.cgi?id=206170
+ <rdar://problem/58596373>
+
+ Reviewed by Youenn Fablet.
+
+ We now specify the non-standard CSS Animations and CSS Transitions event handlers on DocumentAndElementEventHandlers.idl rather than Element.idl
+ such that they specified on both Element and Document.
+
+ * dom/DocumentAndElementEventHandlers.idl:
+ * dom/Element.idl:
+
2020-03-19 Carlos Garcia Campos <[email protected]>
[GTK][WPE] Media controls numeric position value is not automatically updated during playback
Modified: trunk/Source/WebCore/dom/DocumentAndElementEventHandlers.idl (258696 => 258697)
--- trunk/Source/WebCore/dom/DocumentAndElementEventHandlers.idl 2020-03-19 14:05:01 UTC (rev 258696)
+++ trunk/Source/WebCore/dom/DocumentAndElementEventHandlers.idl 2020-03-19 14:11:32 UTC (rev 258697)
@@ -36,4 +36,9 @@
[NotEnumerable] attribute EventHandler onbeforecut;
[NotEnumerable] attribute EventHandler onbeforeinput;
[NotEnumerable] attribute EventHandler onbeforepaste;
+
+ [NotEnumerable, ImplementedAs=onwebkitAnimationEnd] attribute EventHandler onwebkitanimationend;
+ [NotEnumerable, ImplementedAs=onwebkitAnimationIteration] attribute EventHandler onwebkitanimationiteration;
+ [NotEnumerable, ImplementedAs=onwebkitAnimationStart] attribute EventHandler onwebkitanimationstart;
+ [NotEnumerable, ImplementedAs=onwebkitTransitionEnd] attribute EventHandler onwebkittransitionend;
};
Modified: trunk/Source/WebCore/dom/Element.idl (258696 => 258697)
--- trunk/Source/WebCore/dom/Element.idl 2020-03-19 14:05:01 UTC (rev 258696)
+++ trunk/Source/WebCore/dom/Element.idl 2020-03-19 14:11:32 UTC (rev 258697)
@@ -119,12 +119,6 @@
[NotEnumerable, Conditional=IOS_GESTURE_EVENTS] attribute EventHandler ongestureend;
[NotEnumerable, Conditional=IOS_GESTURE_EVENTS] attribute EventHandler ongesturestart;
- // Non standard.
- [NotEnumerable, ImplementedAs=onwebkitAnimationEnd] attribute EventHandler onwebkitanimationend;
- [NotEnumerable, ImplementedAs=onwebkitAnimationIteration] attribute EventHandler onwebkitanimationiteration;
- [NotEnumerable, ImplementedAs=onwebkitAnimationStart] attribute EventHandler onwebkitanimationstart;
- [NotEnumerable, ImplementedAs=onwebkitTransitionEnd] attribute EventHandler onwebkittransitionend;
-
// FIXME: These event handlers should only be on Document (https://fullscreen.spec.whatwg.org/#api).
[NotEnumerable, Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, DisabledByQuirk=shouldDisableElementFullscreen] attribute EventHandler onwebkitfullscreenchange;
[NotEnumerable, Conditional=FULLSCREEN_API, EnabledBySetting=FullScreen, DisabledByQuirk=shouldDisableElementFullscreen] attribute EventHandler onwebkitfullscreenerror;
