Title: [258699] trunk/Tools
- Revision
- 258699
- Author
- [email protected]
- Date
- 2020-03-19 08:24:52 -0700 (Thu, 19 Mar 2020)
Log Message
[Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
https://bugs.webkit.org/show_bug.cgi?id=209223
Reviewed by Carlos Alberto Lopez Perez.
flatpak build doesn't expose a --socket option for white-listing
the systemd journal socket. So white-list everything in /run. 🤷
* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (258698 => 258699)
--- trunk/Tools/ChangeLog 2020-03-19 15:17:17 UTC (rev 258698)
+++ trunk/Tools/ChangeLog 2020-03-19 15:24:52 UTC (rev 258699)
@@ -1,3 +1,16 @@
+2020-03-19 Philippe Normand <[email protected]>
+
+ [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
+ https://bugs.webkit.org/show_bug.cgi?id=209223
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ flatpak build doesn't expose a --socket option for white-listing
+ the systemd journal socket. So white-list everything in /run. 🤷
+
+ * flatpak/flatpakutils.py:
+ (WebkitFlatpak.run_in_sandbox):
+
2020-03-19 Charlie Turner <[email protected]>
Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
Modified: trunk/Tools/flatpak/flatpakutils.py (258698 => 258699)
--- trunk/Tools/flatpak/flatpakutils.py 2020-03-19 15:17:17 UTC (rev 258698)
+++ trunk/Tools/flatpak/flatpakutils.py 2020-03-19 15:24:52 UTC (rev 258699)
@@ -568,6 +568,8 @@
building = os.path.basename(args[0]).startswith("build")
sandbox_build_path = os.path.join(self.sandbox_source_root, "WebKitBuild", self.build_type)
+ # FIXME: Using the `run` flatpak command would be better, but it doesn't
+ # have a --bind-mount option.
flatpak_command = ["flatpak", "build",
"--die-with-parent",
"--talk-name=org.a11y.Bus",
@@ -574,9 +576,13 @@
"--talk-name=org.gtk.vfs",
"--talk-name=org.gtk.vfs.*",
"--bind-mount=/run/shm=/dev/shm",
- # Workaround for https://webkit.org/b/187384 to have our own perl modules usable inside the sandbox
- # as setting the PERL5LIB envvar won't work inside apache (and for scripts using `perl -T``).
+ # Access to /run/host is required by the crash log reporter.
"--bind-mount=/run/host/%s=%s" % (tempfile.gettempdir(), tempfile.gettempdir()),
+ # flatpak build doesn't expose a --socket option for
+ # white-listing the systemd journal socket. So
+ # white-list it in /run, hoping this is the right
+ # path.
+ "--bind-mount=/run/systemd/journal=/run/systemd/journal",
"--bind-mount=%s=%s" % (self.sandbox_source_root, self.source_root),
# We mount WebKitBuild/PORTNAME/BuildType to /app/webkit/WebKitBuild/BuildType
# so we can build WPE and GTK in a same source tree.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
