Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (258697 => 258698)
--- trunk/Source/_javascript_Core/ChangeLog 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-03-19 15:17:17 UTC (rev 258698)
@@ -1,3 +1,14 @@
+2020-03-19 Charlie Turner <[email protected]>
+
+ Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
+ https://bugs.webkit.org/show_bug.cgi?id=209146
+
+ Reviewed by Darin Adler.
+
+ * runtime/JSCellInlines.h:
+ (JSC::CallFrame::deprecatedVM const): A reference may not be NULL, so
+ this ASSERT() can never trip.
+
2020-03-18 Yusuke Suzuki <[email protected]>
Add a way to mark a rejected promise as handled
Modified: trunk/Source/_javascript_Core/runtime/JSCellInlines.h (258697 => 258698)
--- trunk/Source/_javascript_Core/runtime/JSCellInlines.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/_javascript_Core/runtime/JSCellInlines.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -142,7 +142,6 @@
{
JSCell* callee = this->callee().asCell();
ASSERT(callee);
- ASSERT(&callee->vm());
return callee->vm();
}
Modified: trunk/Source/WTF/ChangeLog (258697 => 258698)
--- trunk/Source/WTF/ChangeLog 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WTF/ChangeLog 2020-03-19 15:17:17 UTC (rev 258698)
@@ -1,3 +1,15 @@
+2020-03-19 Charlie Turner <[email protected]>
+
+ Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
+ https://bugs.webkit.org/show_bug.cgi?id=209146
+
+ Reviewed by Darin Adler.
+
+ * wtf/LoggerHelper.h: When the RELEASE_LOG is disabled, avoid warning
+ spam about unused channel names. Call sites often create locals for
+ the channel name outside of RELEASE_LOG ifdef's, which cause many
+ unused variable warnings.
+
2020-03-19 Philippe Normand <[email protected]>
[GTK][WPE] Unreviewed, build fixes after r258547 when disabling release logging support
Modified: trunk/Source/WTF/wtf/LoggerHelper.h (258697 => 258698)
--- trunk/Source/WTF/wtf/LoggerHelper.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WTF/wtf/LoggerHelper.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -89,14 +89,13 @@
#define LOGIDENTIFIER (WTF::nullopt)
-#define ALWAYS_LOG(...) ((void)0)
-#define ERROR_LOG(...) ((void)0)
-#define ERROR_LOG(...) ((void)0)
-#define WARNING_LOG(...) ((void)0)
-#define NOTICE_LOG(...) ((void)0)
-#define INFO_LOG(...) ((void)0)
-#define DEBUG_LOG(...) ((void)0)
-#define WILL_LOG(_level_) false
+#define ALWAYS_LOG(channelName, ...) (UNUSED_PARAM(channelName))
+#define ERROR_LOG(channelName, ...) (UNUSED_PARAM(channelName))
+#define WARNING_LOG(channelName, ...) (UNUSED_PARAM(channelName))
+#define NOTICE_LOG(channelName, ...) (UNUSED_PARAM(channelName))
+#define INFO_LOG(channelName, ...) (UNUSED_PARAM(channelName))
+#define DEBUG_LOG(channelName, ...) (UNUSED_PARAM(channelName))
+#define WILL_LOG(_level_) false
#define ALWAYS_LOG_IF(condition, ...) ((void)0)
#define ERROR_LOG_IF(condition, ...) ((void)0)
Modified: trunk/Source/WebCore/ChangeLog (258697 => 258698)
--- trunk/Source/WebCore/ChangeLog 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/ChangeLog 2020-03-19 15:17:17 UTC (rev 258698)
@@ -1,3 +1,51 @@
+2020-03-19 Charlie Turner <[email protected]>
+
+ Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
+ https://bugs.webkit.org/show_bug.cgi?id=209146
+
+ Reviewed by Darin Adler.
+
+ Warning fixes, no new tests.
+
+ * Modules/encryptedmedia/MediaKeys.cpp:
+ (WebCore::MediaKeys::MediaKeys):
+ * Modules/webaudio/MediaStreamAudioSource.h: The m_numberOfFrames ivar
+ is platform-specific.
+ * loader/cache/CachedResource.cpp:
+ (WebCore::CachedResource::load):
+ * platform/graphics/texmap/TextureMapperGL.cpp:
+ (WebCore::TextureMapperGLData::getStaticVBO):
+ * platform/mediastream/RealtimeVideoSource.h:
+ * platform/mediastream/gstreamer/GStreamerAudioCapturer.h: There are
+ still virtual methods in this class, but no virtual destructor. Since
+ this won't be subclassed further (I doubt, anyway!) lets make it final
+ and plug the bug.
+ * platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
+ * platform/mediastream/gstreamer/GStreamerVideoCapturer.h: See
+ AudioCapturer.
+ * platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
+ (WebCore::GStreamerVideoDecoder::RegisterDecodeCompleteCallback): Deleted.
+ (WebCore::GStreamerVideoDecoder::ImplementationName const): Deleted.
+ * platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp:
+ * platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp: The
+ encoder was being used uninitialized, and hence codec support can not
+ be working as intended. Fix that bug.
+ (WebCore::GStreamerVideoEncoder::AddCodecIfSupported):
+ (WebCore::GStreamerVideoEncoder::InitEncode): Deleted.
+ (WebCore::GStreamerVideoEncoder::GetEncoderInfo const): Deleted.
+ * platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.h:
+ * platform/network/soup/NetworkStorageSessionSoup.cpp:
+ (WebCore::NetworkStorageSession::setCookies):
+ * rendering/RenderLayerBacking.h: Condition the bear trap on Cocoa
+ platform where the crash is being seen. On GTK these traps generate
+ warning spam and we don't see the crash here.
+ * rendering/RenderThemeAdwaita.h:
+ * testing/Internals.cpp:
+ (WebCore::Internals::readPreferenceInteger):
+ (WebCore::Internals::encodedPreferenceValue):
+ (WebCore::Internals::getUTIFromMIMEType):
+ (WebCore::Internals::getUTIFromTag):
+
2020-03-19 Antoine Quint <[email protected]>
onwebkit{animation, transition}XX handlers missing from Document
Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp (258697 => 258698)
--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -63,6 +63,8 @@
{
#if !RELEASE_LOG_DISABLED
m_instance->setLogger(document.logger(), m_logIdentifier);
+#else
+ UNUSED_PARAM(document);
#endif
m_instance->setClient(makeWeakPtr(this));
}
Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.h (258697 => 258698)
--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -58,7 +58,9 @@
String m_deviceId;
RealtimeMediaSourceSettings m_currentSettings;
+#if USE(AVFOUNDATION)
size_t m_numberOfFrames { 0 };
+#endif
};
} // namespace WebCore
Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (258697 => 258698)
--- trunk/Source/WebCore/loader/cache/CachedResource.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -330,8 +330,7 @@
platformStrategies()->loaderStrategy()->loadResource(frame, *this, WTFMove(request), m_options, [this, protectedThis = CachedResourceHandle<CachedResource>(this), frameRef = makeRef(frame), loggingAllowed = cachedResourceLoader.isAlwaysOnLoggingAllowed()] (RefPtr<SubresourceLoader>&& loader) {
m_loader = WTFMove(loader);
if (!m_loader) {
- auto& frame = frameRef.get();
- RELEASE_LOG_IF(loggingAllowed, Network, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 "] CachedResource::load: Unable to create SubresourceLoader", this, PAGE_ID(frame), FRAME_ID(frame));
+ RELEASE_LOG_IF(loggingAllowed, Network, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 "] CachedResource::load: Unable to create SubresourceLoader", this, PAGE_ID(frameRef.get()), FRAME_ID(frameRef.get()));
failBeforeStarting();
return;
}
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (258697 => 258698)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -150,7 +150,7 @@
GLuint TextureMapperGLData::getStaticVBO(GLenum target, GLsizeiptr size, const void* data)
{
auto addResult = m_vbos.ensure(data,
- [this, target, size, data] {
+ [target, size, data] {
GLuint vbo = 0;
glGenBuffers(1, &vbo);
glBindBuffer(target, vbo);
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.h (258697 => 258698)
--- trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -70,7 +70,9 @@
Ref<RealtimeVideoCaptureSource> m_source;
RealtimeMediaSourceSettings m_currentSettings;
+#if !RELEASE_LOG_DISABLED
uint64_t m_cloneCounter { 0 };
+#endif
};
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.h (258697 => 258698)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -27,7 +27,7 @@
namespace WebCore {
-class GStreamerAudioCapturer : public GStreamerCapturer {
+class GStreamerAudioCapturer final : public GStreamerCapturer {
public:
GStreamerAudioCapturer(GStreamerCaptureDevice);
GStreamerAudioCapturer();
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp (258697 => 258698)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -38,9 +38,6 @@
namespace WebCore {
-const static int defaultWidth = 640;
-const static int defaultHeight = 480;
-
GST_DEBUG_CATEGORY(webkit_video_capture_source_debug);
#define GST_CAT_DEFAULT webkit_video_capture_source_debug
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.h (258697 => 258698)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -29,7 +29,7 @@
namespace WebCore {
-class GStreamerVideoCapturer : public GStreamerCapturer {
+class GStreamerVideoCapturer final : public GStreamerCapturer {
public:
GStreamerVideoCapturer(GStreamerCaptureDevice);
GStreamerVideoCapturer(const char* source_factory);
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp (258697 => 258698)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -165,7 +165,7 @@
return WEBRTC_VIDEO_CODEC_OK;
}
- int32_t RegisterDecodeCompleteCallback(webrtc::DecodedImageCallback* callback)
+ int32_t RegisterDecodeCompleteCallback(webrtc::DecodedImageCallback* callback) override
{
m_imageReadyCb = callback;
@@ -320,7 +320,7 @@
virtual const gchar* Caps() = 0;
virtual webrtc::VideoCodecType CodecType() = 0;
- const char* ImplementationName() const { return "GStreamer"; }
+ const char* ImplementationName() const override { return "GStreamer"; }
virtual const gchar* Name() = 0;
protected:
@@ -336,7 +336,6 @@
GstElement* m_sink;
GstElement* m_src;
- GstVideoInfo m_info;
webrtc::DecodedImageCallback* m_imageReadyCb;
StdMap<GstClockTime, InputTimestamps> m_dtsPtsMap;
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp (258697 => 258698)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -67,17 +67,7 @@
ENCODER_LAST,
} EncoderId;
-EncoderDefinition encoders[ENCODER_LAST] = {
- FALSE,
- NULL,
- NULL,
- NULL,
- NULL,
- NULL,
- NULL,
- NULL,
- NULL,
-};
+EncoderDefinition encoders[ENCODER_LAST] = { { } };
typedef struct
{
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp (258697 => 258698)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -100,7 +100,7 @@
return elem;
}
- int32_t InitEncode(const webrtc::VideoCodec* codecSettings, int32_t, size_t)
+ int32_t InitEncode(const webrtc::VideoCodec* codecSettings, int32_t, size_t) override
{
g_return_val_if_fail(codecSettings, WEBRTC_VIDEO_CODEC_ERR_PARAMETER);
g_return_val_if_fail(codecSettings->codecType == CodecType(), WEBRTC_VIDEO_CODEC_ERR_PARAMETER);
@@ -188,7 +188,8 @@
}
}
- VideoEncoder::EncoderInfo GetEncoderInfo() const {
+ VideoEncoder::EncoderInfo GetEncoderInfo() const override
+ {
EncoderInfo info;
info.supports_native_handle = false;
info.implementation_name = "GStreamer";
@@ -298,11 +299,9 @@
void AddCodecIfSupported(std::vector<webrtc::SdpVideoFormat>* supportedFormats)
{
- GstElement* encoder;
+ if (auto encoder = createEncoder()) {
+ webrtc::SdpVideoFormat format = ConfigureSupportedCodec(encoder.get());
- if (createEncoder().get() != nullptr) {
- webrtc::SdpVideoFormat format = ConfigureSupportedCodec(encoder);
-
supportedFormats->push_back(format);
}
}
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.h (258697 => 258698)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -35,7 +35,7 @@
private:
std::vector<webrtc::SdpVideoFormat> GetSupportedFormats() const override;
std::unique_ptr<webrtc::VideoEncoder> CreateVideoEncoder(const webrtc::SdpVideoFormat&) final;
- CodecInfo QueryVideoEncoder(const webrtc::SdpVideoFormat&) const
+ CodecInfo QueryVideoEncoder(const webrtc::SdpVideoFormat&) const override
{
GST_FIXME("Detect wether the decoder is HW accelerated");
Modified: trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp (258697 => 258698)
--- trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -317,6 +317,8 @@
soup_cookie_jar_add_cookie_full(cookieStorage(), cookie.toSoupCookie(), origin.get(), firstPartyURI.get());
#else
+ UNUSED_PARAM(url);
+ UNUSED_PARAM(firstParty);
soup_cookie_jar_add_cookie(cookieStorage(), cookie.toSoupCookie());
#endif
}
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.h (258697 => 258698)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -43,7 +43,7 @@
class TransformationMatrix;
-#if __WORDSIZE == 64
+#if __WORDSIZE == 64 && PLATFORM(COCOA)
#define USE_OWNING_LAYER_BEAR_TRAP 1
#define BEAR_TRAP_VALUE 0xEEEEEEEEEEEEEEEE
#else
Modified: trunk/Source/WebCore/rendering/RenderThemeAdwaita.h (258697 => 258698)
--- trunk/Source/WebCore/rendering/RenderThemeAdwaita.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/rendering/RenderThemeAdwaita.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -62,8 +62,8 @@
bool paintSearchField(const RenderObject&, const PaintInfo&, const IntRect&) final;
bool popsMenuBySpaceOrReturn() const final { return true; }
- void adjustMenuListStyle(RenderStyle&, const Element*) const;
- void adjustMenuListButtonStyle(RenderStyle&, const Element*) const;
+ void adjustMenuListStyle(RenderStyle&, const Element*) const override;
+ void adjustMenuListButtonStyle(RenderStyle&, const Element*) const override;
LengthBox popupInternalPaddingBox(const RenderStyle&) const final;
bool paintMenuList(const RenderObject&, const PaintInfo&, const FloatRect&) final;
bool paintMenuListButtonDecorations(const RenderBox&, const PaintInfo&, const FloatRect&) final;
Modified: trunk/Source/WebCore/testing/Internals.cpp (258697 => 258698)
--- trunk/Source/WebCore/testing/Internals.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebCore/testing/Internals.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -5518,24 +5518,18 @@
}
#if !PLATFORM(COCOA)
-String Internals::encodedPreferenceValue(const String& domain, const String& key)
+String Internals::encodedPreferenceValue(const String&, const String&)
{
- UNUSED_PARAM(domain);
- UNUSED_PARAM(key);
return emptyString();
}
-String Internals::getUTIFromMIMEType(const String& mimeType)
+String Internals::getUTIFromMIMEType(const String&)
{
- UNUSED_PARAM(mimeType);
return emptyString();
}
-String Internals::getUTIFromTag(const String& tagClass, const String& tag, const String& conformingToUTI)
+String Internals::getUTIFromTag(const String&, const String&, const String&)
{
- UNUSED_PARAM(tagClass);
- UNUSED_PARAM(tag);
- UNUSED_PARAM(conformingToUTI);
return emptyString();
}
Modified: trunk/Source/WebDriver/ChangeLog (258697 => 258698)
--- trunk/Source/WebDriver/ChangeLog 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebDriver/ChangeLog 2020-03-19 15:17:17 UTC (rev 258698)
@@ -1,3 +1,16 @@
+2020-03-19 Charlie Turner <[email protected]>
+
+ Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
+ https://bugs.webkit.org/show_bug.cgi?id=209146
+
+ Reviewed by Darin Adler.
+
+ * Session.cpp:
+ (WebDriver::Session::newWindow):
+ (WebDriver::Session::elementIsFileUpload):
+ (WebDriver::Session::elementIsEditable):
+ (WebDriver::Session::setInputFileUploadFiles):
+
2020-02-12 Carlos Alberto Lopez Perez <[email protected]>
WebDriver: return invalidSessionID exception if the WebProcess doesn't respond (crashes)
Modified: trunk/Source/WebDriver/Session.cpp (258697 => 258698)
--- trunk/Source/WebDriver/Session.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebDriver/Session.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -608,7 +608,7 @@
parameters = JSON::Object::create();
parameters->setString("presentationHint"_s, typeHint.value() == "window" ? "Window"_s : "Tab"_s);
}
- m_host->sendCommandToBackend("createBrowsingContext"_s, WTFMove(parameters), [this, protectedThis = protectedThis.copyRef(), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
+ m_host->sendCommandToBackend("createBrowsingContext"_s, WTFMove(parameters), [protectedThis = protectedThis.copyRef(), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
if (response.isError || !response.responseObject) {
completionHandler(CommandResult::fail(WTFMove(response.responseObject)));
return;
@@ -1550,7 +1550,7 @@
parameters->setString("frameHandle"_s, m_currentBrowsingContext.value());
parameters->setString("function"_s, isFileUploadScript);
parameters->setArray("arguments"_s, WTFMove(arguments));
- m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
+ m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
if (response.isError || !response.responseObject) {
completionHandler(CommandResult::fail(WTFMove(response.responseObject)));
return;
@@ -1692,7 +1692,7 @@
parameters->setString("frameHandle"_s, m_currentBrowsingContext.value());
parameters->setString("function"_s, isEditableScript);
parameters->setArray("arguments"_s, WTFMove(arguments));
- m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
+ m_host->sendCommandToBackend("evaluateJavaScriptFunction"_s, WTFMove(parameters), [protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
if (response.isError || !response.responseObject) {
completionHandler(CommandResult::fail(WTFMove(response.responseObject)));
return;
@@ -1794,7 +1794,7 @@
parameters->setString("frameHandle"_s, m_currentBrowsingContext.valueOr(emptyString()));
parameters->setString("nodeHandle"_s, elementID);
parameters->setArray("filenames"_s, WTFMove(filenames));
- m_host->sendCommandToBackend("setFilesForInputFileUpload"_s, WTFMove(parameters), [this, protectedThis = makeRef(*this), elementID, completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) mutable {
+ m_host->sendCommandToBackend("setFilesForInputFileUpload"_s, WTFMove(parameters), [protectedThis = makeRef(*this), elementID, completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) mutable {
if (response.isError) {
completionHandler(CommandResult::fail(WTFMove(response.responseObject)));
return;
Modified: trunk/Source/WebKit/ChangeLog (258697 => 258698)
--- trunk/Source/WebKit/ChangeLog 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/ChangeLog 2020-03-19 15:17:17 UTC (rev 258698)
@@ -1,3 +1,29 @@
+2020-03-19 Charlie Turner <[email protected]>
+
+ Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
+ https://bugs.webkit.org/show_bug.cgi?id=209146
+
+ Reviewed by Darin Adler.
+
+ * NetworkProcess/NetworkHTTPSUpgradeChecker.cpp:
+ (WebKit::NetworkHTTPSUpgradeChecker::query):
+ * NetworkProcess/NetworkLoadChecker.cpp: The m_isHTTPSUpgradeEnabled
+ ivar is only used on Cocoa platforms, on GTK it is causing warning
+ spam.
+ (WebKit::NetworkLoadChecker::NetworkLoadChecker):
+ * NetworkProcess/NetworkLoadChecker.h:
+ * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
+ (WebKit::CoordinatedGraphicsScene::updateSceneState):
+ *
+ Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
+ m_inForceRepaint is not being used anymore.
+ (WebKit::ThreadedCompositor::forceRepaint):
+ * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
+ * UIProcess/API/glib/WebKitNavigationClient.cpp:
+ * UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
+ (WebKit::RemoteInspectorProtocolHandler::RemoteInspectorProtocolHandler):
+ * UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.h:
+
2020-03-19 youenn fablet <[email protected]>
Make URL::path() return a StringView
Modified: trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp (258697 => 258698)
--- trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -112,6 +112,8 @@
if (stepResult != SQLITE_ROW && stepResult != SQLITE_DONE) {
#if PLATFORM(COCOA)
RELEASE_LOG_ERROR_IF_ALLOWED(sessionID, "step failed with error code %d, error message: %{public}s, database path: %{public}s", stepResult, m_database->lastErrorMsg(), networkHTTPSUpgradeCheckerDatabasePath().utf8().data());
+#else
+ UNUSED_VARIABLE(sessionID);
#endif
ASSERT_NOT_REACHED();
RunLoop::main().dispatch([callback = WTFMove(callback)] () mutable {
Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp (258697 => 258698)
--- trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -62,11 +62,17 @@
, m_preflightPolicy(preflightPolicy)
, m_referrer(WTFMove(referrer))
, m_shouldCaptureExtraNetworkLoadMetrics(shouldCaptureExtraNetworkLoadMetrics)
+#if PLATFORM(COCOA)
, m_isHTTPSUpgradeEnabled(isHTTPSUpgradeEnabled)
+#endif
, m_requestLoadType(requestLoadType)
, m_schemeRegistry(schemeRegistry)
, m_networkResourceLoader(makeWeakPtr(networkResourceLoader))
{
+#if !PLATFORM(COCOA)
+ UNUSED_PARAM(isHTTPSUpgradeEnabled);
+#endif
+
m_isSameOriginRequest = isSameOrigin(m_url, m_origin.get());
switch (options.credentials) {
case FetchOptions::Credentials::Include:
Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h (258697 => 258698)
--- trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -153,7 +153,11 @@
String m_referrer;
bool m_checkContentExtensions { false };
bool m_shouldCaptureExtraNetworkLoadMetrics { false };
+
+#if PLATFORM(COCOA)
bool m_isHTTPSUpgradeEnabled { false };
+#endif
+
WebCore::NetworkLoadInformation m_loadInformation;
LoadType m_requestLoadType;
Modified: trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp (258697 => 258698)
--- trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -271,7 +271,7 @@
for (auto& compositionLayer : m_nicosia.state.layers) {
auto& layer = texmapLayer(*compositionLayer);
compositionLayer->commitState(
- [this, &layer, &compositionLayer, &layersByBacking]
+ [&layer, &layersByBacking]
(const Nicosia::CompositionLayer::LayerState& layerState)
{
if (layerState.delta.positionChanged)
Modified: trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp (258697 => 258698)
--- trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -167,7 +167,6 @@
// in a way that doesn't starve out the underlying graphics buffers.
#if PLATFORM(GTK) && !USE(WPE_RENDERER)
m_compositingRunLoop->performTaskSync([this, protectedThis = makeRef(*this)] {
- SetForScope<bool> change(m_inForceRepaint, true);
renderLayerTree();
});
#endif
Modified: trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h (258697 => 258698)
--- trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -101,7 +101,6 @@
uint64_t m_nativeSurfaceHandle;
WebCore::TextureMapper::PaintFlags m_paintFlags { 0 };
- bool m_inForceRepaint { false };
unsigned m_suspendedCount { 0 };
std::unique_ptr<CompositingRunLoop> m_compositingRunLoop;
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp (258697 => 258698)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -123,6 +123,7 @@
return true;
case ProcessTerminationReason::ExceededCPULimit:
case ProcessTerminationReason::RequestedByClient:
+ case ProcessTerminationReason::RequestedByNetworkProcess:
case ProcessTerminationReason::NavigationSwap:
break;
}
Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp (258697 => 258698)
--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -60,7 +60,6 @@
};
RemoteInspectorProtocolHandler::RemoteInspectorProtocolHandler(WebKitWebContext* context)
- : m_context(context)
{
webkit_web_context_register_uri_scheme(context, "inspector", [](WebKitURISchemeRequest* request, gpointer userData) {
static_cast<RemoteInspectorProtocolHandler*>(userData)->handleRequest(request);
Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.h (258697 => 258698)
--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.h 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.h 2020-03-19 15:17:17 UTC (rev 258698)
@@ -49,7 +49,6 @@
void targetListChanged(RemoteInspectorClient&) override;
void connectionClosed(RemoteInspectorClient&) override;
- WebKitWebContext* m_context { nullptr };
HashMap<String, std::unique_ptr<RemoteInspectorClient>> m_inspectorClients;
HashSet<WebKitUserContentManager*> m_userContentManagers;
HashSet<WebKitWebView*> m_webViews;
Modified: trunk/Tools/ChangeLog (258697 => 258698)
--- trunk/Tools/ChangeLog 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Tools/ChangeLog 2020-03-19 15:17:17 UTC (rev 258698)
@@ -1,3 +1,18 @@
+2020-03-19 Charlie Turner <[email protected]>
+
+ Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
+ https://bugs.webkit.org/show_bug.cgi?id=209146
+
+ Reviewed by Darin Adler.
+
+ * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
+ (TestWebKitAPI::TEST):
+ * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
+ * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
+ (testDownloadMIMEType):
+ (testContextMenuDownloadActions):
+ * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
+
2020-03-19 Carlos Garcia Campos <[email protected]>
[GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp (258697 => 258698)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -1239,6 +1239,8 @@
EXPECT_DOUBLE_EQ(3.0, caFromWK.m42);
EXPECT_DOUBLE_EQ(2.0, caFromWK.m43);
EXPECT_DOUBLE_EQ(1.0, caFromWK.m44);
+#else
+ UNUSED_VARIABLE(test);
#endif
#if USE(CG)
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp (258697 => 258698)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -62,7 +62,6 @@
void setConnection(Ref<SocketConnection>&& connection)
{
- g_assert_true(connection.ptr());
m_connection = WTFMove(connection);
g_main_loop_quit(m_mainLoop.get());
}
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp (258697 => 258698)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -672,7 +672,7 @@
events.clear();
WebKitURIRequest* request = webkit_download_get_request(download.get());
- WEBKIT_IS_URI_REQUEST(request);
+ g_assert_true(WEBKIT_IS_URI_REQUEST(request));
ASSERT_CMP_CSTRING(webkit_uri_request_get_uri(request), ==, kServer->getURIForPath("/unknown"));
auto headers = webkit_uri_request_get_http_headers(request);
@@ -679,7 +679,7 @@
g_assert_nonnull(soup_message_headers_get_one(headers, "User-Agent"));
WebKitURIResponse* response = webkit_download_get_response(download.get());
- WEBKIT_IS_URI_RESPONSE(response);
+ g_assert_true(WEBKIT_IS_URI_RESPONSE(response));
g_assert_cmpstr(webkit_uri_response_get_mime_type(response), ==, "application/pdf");
g_assert_nonnull(webkit_download_get_destination(download.get()));
@@ -739,7 +739,7 @@
g_assert_true(test->m_webView == webkit_download_get_web_view(test->m_download.get()));
WebKitURIRequest* request = webkit_download_get_request(test->m_download.get());
- WEBKIT_IS_URI_REQUEST(request);
+ g_assert_true(WEBKIT_IS_URI_REQUEST(request));
ASSERT_CMP_CSTRING(webkit_uri_request_get_uri(request), ==, kServer->getURIForPath("/test.pdf"));
auto headers = webkit_uri_request_get_http_headers(request);
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp (258697 => 258698)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp 2020-03-19 14:11:32 UTC (rev 258697)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp 2020-03-19 15:17:17 UTC (rev 258698)
@@ -118,7 +118,7 @@
}
GRefPtr<WebKitPrintOperation> m_printOperation;
- unsigned m_expectedError;
+ int m_expectedError;
};
static void testPrintOperationPrint(PrintTest* test, gconstpointer)
