Title: [260579] trunk/LayoutTests
- Revision
- 260579
- Author
- [email protected]
- Date
- 2020-04-23 10:26:14 -0700 (Thu, 23 Apr 2020)
Log Message
http/tests/paymentrequest/page-cache-completed-payment-response.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207385
<rdar://problem/59260167>
Unreviewed, follow-up to r258373 to silence the error name when using shouldReject() and
actually fix the flakiness.
* http/tests/paymentrequest/page-cache-completed-payment-response.https-expected.txt:
* resources/js-test.js:
(shouldRejectWithErrorName):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (260578 => 260579)
--- trunk/LayoutTests/ChangeLog 2020-04-23 17:23:54 UTC (rev 260578)
+++ trunk/LayoutTests/ChangeLog 2020-04-23 17:26:14 UTC (rev 260579)
@@ -1,3 +1,16 @@
+2020-04-23 Chris Dumez <[email protected]>
+
+ http/tests/paymentrequest/page-cache-completed-payment-response.https.html is flaky failing.
+ https://bugs.webkit.org/show_bug.cgi?id=207385
+ <rdar://problem/59260167>
+
+ Unreviewed, follow-up to r258373 to silence the error name when using shouldReject() and
+ actually fix the flakiness.
+
+ * http/tests/paymentrequest/page-cache-completed-payment-response.https-expected.txt:
+ * resources/js-test.js:
+ (shouldRejectWithErrorName):
+
2020-04-23 Antoine Quint <[email protected]>
[ Mac iOS ] animations/animation-direction-normal.html is a flaky failure
Modified: trunk/LayoutTests/http/tests/paymentrequest/page-cache-completed-payment-response.https-expected.txt (260578 => 260579)
--- trunk/LayoutTests/http/tests/paymentrequest/page-cache-completed-payment-response.https-expected.txt 2020-04-23 17:23:54 UTC (rev 260578)
+++ trunk/LayoutTests/http/tests/paymentrequest/page-cache-completed-payment-response.https-expected.txt 2020-04-23 17:26:14 UTC (rev 260579)
@@ -9,8 +9,8 @@
pageshow - from cache
PASS Page did enter and was restored from the back/forward cache
Testing that PaymentResponse remains in the Completed state.
-PASS response.complete() rejected promise with InvalidStateError: The object is in an invalid state..
-PASS response.retry() rejected promise with InvalidStateError: The object is in an invalid state..
+PASS response.complete() rejected promise.
+PASS response.retry() rejected promise.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/resources/js-test.js (260578 => 260579)
--- trunk/LayoutTests/resources/js-test.js 2020-04-23 17:23:54 UTC (rev 260578)
+++ trunk/LayoutTests/resources/js-test.js 2020-04-23 17:26:14 UTC (rev 260579)
@@ -730,7 +730,9 @@
return _av.then(function(result) {
testFailed((_message ? _message : _a) + " should reject promise. Resolved with " + result + ".");
}, function(error) {
- if (_name === undefined || error['name'] === _name) {
+ if (_name === undefined) {
+ testPassed((_message ? _message : _a) + " rejected promise.");
+ } else if (error['name'] === _name) {
// FIXME: Remove the extra space and '.' (DOMException descriptions already end with periods) then rebase tests.
testPassed((_message ? _message : _a) + " rejected promise with " + error + ".");
} else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
