Title: [260580] trunk/Tools
- Revision
- 260580
- Author
- [email protected]
- Date
- 2020-04-23 10:36:53 -0700 (Thu, 23 Apr 2020)
Log Message
Unreviewed, reverting r260562.
https://bugs.webkit.org/show_bug.cgi?id=210924
It caused 3 new failures and 1 timeout in GTK API tests
(Requested by clopez on #webkit).
Reverted changeset:
"[GTK][WPE] White-list more GStreamer environment variables in
webkitpy"
https://bugs.webkit.org/show_bug.cgi?id=210854
https://trac.webkit.org/changeset/260562
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (260579 => 260580)
--- trunk/Tools/ChangeLog 2020-04-23 17:26:14 UTC (rev 260579)
+++ trunk/Tools/ChangeLog 2020-04-23 17:36:53 UTC (rev 260580)
@@ -1,3 +1,18 @@
+2020-04-23 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r260562.
+ https://bugs.webkit.org/show_bug.cgi?id=210924
+
+ It caused 3 new failures and 1 timeout in GTK API tests
+ (Requested by clopez on #webkit).
+
+ Reverted changeset:
+
+ "[GTK][WPE] White-list more GStreamer environment variables in
+ webkitpy"
+ https://bugs.webkit.org/show_bug.cgi?id=210854
+ https://trac.webkit.org/changeset/260562
+
2020-04-23 Sihui Liu <[email protected]>
TextManipulationController should set range of paragraph using token's positions
Modified: trunk/Tools/Scripts/webkitpy/port/gtk.py (260579 => 260580)
--- trunk/Tools/Scripts/webkitpy/port/gtk.py 2020-04-23 17:26:14 UTC (rev 260579)
+++ trunk/Tools/Scripts/webkitpy/port/gtk.py 2020-04-23 17:36:53 UTC (rev 260580)
@@ -124,10 +124,11 @@
self._copy_value_from_environ_if_set(environment, 'WEBKIT_OUTPUTDIR')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_JHBUILD')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_TOP_LEVEL')
- self._copy_value_from_environ_if_set(environment, 'WEBKIT_GST_USE_PLAYBIN3')
- for gst_variable in ('DEBUG', 'DEBUG_DUMP_DOT_DIR', 'DEBUG_FILE', 'DEBUG_NO_COLOR',
- 'PLUGIN_SCANNER', 'PLUGIN_PATH', 'PLUGIN_SYSTEM_PATH', 'REGISTRY'):
- self._copy_value_from_environ_if_set(environment, 'GST_%s' % gst_variable)
+ self._copy_value_from_environ_if_set(environment, 'USE_PLAYBIN3')
+ self._copy_value_from_environ_if_set(environment, 'GST_DEBUG')
+ self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_DUMP_DOT_DIR')
+ self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_FILE')
+ self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_NO_COLOR')
# Configure the software libgl renderer if jhbuild ready and we test inside a virtualized window system
if self._driver_class() in [XvfbDriver, WestonDriver] and (self._should_use_jhbuild() or self._is_flatpak()):
Modified: trunk/Tools/Scripts/webkitpy/port/wpe.py (260579 => 260580)
--- trunk/Tools/Scripts/webkitpy/port/wpe.py 2020-04-23 17:26:14 UTC (rev 260579)
+++ trunk/Tools/Scripts/webkitpy/port/wpe.py 2020-04-23 17:36:53 UTC (rev 260580)
@@ -79,12 +79,13 @@
self._copy_value_from_environ_if_set(environment, 'WEBKIT_OUTPUTDIR')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_JHBUILD')
self._copy_value_from_environ_if_set(environment, 'WEBKIT_TOP_LEVEL')
+ self._copy_value_from_environ_if_set(environment, 'USE_PLAYBIN3')
+ self._copy_value_from_environ_if_set(environment, 'GST_DEBUG')
+ self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_DUMP_DOT_DIR')
+ self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_FILE')
+ self._copy_value_from_environ_if_set(environment, 'GST_DEBUG_NO_COLOR')
self._copy_value_from_environ_if_set(environment, 'LIBGL_ALWAYS_SOFTWARE')
self._copy_value_from_environ_if_set(environment, 'XR_RUNTIME_JSON')
- self._copy_value_from_environ_if_set(environment, 'WEBKIT_GST_USE_PLAYBIN3')
- for gst_variable in ('DEBUG', 'DEBUG_DUMP_DOT_DIR', 'DEBUG_FILE', 'DEBUG_NO_COLOR',
- 'PLUGIN_SCANNER', 'PLUGIN_PATH', 'PLUGIN_SYSTEM_PATH', 'REGISTRY'):
- self._copy_value_from_environ_if_set(environment, 'GST_%s' % gst_variable)
return environment
def show_results_html_file(self, results_filename):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
