Title: [260619] trunk
Revision
260619
Author
[email protected]
Date
2020-04-23 21:52:59 -0700 (Thu, 23 Apr 2020)

Log Message

Make JSCOnly work on macOS
https://bugs.webkit.org/show_bug.cgi?id=210953

Reviewed by Ross Kirsling.

In JSCOnly port on macOS, we should disable ICU API renaming because OS shipped ICU does not have version suffix.

* Source/cmake/OptionsJSCOnly.cmake:

Modified Paths

Diff

Modified: trunk/ChangeLog (260618 => 260619)


--- trunk/ChangeLog	2020-04-24 04:46:07 UTC (rev 260618)
+++ trunk/ChangeLog	2020-04-24 04:52:59 UTC (rev 260619)
@@ -1,3 +1,14 @@
+2020-04-23  Yusuke Suzuki  <[email protected]>
+
+        Make JSCOnly work on macOS
+        https://bugs.webkit.org/show_bug.cgi?id=210953
+
+        Reviewed by Ross Kirsling.
+
+        In JSCOnly port on macOS, we should disable ICU API renaming because OS shipped ICU does not have version suffix.
+
+        * Source/cmake/OptionsJSCOnly.cmake:
+
 2020-04-22  Darin Adler  <[email protected]>
 
         [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK

Modified: trunk/Source/cmake/OptionsJSCOnly.cmake (260618 => 260619)


--- trunk/Source/cmake/OptionsJSCOnly.cmake	2020-04-24 04:46:07 UTC (rev 260618)
+++ trunk/Source/cmake/OptionsJSCOnly.cmake	2020-04-24 04:52:59 UTC (rev 260619)
@@ -96,3 +96,6 @@
 endif ()
 
 find_package(ICU 60.2 REQUIRED COMPONENTS data i18n uc)
+if (APPLE)
+    add_definitions(-DU_DISABLE_RENAMING=1)
+endif ()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to