Title: [260620] trunk/Tools
Revision
260620
Author
[email protected]
Date
2020-04-23 22:14:22 -0700 (Thu, 23 Apr 2020)

Log Message

stress/ensure-crash.js shouldn't spew stuff onto my screen
https://bugs.webkit.org/show_bug.cgi?id=210931

Reviewed by Ross Kirsling.

Set noisyOutputHandler when crash! is specified. We also specify noisyOutputHandler for runComplexTest.

* Scripts/run-jsc-stress-tests:
* Scripts/webkitruby/jsc-stress-test-writer-default.rb:
* Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
* Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (260619 => 260620)


--- trunk/Tools/ChangeLog	2020-04-24 04:52:59 UTC (rev 260619)
+++ trunk/Tools/ChangeLog	2020-04-24 05:14:22 UTC (rev 260620)
@@ -1,5 +1,19 @@
 2020-04-23  Yusuke Suzuki  <[email protected]>
 
+        stress/ensure-crash.js shouldn't spew stuff onto my screen
+        https://bugs.webkit.org/show_bug.cgi?id=210931
+
+        Reviewed by Ross Kirsling.
+
+        Set noisyOutputHandler when crash! is specified. We also specify noisyOutputHandler for runComplexTest.
+
+        * Scripts/run-jsc-stress-tests:
+        * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
+        * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
+        * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
+
+2020-04-23  Yusuke Suzuki  <[email protected]>
+
         Disable useKernTCSM=false for JSC stress tests to make EWS faster
         https://bugs.webkit.org/show_bug.cgi?id=210950
 

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (260619 => 260620)


--- trunk/Tools/Scripts/run-jsc-stress-tests	2020-04-24 04:52:59 UTC (rev 260619)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2020-04-24 05:14:22 UTC (rev 260620)
@@ -1431,7 +1431,7 @@
     prepareExtraRelativeFiles(before.map{|v| (Pathname("..") + v).to_s}, $collection)
     prepareExtraRelativeFiles(after.map{|v| (Pathname("..") + v).to_s}, $collection)
     args = [pathToVM.to_s] + BASE_OPTIONS + $testSpecificRequiredOptions + options + before.map{|v| v.to_s} + [$benchmark.to_s] + after.map{|v| v.to_s}
-    addRunCommand("complex", args, silentOutputHandler, simpleErrorHandler, *additionalEnv)
+    addRunCommand("complex", args, noisyOutputHandler, simpleErrorHandler, *additionalEnv)
 end
 
 def runMozillaTest(kind, mode, extraFiles, *options)

Modified: trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb (260619 => 260620)


--- trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb	2020-04-24 04:52:59 UTC (rev 260619)
+++ trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb	2020-04-24 05:14:22 UTC (rev 260620)
@@ -227,6 +227,9 @@
         @errorHandler = errorHandler
         @isSlow = !!$runCommandOptions[:isSlow]
         @shouldCrash = !!$runCommandOptions[:shouldCrash]
+        if @shouldCrash
+            @outputHandler = noisyOutputHandler
+        end
         @additionalEnv = []
     end
     

Modified: trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb (260619 => 260620)


--- trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb	2020-04-24 04:52:59 UTC (rev 260619)
+++ trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-playstation.rb	2020-04-24 05:14:22 UTC (rev 260620)
@@ -273,6 +273,9 @@
         @errorHandler = errorHandler
         @isSlow = !!$runCommandOptions[:isSlow]
         @shouldCrash = !!$runCommandOptions[:shouldCrash]
+        if @shouldCrash
+            @outputHandler = noisyOutputHandler
+        end
         @additionalEnv = []
     end
 

Modified: trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb (260619 => 260620)


--- trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb	2020-04-24 04:52:59 UTC (rev 260619)
+++ trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-ruby.rb	2020-04-24 05:14:22 UTC (rev 260620)
@@ -273,6 +273,9 @@
         @errorHandler = errorHandler
         @isSlow = !!$runCommandOptions[:isSlow]
         @shouldCrash = !!$runCommandOptions[:shouldCrash]
+        if @shouldCrash
+            @outputHandler = noisyOutputHandler
+        end
         @additionalEnv = []
     end
     
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to