Title: [260674] trunk/Source/_javascript_Core
- Revision
- 260674
- Author
- [email protected]
- Date
- 2020-04-24 14:53:50 -0700 (Fri, 24 Apr 2020)
Log Message
[JSC] Fix DataFormatJSBigInt32 missing part
https://bugs.webkit.org/show_bug.cgi?id=210986
Reviewed by Mark Lam.
Add missing part of DataFormatJSBigInt32 implementation.
* bytecode/DataFormat.h:
(JSC::dataFormatToString):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (260673 => 260674)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-24 21:51:12 UTC (rev 260673)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-24 21:53:50 UTC (rev 260674)
@@ -1,5 +1,19 @@
2020-04-24 Yusuke Suzuki <[email protected]>
+ [JSC] Fix DataFormatJSBigInt32 missing part
+ https://bugs.webkit.org/show_bug.cgi?id=210986
+
+ Reviewed by Mark Lam.
+
+ Add missing part of DataFormatJSBigInt32 implementation.
+
+ * bytecode/DataFormat.h:
+ (JSC::dataFormatToString):
+ * dfg/DFGSpeculativeJIT.cpp:
+ (JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
+
+2020-04-24 Yusuke Suzuki <[email protected]>
+
Unreviewed, build fix in Windows
https://bugs.webkit.org/show_bug.cgi?id=210892
Modified: trunk/Source/_javascript_Core/bytecode/DataFormat.h (260673 => 260674)
--- trunk/Source/_javascript_Core/bytecode/DataFormat.h 2020-04-24 21:51:12 UTC (rev 260673)
+++ trunk/Source/_javascript_Core/bytecode/DataFormat.h 2020-04-24 21:53:50 UTC (rev 260674)
@@ -44,7 +44,7 @@
DataFormatBoolean = 5,
DataFormatCell = 6,
DataFormatStorage = 7,
- DataFormatBigInt32 = 8, // FIXME: currently unused
+ DataFormatBigInt32 = 8, // FIXME: https://bugs.webkit.org/show_bug.cgi?id=210957 Actually support BigInt32 DataFormat.
DataFormatJS = 16,
DataFormatJSInt32 = DataFormatJS | DataFormatInt32,
DataFormatJSDouble = DataFormatJS | DataFormatDouble,
@@ -78,6 +78,8 @@
return "Boolean";
case DataFormatStorage:
return "Storage";
+ case DataFormatBigInt32:
+ return "BigInt32";
case DataFormatJS:
return "JS";
case DataFormatJSInt32:
@@ -88,6 +90,8 @@
return "JSCell";
case DataFormatJSBoolean:
return "JSBoolean";
+ case DataFormatJSBigInt32:
+ return "JSBigInt32";
case DataFormatDead:
return "Dead";
default:
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (260673 => 260674)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2020-04-24 21:51:12 UTC (rev 260673)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2020-04-24 21:53:50 UTC (rev 260674)
@@ -2335,6 +2335,7 @@
case DataFormatJS:
case DataFormatJSBoolean:
case DataFormatJSDouble:
+ case DataFormatJSBigInt32:
return GeneratedOperandJSValue;
case DataFormatJSInt32:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
