Title: [260675] trunk/Tools
Revision
260675
Author
[email protected]
Date
2020-04-24 15:29:43 -0700 (Fri, 24 Apr 2020)

Log Message

[iOS] Always run WKTR's WKWebViews at foreground priority
https://bugs.webkit.org/show_bug.cgi?id=210991

Reviewed by Keith Miller.

Always run WKTR's WKWebViews at foreground priority. This makes sure that they don't suspend and
run at foreground priority on iOS, even if those views are not visible on screen.
This is an issue to address flakiness on the bots.

* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (260674 => 260675)


--- trunk/Tools/ChangeLog	2020-04-24 21:53:50 UTC (rev 260674)
+++ trunk/Tools/ChangeLog	2020-04-24 22:29:43 UTC (rev 260675)
@@ -1,3 +1,17 @@
+2020-04-24  Chris Dumez  <[email protected]>
+
+        [iOS] Always run WKTR's WKWebViews at foreground priority
+        https://bugs.webkit.org/show_bug.cgi?id=210991
+
+        Reviewed by Keith Miller.
+
+        Always run WKTR's WKWebViews at foreground priority. This makes sure that they don't suspend and
+        run at foreground priority on iOS, even if those views are not visible on screen.
+        This is an issue to address flakiness on the bots.
+
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::initializeWebViewConfiguration):
+
 2020-04-24  Kate Cheney  <[email protected]>
 
         Removing website data for a domain should delete corresponding ITP entry

Modified: trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm (260674 => 260675)


--- trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm	2020-04-24 21:53:50 UTC (rev 260674)
+++ trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm	2020-04-24 22:29:43 UTC (rev 260675)
@@ -86,6 +86,9 @@
     globalWebViewConfiguration._invisibleAutoplayNotPermitted = NO;
     globalWebViewConfiguration._mediaDataLoadsAutomatically = YES;
     globalWebViewConfiguration.requiresUserActionForMediaPlayback = NO;
+
+    // Make sure the view does not get suspended and runs at foreground priority, even if not visible on screen.
+    globalWebViewConfiguration._alwaysRunsAtForegroundPriority = YES;
 #endif
     globalWebViewConfiguration.mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeNone;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to