Title: [260676] trunk/Source
Revision
260676
Author
[email protected]
Date
2020-04-24 15:41:38 -0700 (Fri, 24 Apr 2020)

Log Message

Make LEGACY_PDF_SUPPORT feature flag.
https://bugs.webkit.org/show_bug.cgi?id=210868
<rdar://problem/62199847>

Reviewed by Tim Horton.

Source/WebKitLegacy/mac:

* WebView/WebFrameView.mm:
(+[WebFrameView _viewTypesAllowImageTypeOmission:]):
* WebView/WebView.mm:

Source/WTF:

* wtf/PlatformHave.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (260675 => 260676)


--- trunk/Source/WTF/ChangeLog	2020-04-24 22:29:43 UTC (rev 260675)
+++ trunk/Source/WTF/ChangeLog	2020-04-24 22:41:38 UTC (rev 260676)
@@ -1,3 +1,13 @@
+2020-04-24  Megan Gardner  <[email protected]>
+
+        Make LEGACY_PDF_SUPPORT feature flag.
+        https://bugs.webkit.org/show_bug.cgi?id=210868
+        <rdar://problem/62199847>
+
+        Reviewed by Tim Horton.
+
+        * wtf/PlatformHave.h:
+
 2020-04-24  Youenn Fablet  <[email protected]> and Luming Yin <[email protected]>
 
         Call STDynamicActivityAttributionPublisher in the WebProcess

Modified: trunk/Source/WTF/wtf/PlatformHave.h (260675 => 260676)


--- trunk/Source/WTF/wtf/PlatformHave.h	2020-04-24 22:29:43 UTC (rev 260675)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2020-04-24 22:41:38 UTC (rev 260676)
@@ -637,6 +637,10 @@
 #define HAVE_SYSTEM_FEATURE_FLAGS 1
 #endif
 
+#if PLATFORM(IOS_FAMILY) || PLATFORM(MAC)
+#define HAVE_LEGACY_PDF_SUPPORT 1
+#endif
+
 #if PLATFORM(IOS)
 #define HAVE_AVOBSERVATIONCONTROLLER 1
 #endif

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (260675 => 260676)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2020-04-24 22:29:43 UTC (rev 260675)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2020-04-24 22:41:38 UTC (rev 260676)
@@ -1,3 +1,15 @@
+2020-04-24  Megan Gardner  <[email protected]>
+
+        Make LEGACY_PDF_SUPPORT feature flag.
+        https://bugs.webkit.org/show_bug.cgi?id=210868
+        <rdar://problem/62199847>
+
+        Reviewed by Tim Horton.
+
+        * WebView/WebFrameView.mm:
+        (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
+        * WebView/WebView.mm:
+
 2020-04-24  Antoine Quint  <[email protected]>
 
         Update the css/css-animations WPT tests

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebFrameView.mm (260675 => 260676)


--- trunk/Source/WebKitLegacy/mac/WebView/WebFrameView.mm	2020-04-24 22:29:43 UTC (rev 260675)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebFrameView.mm	2020-04-24 22:41:38 UTC (rev 260676)
@@ -262,7 +262,7 @@
 #if PLATFORM(IOS_FAMILY)
 #define WebPDFView ([WebView _getPDFViewClass])
 #endif
-#if !PLATFORM(MACCATALYST)
+#if HAVE(LEGACY_PDF_SUPPORT)
             addTypesFromClass(viewTypes, [WebPDFView class], [WebPDFView supportedMIMETypes]);
 #endif
 #if PLATFORM(IOS_FAMILY)

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (260675 => 260676)


--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2020-04-24 22:29:43 UTC (rev 260675)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2020-04-24 22:41:38 UTC (rev 260676)
@@ -2069,7 +2069,7 @@
 #if PLATFORM(IOS_FAMILY)
 #define WebPDFView ([WebView _getPDFViewClass])
 #endif
-#if PLATFORM(MACCATALYST)
+#if !HAVE(LEGACY_PDF_SUPPORT)
     if (!viewClass || !repClass) {
 #else
     if (!viewClass || !repClass || [[WebPDFView supportedMIMETypes] containsObject:MIMEType]) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to