Title: [262509] trunk/Tools
- Revision
- 262509
- Author
- [email protected]
- Date
- 2020-06-03 12:47:48 -0700 (Wed, 03 Jun 2020)
Log Message
[iOS] TestWTF.WTF_Lock.ContendedShortSection is consistently timing out on debug simulator builds
https://bugs.webkit.org/show_bug.cgi?id=211650
Reviewed by Saam Barati.
The prior change to disable this test for Debug actually enabled it
only for Debug IOS builds of any type, simulator or real HW.
This test has intermittently failed or timed out on Debug simulator
builds for for almost a year. We want to test Release builds as well as
hardware builds. Therefore we should disable Debug simulator builds,
and test all other variants.
* TestWebKitAPI/Tests/WTF/Lock.cpp:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (262508 => 262509)
--- trunk/Tools/ChangeLog 2020-06-03 19:45:55 UTC (rev 262508)
+++ trunk/Tools/ChangeLog 2020-06-03 19:47:48 UTC (rev 262509)
@@ -1,3 +1,20 @@
+2020-06-03 Michael Saboff <[email protected]>
+
+ [iOS] TestWTF.WTF_Lock.ContendedShortSection is consistently timing out on debug simulator builds
+ https://bugs.webkit.org/show_bug.cgi?id=211650
+
+ Reviewed by Saam Barati.
+
+ The prior change to disable this test for Debug actually enabled it
+ only for Debug IOS builds of any type, simulator or real HW.
+
+ This test has intermittently failed or timed out on Debug simulator
+ builds for for almost a year. We want to test Release builds as well as
+ hardware builds. Therefore we should disable Debug simulator builds,
+ and test all other variants.
+
+ * TestWebKitAPI/Tests/WTF/Lock.cpp:
+
2020-06-03 Wenson Hsieh <[email protected]>
dataTransfer.types is empty when handling the "dragstart" event
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp (262508 => 262509)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp 2020-06-03 19:45:55 UTC (rev 262508)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp 2020-06-03 19:47:48 UTC (rev 262509)
@@ -143,8 +143,7 @@
runLockTest<Lock>(1, 1, 10000, 1000);
}
-// FIXME: Re-enable this test for iOS Debug once webkit.org/b/211650 is resolved
-#if PLATFORM(IOS) && !defined(NDEBUG)
+#if !PLATFORM(IOS_SIMULATOR) || defined(NDEBUG)
TEST(WTF_Lock, ContendedShortSection)
{
if (skipSlow())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
