Title: [262510] trunk/Source/_javascript_Core
- Revision
- 262510
- Author
- mark....@apple.com
- Date
- 2020-06-03 12:55:31 -0700 (Wed, 03 Jun 2020)
Log Message
DFGSSAConversionPhase.cpp needs to #include OperandsInlines.h.
https://bugs.webkit.org/show_bug.cgi?id=212687
Reviewed by Keith Miller.
Without this, strange build failures can happen with unified builds.
For example, the Windows build started failing due a linkage error in this file
when the patch from https://bugs.webkit.org/show_bug.cgi?id=212680 landed.
212680 introduced a new .cpp file, and that probably bumped DFGSSAConversionPhase.cpp
into another unified unit, thereby depriving it from seeing the OperandsInlines.h
#include'd by another .cpp.
* dfg/DFGSSAConversionPhase.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (262509 => 262510)
--- trunk/Source/_javascript_Core/ChangeLog 2020-06-03 19:47:48 UTC (rev 262509)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-06-03 19:55:31 UTC (rev 262510)
@@ -1,5 +1,22 @@
2020-06-03 Mark Lam <mark....@apple.com>
+ DFGSSAConversionPhase.cpp needs to #include OperandsInlines.h.
+ https://bugs.webkit.org/show_bug.cgi?id=212687
+
+ Reviewed by Keith Miller.
+
+ Without this, strange build failures can happen with unified builds.
+
+ For example, the Windows build started failing due a linkage error in this file
+ when the patch from https://bugs.webkit.org/show_bug.cgi?id=212680 landed.
+ 212680 introduced a new .cpp file, and that probably bumped DFGSSAConversionPhase.cpp
+ into another unified unit, thereby depriving it from seeing the OperandsInlines.h
+ #include'd by another .cpp.
+
+ * dfg/DFGSSAConversionPhase.cpp:
+
+2020-06-03 Mark Lam <mark....@apple.com>
+
Fix non-unified --jsc-only build.
https://bugs.webkit.org/show_bug.cgi?id=212707
Modified: trunk/Source/_javascript_Core/dfg/DFGSSAConversionPhase.cpp (262509 => 262510)
--- trunk/Source/_javascript_Core/dfg/DFGSSAConversionPhase.cpp 2020-06-03 19:47:48 UTC (rev 262509)
+++ trunk/Source/_javascript_Core/dfg/DFGSSAConversionPhase.cpp 2020-06-03 19:55:31 UTC (rev 262510)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2013-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2020 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -36,6 +36,7 @@
#include "DFGSSACalculator.h"
#include "DFGVariableAccessDataDump.h"
#include "JSCJSValueInlines.h"
+#include "OperandsInlines.h"
#undef RELEASE_ASSERT
#define RELEASE_ASSERT(assertion) do { \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
