Title: [262569] branches/safari-609-branch/Source/WebCore
Revision
262569
Author
[email protected]
Date
2020-06-04 14:07:36 -0700 (Thu, 04 Jun 2020)

Log Message

Cherry-pick r260142. rdar://problem/63993130

    REGRESSION (r258977): Crash under Document::visibilityStateChanged
    https://bugs.webkit.org/show_bug.cgi?id=210555

    Reviewed by Youenn Fablet.

    Re-introduce null check of page in Document::visibilityStateChanged() which got inadvertently
    dropped in r258977.

    * dom/Document.cpp:
    (WebCore::Document::visibilityStateChanged):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-609-branch/Source/WebCore/ChangeLog (262568 => 262569)


--- branches/safari-609-branch/Source/WebCore/ChangeLog	2020-06-04 21:01:26 UTC (rev 262568)
+++ branches/safari-609-branch/Source/WebCore/ChangeLog	2020-06-04 21:07:36 UTC (rev 262569)
@@ -1,3 +1,34 @@
+2020-06-04  Alan Coon  <[email protected]>
+
+        Cherry-pick r260142. rdar://problem/63993130
+
+    REGRESSION (r258977): Crash under Document::visibilityStateChanged
+    https://bugs.webkit.org/show_bug.cgi?id=210555
+    
+    Reviewed by Youenn Fablet.
+    
+    Re-introduce null check of page in Document::visibilityStateChanged() which got inadvertently
+    dropped in r258977.
+    
+    * dom/Document.cpp:
+    (WebCore::Document::visibilityStateChanged):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@260142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-04-15  Chris Dumez  <[email protected]>
+
+            REGRESSION (r258977): Crash under Document::visibilityStateChanged
+            https://bugs.webkit.org/show_bug.cgi?id=210555
+
+            Reviewed by Youenn Fablet.
+
+            Re-introduce null check of page in Document::visibilityStateChanged() which got inadvertently
+            dropped in r258977.
+
+            * dom/Document.cpp:
+            (WebCore::Document::visibilityStateChanged):
+
 2020-06-02  Andy Estes  <[email protected]>
 
         Apply patch. rdar://problem/63626670

Modified: branches/safari-609-branch/Source/WebCore/dom/Document.cpp (262568 => 262569)


--- branches/safari-609-branch/Source/WebCore/dom/Document.cpp	2020-06-04 21:01:26 UTC (rev 262568)
+++ branches/safari-609-branch/Source/WebCore/dom/Document.cpp	2020-06-04 21:07:36 UTC (rev 262569)
@@ -1730,8 +1730,9 @@
         client->visibilityStateChanged();
 
 #if ENABLE(MEDIA_STREAM)
-    if (hidden()) {
-        RealtimeMediaSourceCenter::singleton().setCapturePageState(hidden(), page()->isMediaCaptureMuted());
+    auto* page = this->page();
+    if (page && hidden()) {
+        RealtimeMediaSourceCenter::singleton().setCapturePageState(true, page->isMediaCaptureMuted());
         return;
     }
 #if PLATFORM(IOS_FAMILY)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to