Title: [262571] trunk/Source
- Revision
- 262571
- Author
- [email protected]
- Date
- 2020-06-04 14:30:32 -0700 (Thu, 04 Jun 2020)
Log Message
Unreviewed, reverting r262546.
This commit caused internal build failures
Reverted changeset:
"[Cocoa] Adopt read-only mode for preferences in the
WebContent process"
https://bugs.webkit.org/show_bug.cgi?id=212411
https://trac.webkit.org/changeset/262546
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (262570 => 262571)
--- trunk/Source/WTF/ChangeLog 2020-06-04 21:07:42 UTC (rev 262570)
+++ trunk/Source/WTF/ChangeLog 2020-06-04 21:30:32 UTC (rev 262571)
@@ -1,3 +1,16 @@
+2020-06-04 Jacob Uphoff <[email protected]>
+
+ Unreviewed, reverting r262546.
+
+ This commit caused internal build failures
+
+ Reverted changeset:
+
+ "[Cocoa] Adopt read-only mode for preferences in the
+ WebContent process"
+ https://bugs.webkit.org/show_bug.cgi?id=212411
+ https://trac.webkit.org/changeset/262546
+
2020-06-04 Per Arne Vollan <[email protected]>
[Cocoa] Adopt read-only mode for preferences in the WebContent process
Modified: trunk/Source/WTF/wtf/PlatformHave.h (262570 => 262571)
--- trunk/Source/WTF/wtf/PlatformHave.h 2020-06-04 21:07:42 UTC (rev 262570)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2020-06-04 21:30:32 UTC (rev 262571)
@@ -641,10 +641,3 @@
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000)
#define HAVE_LOGGING_PRIVACY_LEVEL 1
#endif
-
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600) \
- || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \
- || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 70000) \
- || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 140000)
-#define HAVE_CFPREFS_READONLY_SPI 1
-#endif
Modified: trunk/Source/WebCore/PAL/ChangeLog (262570 => 262571)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-06-04 21:07:42 UTC (rev 262570)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-06-04 21:30:32 UTC (rev 262571)
@@ -1,3 +1,16 @@
+2020-06-04 Jacob Uphoff <[email protected]>
+
+ Unreviewed, reverting r262546.
+
+ This commit caused internal build failures
+
+ Reverted changeset:
+
+ "[Cocoa] Adopt read-only mode for preferences in the
+ WebContent process"
+ https://bugs.webkit.org/show_bug.cgi?id=212411
+ https://trac.webkit.org/changeset/262546
+
2020-06-04 Per Arne Vollan <[email protected]>
[Cocoa] Adopt read-only mode for preferences in the WebContent process
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h (262570 => 262571)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h 2020-06-04 21:07:42 UTC (rev 262570)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFUtilitiesSPI.h 2020-06-04 21:30:32 UTC (rev 262571)
@@ -59,6 +59,5 @@
void __CFRunLoopSetOptionsReason(__CFRunLoopOptions opts, CFStringRef reason);
void _CFPrefsSetDirectModeEnabled(bool enabled);
-void _CFPrefsSetReadOnly(bool flag);
WTF_EXTERN_C_END
Modified: trunk/Source/WebKit/ChangeLog (262570 => 262571)
--- trunk/Source/WebKit/ChangeLog 2020-06-04 21:07:42 UTC (rev 262570)
+++ trunk/Source/WebKit/ChangeLog 2020-06-04 21:30:32 UTC (rev 262571)
@@ -1,3 +1,16 @@
+2020-06-04 Jacob Uphoff <[email protected]>
+
+ Unreviewed, reverting r262546.
+
+ This commit caused internal build failures
+
+ Reverted changeset:
+
+ "[Cocoa] Adopt read-only mode for preferences in the
+ WebContent process"
+ https://bugs.webkit.org/show_bug.cgi?id=212411
+ https://trac.webkit.org/changeset/262546
+
2020-06-04 Chris Dumez <[email protected]>
[iOS] Drop DependentProcessLink ProcessAssertion as it creates power leaks
Modified: trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm (262570 => 262571)
--- trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm 2020-06-04 21:07:42 UTC (rev 262570)
+++ trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm 2020-06-04 21:30:32 UTC (rev 262571)
@@ -122,9 +122,6 @@
if (argc >= 1 && argv[0] && strstr(argv[0], "com.apple.WebKit.WebContent")) {
// Enable CFPrefs direct mode to avoid unsuccessfully attempting to connect to the daemon and getting blocked by the sandbox.
_CFPrefsSetDirectModeEnabled(YES);
-#if HAVE(CFPREFS_READONLY_SPI)
- _CFPrefsSetReadOnly(YES);
-#endif
}
#else
UNUSED_PARAM(argc);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
