Title: [262572] trunk/Source/WebKit
- Revision
- 262572
- Author
- bfulg...@apple.com
- Date
- 2020-06-04 14:31:00 -0700 (Thu, 04 Jun 2020)
Log Message
Reduce telemetry and report generation for Network Process sandbox
https://bugs.webkit.org/show_bug.cgi?id=212778
<rdar://problem/63891745>
Reviewed by Per Arne Vollan.
This patch cleans up a set of telemetry and reports generated during normal
WebKit operation. Now that we understand the uses of these XPC services, we
can reduce the logging traffic.
This is important to do now, since telemetry and report generation has
battery life and performance impact.
* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (262571 => 262572)
--- trunk/Source/WebKit/ChangeLog 2020-06-04 21:30:32 UTC (rev 262571)
+++ trunk/Source/WebKit/ChangeLog 2020-06-04 21:31:00 UTC (rev 262572)
@@ -1,3 +1,21 @@
+2020-06-04 Brent Fulgham <bfulg...@apple.com>
+
+ Reduce telemetry and report generation for Network Process sandbox
+ https://bugs.webkit.org/show_bug.cgi?id=212778
+ <rdar://problem/63891745>
+
+ Reviewed by Per Arne Vollan.
+
+ This patch cleans up a set of telemetry and reports generated during normal
+ WebKit operation. Now that we understand the uses of these XPC services, we
+ can reduce the logging traffic.
+
+ This is important to do now, since telemetry and report generation has
+ battery life and performance impact.
+
+ * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+ * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+
2020-06-04 Jacob Uphoff <jacob_uph...@apple.com>
Unreviewed, reverting r262546.
Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (262571 => 262572)
--- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2020-06-04 21:30:32 UTC (rev 262571)
+++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2020-06-04 21:31:00 UTC (rev 262572)
@@ -110,7 +110,6 @@
(ipc-posix-name-prefix "apple.cfprefs."))
(allow mach-lookup (with report) (with telemetry)
- (global-name "com.apple.analyticsd")
(global-name "com.apple.analyticsd.messagetracer")
(global-name "com.apple.appsleep")
(global-name "com.apple.bsd.dirhelper")
@@ -117,8 +116,6 @@
(global-name "com.apple.cfprefsd.agent")
(global-name "com.apple.cfprefsd.daemon")
(global-name "com.apple.espd")
- (global-name "com.apple.logd")
- (global-name "com.apple.logd.events")
(global-name "com.apple.secinitd")
(global-name "com.apple.system.DirectoryService.libinfo_v1")
(global-name "com.apple.system.logger")
@@ -304,6 +301,8 @@
(global-name "com.apple.cfnetwork.cfnetworkagent")
(global-name "com.apple.diagnosticd")
(global-name "com.apple.ist.ds.appleconnect2.service.kdctunnelcontroller")
+ (global-name "com.apple.logd")
+ (global-name "com.apple.logd.events")
(global-name "com.apple.lsd.mapdb")
(global-name "com.apple.nesessionmanager.flow-divert-token")
(global-name "com.apple.nesessionmanager.content-filter") ;; <rdar://problem/47598758>
Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (262571 => 262572)
--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb 2020-06-04 21:30:32 UTC (rev 262571)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb 2020-06-04 21:31:00 UTC (rev 262572)
@@ -409,7 +409,7 @@
required-etc-files
(literal "/"))
-(allow mach-lookup (with report) (with telemetry)
+(allow mach-lookup
(global-name "com.apple.logd")
(global-name "com.apple.logd.events"))
@@ -418,7 +418,7 @@
(local-name "com.apple.cfprefsd.agent")
)
-(allow mach-lookup (with telemetry)
+(allow mach-lookup
(global-name "com.apple.cfprefsd.daemon") ;; Needed by _CFPreferencesGetAppBooleanValueWithContainer and others.
)
@@ -425,7 +425,7 @@
(allow ipc-posix-shm-read*
(ipc-posix-name-prefix "apple.cfprefs."))
-(allow mach-lookup (with telemetry)
+(allow mach-lookup
(global-name "com.apple.runningboard")) ;; Needed by process assertion code (ProcessTaskStateObserver).
(allow-multi-instance-xpc-services)
@@ -536,9 +536,6 @@
(allow process-info-rusage (target self))
(allow process-info-codesignature (target self))
-(allow mach-lookup (with report) (with telemetry)
- (global-name "com.apple.analyticsd"))
-
;;;
;;; End rules originally copied from 'common.sb'
;;;
@@ -610,7 +607,7 @@
(global-name "com.apple.securityd"))
;; PassKit framework
-(allow mach-lookup (with report) (with telemetry)
+(allow mach-lookup
(global-name "com.apple.passd.in-app-payment")
(global-name "com.apple.passd.library"))
@@ -635,10 +632,9 @@
(remote tcp "localhost:62078"))
;; Various services required by system frameworks
-(allow mach-lookup (with report) (with telemetry)
+(allow mach-lookup
(global-name "com.apple.lsd.mapdb")
- (global-name "com.apple.analyticsd")
- (global-name "com.apple.AppSSO.service-xpc"))
+ (global-name "com.apple.analyticsd"))
;; For reporting progress for active downloads <rdar://problem/44405661>
(allow mach-lookup (with report) (with telemetry)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
