Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (263931 => 263932)
--- trunk/Source/_javascript_Core/ChangeLog 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-07-04 13:32:03 UTC (rev 263932)
@@ -1,3 +1,12 @@
+2020-07-04 Darin Adler <[email protected]>
+
+ Update comment in FeatureDefines.xcconfig since PlatformEnableCocoa.h should be used instead
+ https://bugs.webkit.org/show_bug.cgi?id=213952
+
+ Reviewed by Sam Weinig.
+
+ * Configurations/FeatureDefines.xcconfig: Updated comment.
+
2020-07-03 Yusuke Suzuki <[email protected]>
[JSC] Promise should check whether a user-provided function is set by using `@isUndefinedOrNull`
Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (263931 => 263932)
--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2020-07-04 13:32:03 UTC (rev 263932)
@@ -22,15 +22,25 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// The contents of this file must be kept in sync with FeatureDefines.xcconfig in _javascript_Core,
-// WebCore, WebKitLegacy and WebKit. Also the default values of the ENABLE_FEATURE_NAME macros in
-// build-webkit should match the values below, but they do not need to be in the same order.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
-// Keep this list of features (not enabled/disabled state) in sync with FeatureDefines.props
-// and FeatureDefinesCairo.props in Source/cmake/tools/vsprops.
+// This file is an obsolete mechanism for setting ENABLE flags for WebKit
+// features on the Cocoa platforms. Instead of adding to this file:
+//
+// 1) If the feature is on by default across most platforms, add code to
+// turn it on in PlatformEnable.h.
+// 2) If the feature is not on by default, but on for Cocoa platforms,
+// add code to turn it on in PlatformEnableCocoa.h.
+// 3) If the feature is on by default, but needs to be off for Cocoa
+// platforms, add code to turn it off in PlatformEnableCocoa.h.
+// 4) If the feature is sometimes on for Cocoa platforms, put the code
+// to make that decision in PlatformEnableCocoa.h.
-// Set any ENABLE_FEATURE_NAME macro to an empty string to disable that feature.
+// Everything currently in this file is going to be removed as soon as
+// possible.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
+
#include "WebKitTargetConditionals.xcconfig"
ENABLE_3D_TRANSFORMS = ENABLE_3D_TRANSFORMS;
Modified: trunk/Source/WebCore/ChangeLog (263931 => 263932)
--- trunk/Source/WebCore/ChangeLog 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/WebCore/ChangeLog 2020-07-04 13:32:03 UTC (rev 263932)
@@ -1,3 +1,12 @@
+2020-07-04 Darin Adler <[email protected]>
+
+ Update comment in FeatureDefines.xcconfig since PlatformEnableCocoa.h should be used instead
+ https://bugs.webkit.org/show_bug.cgi?id=213952
+
+ Reviewed by Sam Weinig.
+
+ * Configurations/FeatureDefines.xcconfig: Updated comment.
+
2020-07-04 Youenn Fablet <[email protected]>
Enable VTB required low latency code path
Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (263931 => 263932)
--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2020-07-04 13:32:03 UTC (rev 263932)
@@ -22,15 +22,25 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// The contents of this file must be kept in sync with FeatureDefines.xcconfig in _javascript_Core,
-// WebCore, WebKitLegacy and WebKit. Also the default values of the ENABLE_FEATURE_NAME macros in
-// build-webkit should match the values below, but they do not need to be in the same order.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
-// Keep this list of features (not enabled/disabled state) in sync with FeatureDefines.props
-// and FeatureDefinesCairo.props in Source/cmake/tools/vsprops.
+// This file is an obsolete mechanism for setting ENABLE flags for WebKit
+// features on the Cocoa platforms. Instead of adding to this file:
+//
+// 1) If the feature is on by default across most platforms, add code to
+// turn it on in PlatformEnable.h.
+// 2) If the feature is not on by default, but on for Cocoa platforms,
+// add code to turn it on in PlatformEnableCocoa.h.
+// 3) If the feature is on by default, but needs to be off for Cocoa
+// platforms, add code to turn it off in PlatformEnableCocoa.h.
+// 4) If the feature is sometimes on for Cocoa platforms, put the code
+// to make that decision in PlatformEnableCocoa.h.
-// Set any ENABLE_FEATURE_NAME macro to an empty string to disable that feature.
+// Everything currently in this file is going to be removed as soon as
+// possible.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
+
#include "WebKitTargetConditionals.xcconfig"
ENABLE_3D_TRANSFORMS = ENABLE_3D_TRANSFORMS;
Modified: trunk/Source/WebCore/PAL/ChangeLog (263931 => 263932)
--- trunk/Source/WebCore/PAL/ChangeLog 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/WebCore/PAL/ChangeLog 2020-07-04 13:32:03 UTC (rev 263932)
@@ -1,3 +1,12 @@
+2020-07-04 Darin Adler <[email protected]>
+
+ Update comment in FeatureDefines.xcconfig since PlatformEnableCocoa.h should be used instead
+ https://bugs.webkit.org/show_bug.cgi?id=213952
+
+ Reviewed by Sam Weinig.
+
+ * Configurations/FeatureDefines.xcconfig: Updated comment.
+
2020-07-03 Saagar Jha <[email protected]>
Fix a build error by forward declaring _NSHTTPAlternativeServicesStorage
Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (263931 => 263932)
--- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2020-07-04 13:32:03 UTC (rev 263932)
@@ -22,15 +22,25 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// The contents of this file must be kept in sync with FeatureDefines.xcconfig in _javascript_Core,
-// WebCore, WebKitLegacy and WebKit. Also the default values of the ENABLE_FEATURE_NAME macros in
-// build-webkit should match the values below, but they do not need to be in the same order.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
-// Keep this list of features (not enabled/disabled state) in sync with FeatureDefines.props
-// and FeatureDefinesCairo.props in Source/cmake/tools/vsprops.
+// This file is an obsolete mechanism for setting ENABLE flags for WebKit
+// features on the Cocoa platforms. Instead of adding to this file:
+//
+// 1) If the feature is on by default across most platforms, add code to
+// turn it on in PlatformEnable.h.
+// 2) If the feature is not on by default, but on for Cocoa platforms,
+// add code to turn it on in PlatformEnableCocoa.h.
+// 3) If the feature is on by default, but needs to be off for Cocoa
+// platforms, add code to turn it off in PlatformEnableCocoa.h.
+// 4) If the feature is sometimes on for Cocoa platforms, put the code
+// to make that decision in PlatformEnableCocoa.h.
-// Set any ENABLE_FEATURE_NAME macro to an empty string to disable that feature.
+// Everything currently in this file is going to be removed as soon as
+// possible.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
+
#include "WebKitTargetConditionals.xcconfig"
ENABLE_3D_TRANSFORMS = ENABLE_3D_TRANSFORMS;
Modified: trunk/Source/WebKit/ChangeLog (263931 => 263932)
--- trunk/Source/WebKit/ChangeLog 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/WebKit/ChangeLog 2020-07-04 13:32:03 UTC (rev 263932)
@@ -1,3 +1,12 @@
+2020-07-04 Darin Adler <[email protected]>
+
+ Update comment in FeatureDefines.xcconfig since PlatformEnableCocoa.h should be used instead
+ https://bugs.webkit.org/show_bug.cgi?id=213952
+
+ Reviewed by Sam Weinig.
+
+ * Configurations/FeatureDefines.xcconfig: Updated comment.
+
2020-07-04 Youenn Fablet <[email protected]>
Enable VTB required low latency code path
Modified: trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig (263931 => 263932)
--- trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig 2020-07-04 13:32:03 UTC (rev 263932)
@@ -22,15 +22,25 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// The contents of this file must be kept in sync with FeatureDefines.xcconfig in _javascript_Core,
-// WebCore, WebKitLegacy and WebKit. Also the default values of the ENABLE_FEATURE_NAME macros in
-// build-webkit should match the values below, but they do not need to be in the same order.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
-// Keep this list of features (not enabled/disabled state) in sync with FeatureDefines.props
-// and FeatureDefinesCairo.props in Source/cmake/tools/vsprops.
+// This file is an obsolete mechanism for setting ENABLE flags for WebKit
+// features on the Cocoa platforms. Instead of adding to this file:
+//
+// 1) If the feature is on by default across most platforms, add code to
+// turn it on in PlatformEnable.h.
+// 2) If the feature is not on by default, but on for Cocoa platforms,
+// add code to turn it on in PlatformEnableCocoa.h.
+// 3) If the feature is on by default, but needs to be off for Cocoa
+// platforms, add code to turn it off in PlatformEnableCocoa.h.
+// 4) If the feature is sometimes on for Cocoa platforms, put the code
+// to make that decision in PlatformEnableCocoa.h.
-// Set any ENABLE_FEATURE_NAME macro to an empty string to disable that feature.
+// Everything currently in this file is going to be removed as soon as
+// possible.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
+
#include "WebKitTargetConditionals.xcconfig"
ENABLE_3D_TRANSFORMS = ENABLE_3D_TRANSFORMS;
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (263931 => 263932)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-07-04 13:32:03 UTC (rev 263932)
@@ -1,3 +1,12 @@
+2020-07-04 Darin Adler <[email protected]>
+
+ Update comment in FeatureDefines.xcconfig since PlatformEnableCocoa.h should be used instead
+ https://bugs.webkit.org/show_bug.cgi?id=213952
+
+ Reviewed by Sam Weinig.
+
+ * Configurations/FeatureDefines.xcconfig: Updated comment.
+
2020-07-03 Sam Weinig <[email protected]>
Remove support for ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE
Modified: trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig (263931 => 263932)
--- trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig 2020-07-04 13:32:03 UTC (rev 263932)
@@ -22,15 +22,25 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// The contents of this file must be kept in sync with FeatureDefines.xcconfig in _javascript_Core,
-// WebCore, WebKitLegacy and WebKit. Also the default values of the ENABLE_FEATURE_NAME macros in
-// build-webkit should match the values below, but they do not need to be in the same order.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
-// Keep this list of features (not enabled/disabled state) in sync with FeatureDefines.props
-// and FeatureDefinesCairo.props in Source/cmake/tools/vsprops.
+// This file is an obsolete mechanism for setting ENABLE flags for WebKit
+// features on the Cocoa platforms. Instead of adding to this file:
+//
+// 1) If the feature is on by default across most platforms, add code to
+// turn it on in PlatformEnable.h.
+// 2) If the feature is not on by default, but on for Cocoa platforms,
+// add code to turn it on in PlatformEnableCocoa.h.
+// 3) If the feature is on by default, but needs to be off for Cocoa
+// platforms, add code to turn it off in PlatformEnableCocoa.h.
+// 4) If the feature is sometimes on for Cocoa platforms, put the code
+// to make that decision in PlatformEnableCocoa.h.
-// Set any ENABLE_FEATURE_NAME macro to an empty string to disable that feature.
+// Everything currently in this file is going to be removed as soon as
+// possible.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
+
#include "WebKitTargetConditionals.xcconfig"
ENABLE_3D_TRANSFORMS = ENABLE_3D_TRANSFORMS;
Modified: trunk/Tools/ChangeLog (263931 => 263932)
--- trunk/Tools/ChangeLog 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Tools/ChangeLog 2020-07-04 13:32:03 UTC (rev 263932)
@@ -1,3 +1,12 @@
+2020-07-04 Darin Adler <[email protected]>
+
+ Update comment in FeatureDefines.xcconfig since PlatformEnableCocoa.h should be used instead
+ https://bugs.webkit.org/show_bug.cgi?id=213952
+
+ Reviewed by Sam Weinig.
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Updated comment.
+
2020-07-03 Wenson Hsieh <[email protected]>
[macOS] Tests that show system menu popups may fail when run concurrently
Modified: trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (263931 => 263932)
--- trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig 2020-07-04 09:18:47 UTC (rev 263931)
+++ trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig 2020-07-04 13:32:03 UTC (rev 263932)
@@ -22,15 +22,25 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// The contents of this file must be kept in sync with FeatureDefines.xcconfig in _javascript_Core,
-// WebCore, WebKitLegacy and WebKit. Also the default values of the ENABLE_FEATURE_NAME macros in
-// build-webkit should match the values below, but they do not need to be in the same order.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
-// Keep this list of features (not enabled/disabled state) in sync with FeatureDefines.props
-// and FeatureDefinesCairo.props in Source/cmake/tools/vsprops.
+// This file is an obsolete mechanism for setting ENABLE flags for WebKit
+// features on the Cocoa platforms. Instead of adding to this file:
+//
+// 1) If the feature is on by default across most platforms, add code to
+// turn it on in PlatformEnable.h.
+// 2) If the feature is not on by default, but on for Cocoa platforms,
+// add code to turn it on in PlatformEnableCocoa.h.
+// 3) If the feature is on by default, but needs to be off for Cocoa
+// platforms, add code to turn it off in PlatformEnableCocoa.h.
+// 4) If the feature is sometimes on for Cocoa platforms, put the code
+// to make that decision in PlatformEnableCocoa.h.
-// Set any ENABLE_FEATURE_NAME macro to an empty string to disable that feature.
+// Everything currently in this file is going to be removed as soon as
+// possible.
+// *** DO NOT ADD ANYTHING TO THIS FILE ***
+
#include "WebKitTargetConditionals.xcconfig"
ENABLE_3D_TRANSFORMS = ENABLE_3D_TRANSFORMS;
