Title: [263933] trunk/Tools
- Revision
- 263933
- Author
- [email protected]
- Date
- 2020-07-04 09:04:50 -0700 (Sat, 04 Jul 2020)
Log Message
[WebDriver][WPE] Allow running Selenium tests with the WPE WebDriver
https://bugs.webkit.org/show_bug.cgi?id=213500
Reviewed by Carlos Garcia Campos.
Add missing method used to discover the selenium name of
the WPE webdriver.
Proper gardening/triaging of failures will come in following commits.
* Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:
(WebDriverWPE.selenium_name):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (263932 => 263933)
--- trunk/Tools/ChangeLog 2020-07-04 13:32:03 UTC (rev 263932)
+++ trunk/Tools/ChangeLog 2020-07-04 16:04:50 UTC (rev 263933)
@@ -1,3 +1,18 @@
+2020-07-04 Lauro Moura <[email protected]>
+
+ [WebDriver][WPE] Allow running Selenium tests with the WPE WebDriver
+ https://bugs.webkit.org/show_bug.cgi?id=213500
+
+ Reviewed by Carlos Garcia Campos.
+
+ Add missing method used to discover the selenium name of
+ the WPE webdriver.
+
+ Proper gardening/triaging of failures will come in following commits.
+
+ * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:
+ (WebDriverWPE.selenium_name):
+
2020-07-04 Darin Adler <[email protected]>
Update comment in FeatureDefines.xcconfig since PlatformEnableCocoa.h should be used instead
Modified: trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py (263932 => 263933)
--- trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py 2020-07-04 13:32:03 UTC (rev 263932)
+++ trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py 2020-07-04 16:04:50 UTC (rev 263933)
@@ -20,7 +20,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
from webkitpy.webdriver_tests.webdriver_driver import WebDriver, register_driver
@@ -49,5 +48,8 @@
'binary': self.browser_path(),
'args': self.browser_args()}}
+ def selenium_name(self):
+ return 'WPEWebKit'
+
register_driver('wpe', WebDriverWPE)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes