Title: [264295] trunk/Tools
- Revision
- 264295
- Author
- [email protected]
- Date
- 2020-07-13 01:31:23 -0700 (Mon, 13 Jul 2020)
Log Message
[WPE] Stick to default Glib source priorities in HeadlessViewBackend, WindowViewBackend
https://bugs.webkit.org/show_bug.cgi?id=214249
Reviewed by Carlos Garcia Campos.
The -70 GLib source priority was a magic baseline used to align other
GLib source priorities throughout the WPE stack. We moved to the
G_PRIORITY_DEFAULT value since then, so that's the value that should
be used in the two in-tree view backend implementations as well.
* wpe/backends/HeadlessViewBackend.cpp:
(WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
* wpe/backends/WindowViewBackend.cpp:
(WPEToolingBackends::WindowViewBackend::WindowViewBackend):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (264294 => 264295)
--- trunk/Tools/ChangeLog 2020-07-13 06:28:24 UTC (rev 264294)
+++ trunk/Tools/ChangeLog 2020-07-13 08:31:23 UTC (rev 264295)
@@ -1,3 +1,20 @@
+2020-07-13 Zan Dobersek <[email protected]>
+
+ [WPE] Stick to default Glib source priorities in HeadlessViewBackend, WindowViewBackend
+ https://bugs.webkit.org/show_bug.cgi?id=214249
+
+ Reviewed by Carlos Garcia Campos.
+
+ The -70 GLib source priority was a magic baseline used to align other
+ GLib source priorities throughout the WPE stack. We moved to the
+ G_PRIORITY_DEFAULT value since then, so that's the value that should
+ be used in the two in-tree view backend implementations as well.
+
+ * wpe/backends/HeadlessViewBackend.cpp:
+ (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
+ * wpe/backends/WindowViewBackend.cpp:
+ (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
+
2020-07-12 Said Abou-Hallawa <[email protected]>
[macOS]: A HEIF image, selected from the OpenPanel, should be converted to an accepted MIME type
Modified: trunk/Tools/wpe/backends/HeadlessViewBackend.cpp (264294 => 264295)
--- trunk/Tools/wpe/backends/HeadlessViewBackend.cpp 2020-07-13 06:28:24 UTC (rev 264294)
+++ trunk/Tools/wpe/backends/HeadlessViewBackend.cpp 2020-07-13 08:31:23 UTC (rev 264295)
@@ -55,9 +55,6 @@
static cairo_user_data_key_t s_bufferKey;
-// Keep this in sync with wtf/glib/RunLoopSourcePriority.h.
-static int kRunLoopSourcePriorityDispatcher = -70;
-
HeadlessViewBackend::HeadlessViewBackend(uint32_t width, uint32_t height)
: ViewBackend(width, height)
{
@@ -108,7 +105,7 @@
static_cast<HeadlessViewBackend*>(data)->vsync();
return TRUE;
}, this, nullptr);
- g_source_set_priority(m_update.source, kRunLoopSourcePriorityDispatcher);
+ g_source_set_priority(m_update.source, G_PRIORITY_DEFAULT);
g_source_attach(m_update.source, g_main_context_default());
}
Modified: trunk/Tools/wpe/backends/WindowViewBackend.cpp (264294 => 264295)
--- trunk/Tools/wpe/backends/WindowViewBackend.cpp 2020-07-13 06:28:24 UTC (rev 264294)
+++ trunk/Tools/wpe/backends/WindowViewBackend.cpp 2020-07-13 08:31:23 UTC (rev 264295)
@@ -550,7 +550,7 @@
source.pfd.revents = 0;
g_source_add_poll(&source.source, &source.pfd);
- g_source_set_priority(&source.source, G_PRIORITY_HIGH + 30);
+ g_source_set_priority(&source.source, G_PRIORITY_DEFAULT);
g_source_set_can_recurse(&source.source, TRUE);
g_source_attach(&source.source, g_main_context_get_thread_default());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
