Title: [264296] trunk/Source/WebCore
- Revision
- 264296
- Author
- [email protected]
- Date
- 2020-07-13 01:51:45 -0700 (Mon, 13 Jul 2020)
Log Message
[GStreamer] Unreviewed, remove private debug code
When I landed the OpenCDM code I accidentally landed a couple of
things that were internal debug that is not useful upstream.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264295 => 264296)
--- trunk/Source/WebCore/ChangeLog 2020-07-13 08:31:23 UTC (rev 264295)
+++ trunk/Source/WebCore/ChangeLog 2020-07-13 08:51:45 UTC (rev 264296)
@@ -1,3 +1,14 @@
+2020-07-13 Xabier Rodriguez Calvar <[email protected]>
+
+ [GStreamer] Unreviewed, remove private debug code
+
+ When I landed the OpenCDM code I accidentally landed a couple of
+ things that were internal debug that is not useful upstream.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage):
+ (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
+
2020-07-12 Darin Adler <[email protected]>
Some further streamlining of Gradient handling code
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (264295 => 264296)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-07-13 08:31:23 UTC (rev 264295)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2020-07-13 08:51:45 UTC (rev 264296)
@@ -1596,15 +1596,6 @@
bool MediaPlayerPrivateGStreamer::handleSyncMessage(GstMessage* message)
{
- if (GST_MESSAGE_TYPE(message) == GST_MESSAGE_ERROR && !g_strcmp0(g_getenv("WEBKIT_CRASH_ON_GSTREAMER_ERROR"), "sync")) {
- GUniqueOutPtr<GError> err;
- GUniqueOutPtr<gchar> debug;
- gst_message_parse_error(message, &err.outPtr(), &debug.outPtr());
- GST_ERROR("Error %d from %s: %s (url="" err->code, GST_MESSAGE_SRC_NAME(message), err->message, m_url.string().utf8().data());
- GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_ALL, "webkit-video-sync-error");
- ASSERT_NOT_REACHED();
- }
-
if (GST_MESSAGE_TYPE(message) == GST_MESSAGE_STREAM_COLLECTION && !m_isLegacyPlaybin) {
GRefPtr<GstStreamCollection> collection;
gst_message_parse_stream_collection(message, &collection.outPtr());
@@ -1879,9 +1870,6 @@
GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_ALL, "webkit-video.error");
- if (!g_strcmp0(g_getenv("WEBKIT_CRASH_ON_GSTREAMER_ERROR"), "async"))
- CRASH();
-
error = MediaPlayer::NetworkState::Empty;
if (g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_CODEC_NOT_FOUND)
|| g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_WRONG_TYPE)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
