Title: [264508] trunk/Source/WebCore
- Revision
- 264508
- Author
- [email protected]
- Date
- 2020-07-17 07:34:39 -0700 (Fri, 17 Jul 2020)
Log Message
Remove the build warning below and redundant spaces since r263985.
warning: redundant move in return statement [-Wredundant-move]
No new tests, no new behaviors.
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::create):
(WebCore::PannerNode::PannerNode):
* Modules/webaudio/PannerNode.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264507 => 264508)
--- trunk/Source/WebCore/ChangeLog 2020-07-17 14:29:30 UTC (rev 264507)
+++ trunk/Source/WebCore/ChangeLog 2020-07-17 14:34:39 UTC (rev 264508)
@@ -1,3 +1,16 @@
+2020-07-17 Joonghun Park <[email protected]>
+
+ Remove the build warning below and redundant spaces since r263985.
+ warning: redundant move in return statement [-Wredundant-move]
+
+ No new tests, no new behaviors.
+
+ * Modules/webaudio/AudioNode.h:
+ * Modules/webaudio/PannerNode.cpp:
+ (WebCore::PannerNode::create):
+ (WebCore::PannerNode::PannerNode):
+ * Modules/webaudio/PannerNode.h:
+
2020-07-16 Rob Buis <[email protected]>
Make DocumentParser.ParserState an enum class
Modified: trunk/Source/WebCore/Modules/webaudio/AudioNode.h (264507 => 264508)
--- trunk/Source/WebCore/Modules/webaudio/AudioNode.h 2020-07-17 14:29:30 UTC (rev 264507)
+++ trunk/Source/WebCore/Modules/webaudio/AudioNode.h 2020-07-17 14:34:39 UTC (rev 264508)
@@ -210,10 +210,10 @@
volatile bool m_isInitialized { false };
NodeType m_nodeType { NodeTypeUnknown };
Ref<BaseAudioContext> m_context;
-
+
// FIXME: Remove m_sampleRate once old constructor is removed.
float m_sampleRate;
-
+
Vector<std::unique_ptr<AudioNodeInput>> m_inputs;
Vector<std::unique_ptr<AudioNodeOutput>> m_outputs;
Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp (264507 => 264508)
--- trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp 2020-07-17 14:29:30 UTC (rev 264507)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp 2020-07-17 14:34:39 UTC (rev 264508)
@@ -97,32 +97,32 @@
auto result = panner->setMaxDistance(options.maxDistance);
if (result.hasException())
return result.releaseException();
-
+
result = panner->setRefDistance(options.refDistance);
if (result.hasException())
return result.releaseException();
-
+
result = panner->setRolloffFactor(options.rolloffFactor);
if (result.hasException())
return result.releaseException();
-
+
result = panner->setConeOuterGain(options.coneOuterGain);
if (result.hasException())
return result.releaseException();
-
+
result = panner->setChannelCount(options.channelCount.valueOr(2));
if (result.hasException())
return result.releaseException();
-
+
result = panner->setChannelCountMode(options.channelCountMode.valueOr(ChannelCountMode::ClampedMax));
if (result.hasException())
return result.releaseException();
-
+
result = panner->setChannelInterpretation(options.channelInterpretation.valueOr(ChannelInterpretation::Speakers));
if (result.hasException())
return result.releaseException();
-
- return WTFMove(panner);
+
+ return panner;
}
PannerNode::PannerNode(BaseAudioContext& context, const PannerOptions& options)
@@ -143,10 +143,10 @@
setConeInnerAngle(options.coneInnerAngle);
setConeOuterAngle(options.coneOuterAngle);
setNodeType(NodeTypePanner);
-
+
addInput(makeUnique<AudioNodeInput>(this));
addOutput(makeUnique<AudioNodeOutput>(this, 2));
-
+
initialize();
}
Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.h (264507 => 264508)
--- trunk/Source/WebCore/Modules/webaudio/PannerNode.h 2020-07-17 14:29:30 UTC (rev 264507)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.h 2020-07-17 14:34:39 UTC (rev 264508)
@@ -51,7 +51,7 @@
virtual float dopplerRate() = 0;
protected:
-
+
// FIXME: Remove once dependencies on old constructor are removed
PannerNodeBase(BaseAudioContext&, float sampleRate);
PannerNodeBase(BaseAudioContext&);
@@ -72,9 +72,9 @@
{
return adoptRef(*new PannerNode(context, sampleRate));
}
-
+
static ExceptionOr<Ref<PannerNode>> create(BaseAudioContext&, const PannerOptions& = { });
-
+
virtual ~PannerNode();
// AudioNode
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
