Title: [264509] trunk/Source/WebCore
- Revision
- 264509
- Author
- [email protected]
- Date
- 2020-07-17 08:23:34 -0700 (Fri, 17 Jul 2020)
Log Message
Unreviewed. Remove the build warning below and redundant spaces since r264381.
warning: this statement may fall through [-Wimplicit-fallthrough=]
No new tests, no new behaviors.
* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::vertexAttribI4iv):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getVertexAttrib):
(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (264508 => 264509)
--- trunk/Source/WebCore/ChangeLog 2020-07-17 14:34:39 UTC (rev 264508)
+++ trunk/Source/WebCore/ChangeLog 2020-07-17 15:23:34 UTC (rev 264509)
@@ -1,5 +1,18 @@
2020-07-17 Joonghun Park <[email protected]>
+ Unreviewed. Remove the build warning below and redundant spaces since r264381.
+ warning: this statement may fall through [-Wimplicit-fallthrough=]
+
+ No new tests, no new behaviors.
+
+ * html/canvas/WebGL2RenderingContext.cpp:
+ (WebCore::WebGL2RenderingContext::vertexAttribI4iv):
+ * html/canvas/WebGLRenderingContextBase.cpp:
+ (WebCore::WebGLRenderingContextBase::getVertexAttrib):
+ (WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):
+
+2020-07-17 Joonghun Park <[email protected]>
+
Remove the build warning below and redundant spaces since r263985.
warning: redundant move in return statement [-Wredundant-move]
Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp (264508 => 264509)
--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp 2020-07-17 14:34:39 UTC (rev 264508)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp 2020-07-17 15:23:34 UTC (rev 264509)
@@ -1611,7 +1611,7 @@
synthesizeGLError(GraphicsContextGL::INVALID_VALUE, "vertexAttribI4iv", "no array");
return;
}
-
+
int size = list.length();
if (size < 4) {
synthesizeGLError(GraphicsContextGL::INVALID_VALUE, "vertexAttribI4iv", "array too small");
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (264508 => 264509)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2020-07-17 14:34:39 UTC (rev 264508)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2020-07-17 15:23:34 UTC (rev 264509)
@@ -3601,7 +3601,7 @@
return state.originalStride;
case GraphicsContextGL::VERTEX_ATTRIB_ARRAY_TYPE:
return state.type;
- case GraphicsContextGL::CURRENT_VERTEX_ATTRIB:
+ case GraphicsContextGL::CURRENT_VERTEX_ATTRIB: {
switch (m_vertexAttribValue[index].type) {
case GraphicsContextGL::FLOAT:
return Float32Array::tryCreate(m_vertexAttribValue[index].fValue, 4);
@@ -3609,7 +3609,12 @@
return Int32Array::tryCreate(m_vertexAttribValue[index].iValue, 4);
case GraphicsContextGL::UNSIGNED_INT:
return Uint32Array::tryCreate(m_vertexAttribValue[index].uiValue, 4);
+ default:
+ ASSERT_NOT_REACHED();
+ break;
}
+ return nullptr;
+ }
default:
synthesizeGLError(GraphicsContextGL::INVALID_ENUM, "getVertexAttrib", "invalid parameter name");
return nullptr;
@@ -7007,7 +7012,7 @@
synthesizeGLError(GraphicsContextGL::INVALID_VALUE, functionName, "no array");
return;
}
-
+
int size = list.length();
if (size < expectedSize) {
synthesizeGLError(GraphicsContextGL::INVALID_VALUE, functionName, "invalid size");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
