Title: [264859] trunk/Source/WebKit
- Revision
- 264859
- Author
- [email protected]
- Date
- 2020-07-24 14:32:20 -0700 (Fri, 24 Jul 2020)
Log Message
CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::WebFrame::shouldEnableInAppBrowserPrivacyProtections
https://bugs.webkit.org/show_bug.cgi?id=214745
<rdar://66018965>
Reviewed by Chris Dumez.
We should stop iterating if the frame is null, even if it is not
the main frame, to avoid calling functions on a null frame.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::shouldEnableInAppBrowserPrivacyProtections):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264858 => 264859)
--- trunk/Source/WebKit/ChangeLog 2020-07-24 21:31:58 UTC (rev 264858)
+++ trunk/Source/WebKit/ChangeLog 2020-07-24 21:32:20 UTC (rev 264859)
@@ -1,3 +1,17 @@
+2020-07-24 Kate Cheney <[email protected]>
+
+ CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::WebFrame::shouldEnableInAppBrowserPrivacyProtections
+ https://bugs.webkit.org/show_bug.cgi?id=214745
+ <rdar://66018965>
+
+ Reviewed by Chris Dumez.
+
+ We should stop iterating if the frame is null, even if it is not
+ the main frame, to avoid calling functions on a null frame.
+
+ * WebProcess/WebPage/WebFrame.cpp:
+ (WebKit::WebFrame::shouldEnableInAppBrowserPrivacyProtections):
+
2020-07-24 David Kilzer <[email protected]>
WebKit::setCrashReportApplicationSpecificInformation() should also log to WTFLogAlways()
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp (264858 => 264859)
--- trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2020-07-24 21:31:58 UTC (rev 264858)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2020-07-24 21:32:20 UTC (rev 264859)
@@ -862,7 +862,7 @@
bool treeHasNonAppBoundFrame = m_isNavigatingToAppBoundDomain && m_isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::No;
if (!treeHasNonAppBoundFrame) {
- for (WebFrame* frame = this; !frame->isMainFrame(); frame = frame->parentFrame()) {
+ for (WebFrame* frame = this; frame; frame = frame->parentFrame()) {
if (frame->isNavigatingToAppBoundDomain() && frame->isNavigatingToAppBoundDomain() == NavigatingToAppBoundDomain::No) {
treeHasNonAppBoundFrame = true;
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
