Title: [264858] trunk/Source/WebKit
- Revision
- 264858
- Author
- [email protected]
- Date
- 2020-07-24 14:31:58 -0700 (Fri, 24 Jul 2020)
Log Message
WebKit::setCrashReportApplicationSpecificInformation() should also log to WTFLogAlways()
<https://webkit.org/b/214756>
Reviewed by Chris Dumez.
* Platform/cocoa/WKCrashReporter.mm:
(WebKit::setCrashReportApplicationSpecificInformation):
- Also output the log information via WTFLogAlways() in case
Application Specific Information is overwritten or is not
included in the crash log.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264857 => 264858)
--- trunk/Source/WebKit/ChangeLog 2020-07-24 21:29:40 UTC (rev 264857)
+++ trunk/Source/WebKit/ChangeLog 2020-07-24 21:31:58 UTC (rev 264858)
@@ -1,3 +1,16 @@
+2020-07-24 David Kilzer <[email protected]>
+
+ WebKit::setCrashReportApplicationSpecificInformation() should also log to WTFLogAlways()
+ <https://webkit.org/b/214756>
+
+ Reviewed by Chris Dumez.
+
+ * Platform/cocoa/WKCrashReporter.mm:
+ (WebKit::setCrashReportApplicationSpecificInformation):
+ - Also output the log information via WTFLogAlways() in case
+ Application Specific Information is overwritten or is not
+ included in the crash log.
+
2020-07-24 Chris Dumez <[email protected]>
Crash under PreconnectTask::start()
Modified: trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm (264857 => 264858)
--- trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm 2020-07-24 21:29:40 UTC (rev 264857)
+++ trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm 2020-07-24 21:31:58 UTC (rev 264858)
@@ -33,7 +33,9 @@
void setCrashReportApplicationSpecificInformation(CFStringRef infoString)
{
- WTF::setCrashLogMessage([(__bridge NSString *)infoString UTF8String]);
+ auto* cInfoString = [(__bridge NSString *)infoString UTF8String];
+ WTFLogAlways("%s", cInfoString);
+ WTF::setCrashLogMessage(cInfoString);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
