Title: [265124] trunk/Tools
Revision
265124
Author
[email protected]
Date
2020-07-30 18:14:26 -0700 (Thu, 30 Jul 2020)

Log Message

webkitpy: If LC_ALL is set to a empty string, svn doesn't use the password store
https://bugs.webkit.org/show_bug.cgi?id=214983

Reviewed by Darin Adler.

If LC_ALL is set to a empty string, svn doesn't use the password
store in my environment. I'm using svn with gpg-agent on Ubuntu
20.04 (svn version 1.13.0, gpg-agent 2.2.19).

r101274 (Bug 68691) has set LC_ALL to a empty string.

If I invoke 'svn ci' on my terminal, svn askes gpg-agent my
password as expected, but if I invoke 'LC_ALL= svn ci', svn askes
my password by itself.

* Scripts/webkitpy/common/host.py:
(Host._engage_awesome_locale_hacks): Set the env var LC_ALL to 'en_US.UTF-8'.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (265123 => 265124)


--- trunk/Tools/ChangeLog	2020-07-31 00:42:41 UTC (rev 265123)
+++ trunk/Tools/ChangeLog	2020-07-31 01:14:26 UTC (rev 265124)
@@ -1,3 +1,23 @@
+2020-07-30  Fujii Hironori  <[email protected]>
+
+        webkitpy: If LC_ALL is set to a empty string, svn doesn't use the password store
+        https://bugs.webkit.org/show_bug.cgi?id=214983
+
+        Reviewed by Darin Adler.
+
+        If LC_ALL is set to a empty string, svn doesn't use the password
+        store in my environment. I'm using svn with gpg-agent on Ubuntu
+        20.04 (svn version 1.13.0, gpg-agent 2.2.19).
+
+        r101274 (Bug 68691) has set LC_ALL to a empty string.
+
+        If I invoke 'svn ci' on my terminal, svn askes gpg-agent my
+        password as expected, but if I invoke 'LC_ALL= svn ci', svn askes
+        my password by itself.
+
+        * Scripts/webkitpy/common/host.py:
+        (Host._engage_awesome_locale_hacks): Set the env var LC_ALL to 'en_US.UTF-8'.
+
 2020-07-30  Jonathan Bedard  <[email protected]>
 
         [webkitcorepy] Make scripts called with sudo use a userspace autoinstall

Modified: trunk/Tools/Scripts/webkitpy/common/host.py (265123 => 265124)


--- trunk/Tools/Scripts/webkitpy/common/host.py	2020-07-31 00:42:41 UTC (rev 265123)
+++ trunk/Tools/Scripts/webkitpy/common/host.py	2020-07-31 01:14:26 UTC (rev 265124)
@@ -85,7 +85,7 @@
         os.environ['LANGUAGE'] = 'en'
         os.environ['LANG'] = 'en_US.UTF-8'
         os.environ['LC_MESSAGES'] = 'en_US.UTF-8'
-        os.environ['LC_ALL'] = ''
+        os.environ['LC_ALL'] = 'en_US.UTF-8'
 
     def initialize_scm(self, patch_directories=None):
         detector = SCMDetector(self.filesystem, self.executive)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to