Title: [265125] trunk/Source/WebInspectorUI
Revision
265125
Author
[email protected]
Date
2020-07-30 18:44:55 -0700 (Thu, 30 Jul 2020)

Log Message

REGRESSION (r?): Web Inspector: Timelines: blue border below selected timeline when in edit mode
https://bugs.webkit.org/show_bug.cgi?id=214979
<rdar://problem/66338399>

Reviewed by Devin Rousso.

Color the top border after the selected item with the same background as the selected item.
When editing, don't color that border with the selected item background.

* UserInterface/Views/TimelineOverview.css:
(.timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),):
(body:matches(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines .item.selected + .item):
(body:not(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines:focus-within .item.selected + .item):
(@media (prefers-color-scheme: dark) .timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even)):
(.timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .timeline-overview > .tree-outline.timelines:focus-within .item.selected + .item): Deleted.
(@media (prefers-color-scheme: dark) .timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),): Deleted.
(@media (prefers-color-scheme: dark) .timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (265124 => 265125)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-07-31 01:14:26 UTC (rev 265124)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-07-31 01:44:55 UTC (rev 265125)
@@ -1,3 +1,24 @@
+2020-07-30  Nikita Vasilyev  <[email protected]>
+
+        REGRESSION (r?): Web Inspector: Timelines: blue border below selected timeline when in edit mode
+        https://bugs.webkit.org/show_bug.cgi?id=214979
+        <rdar://problem/66338399>
+
+        Reviewed by Devin Rousso.
+
+        Color the top border after the selected item with the same background as the selected item.
+        When editing, don't color that border with the selected item background.
+
+        * UserInterface/Views/TimelineOverview.css:
+        (.timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),):
+        (body:matches(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines .item.selected + .item):
+        (body:not(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines:focus-within .item.selected + .item):
+        (@media (prefers-color-scheme: dark) .timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even)):
+        (.timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.
+        (body:not(.window-inactive, .window-docked-inactive) .timeline-overview > .tree-outline.timelines:focus-within .item.selected + .item): Deleted.
+        (@media (prefers-color-scheme: dark) .timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),): Deleted.
+        (@media (prefers-color-scheme: dark) .timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.
+
 2020-07-30  Devin Rousso  <[email protected]>
 
         Web Inspector: Add another Protocol Version (iOS 14.0)

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css (265124 => 265125)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css	2020-07-31 01:14:26 UTC (rev 265124)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css	2020-07-31 01:44:55 UTC (rev 265125)
@@ -113,15 +113,15 @@
 
 .timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),
 .timeline-overview > .tree-outline.timelines .item:not(.selected):not(:first-child) {
-    border-top: 1px solid hsla(0, 0%, 0%, 0.09);
+    border-top-color: hsla(0, 0%, var(--foreground-lightness), 0.09);
 }
 
-.timeline-overview > .tree-outline.timelines .item.selected + .item {
-    border-top-color: hsl(0, 0%, 83%);
+body:matches(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines .item.selected + .item {
+    border-top-color: var(--selected-background-color-unfocused);
 }
 
-body:not(.window-inactive, .window-docked-inactive) .timeline-overview > .tree-outline.timelines:focus-within .item.selected + .item {
-    border-top-color: hsl(209, 100%, 49%);
+body:not(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines:focus-within .item.selected + .item {
+    border-top-color: var(--selected-background-color);
 }
 
 .timeline-overview > .scroll-container {
@@ -238,13 +238,4 @@
     .timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even) {
         background: var(--background-color-alternate);
     }
-
-    .timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),
-    .timeline-overview > .tree-outline.timelines .item:not(.selected):not(:first-child) {
-        border-top-color: hsla(0, 0%, var(--foreground-lightness), 0.09);
-    }
-
-    .timeline-overview > .tree-outline.timelines .item.selected + .item {
-        border-top-color: hsla(0, 0%, var(--foreground-lightness), 0.09);
-    }
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to